Fabian Maurer : user32/tests: Fix ok_sequence succeeding in todo block not giving a test failure.
Module: wine Branch: master Commit: d919d572932c424b71a0e8a4059d9c207e3ee1fe URL: https://gitlab.winehq.org/wine/wine/-/commit/d919d572932c424b71a0e8a4059d9c2... Author: Fabian Maurer <dark.shadow4(a)web.de> Date: Fri May 31 01:55:19 2024 +0200 user32/tests: Fix ok_sequence succeeding in todo block not giving a test failure. --- dlls/user32/tests/msg.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index bcb376cb14b..1a264268e8c 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -2916,7 +2916,11 @@ static void ok_sequence_(const struct message *expected_list, const char *contex messages_equal(expected, actual, TRUE, file, line); } } - if (is_wine) goto done; + if (is_wine && !failcount) /* succeeded yet marked todo */ + todo_wine { + dump++; + ok_( file, line)( TRUE, "marked \"todo_wine\" but succeeds\n"); + } } else { @@ -2926,11 +2930,6 @@ static void ok_sequence_(const struct message *expected_list, const char *contex messages_equal(expected, actual, TRUE, file, line); } } - if (todo && !failcount && !strcmp(winetest_platform, "wine")) /* succeeded yet marked todo */ - todo_wine { - dump++; - ok_( file, line)( TRUE, "marked \"todo_wine\" but succeeds\n"); - } done: winetest_pop_context();
participants (1)
-
Alexandre Julliard