Francois Gouget : testbot: Log errors that happen when updating a Job' s status.
Module: tools Branch: master Commit: 49f73ecbab8cbe8894895c9f9a8f8ee0b70b7147 URL: https://source.winehq.org/git/tools.git/?a=commit;h=49f73ecbab8cbe8894895c9f... Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jun 5 10:52:34 2018 +0200 testbot: Log errors that happen when updating a Job's status. Such errors are important as they can prevent the Jobs from ever being marked as completed. So trace them. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Jobs.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index b1ffd3e..13a3895 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -243,7 +243,12 @@ sub UpdateStatus($) { $self->Ended(time); } - $self->Save(); + my ($ErrProperty, $ErrMessage) = $self->Save(); + if (defined $ErrMessage) + { + require WineTestBot::Log; + WineTestBot::Log::LogMsg("Could not update job status: $ErrMessage\n"); + } last; } }
participants (1)
-
Alexandre Julliard