Michael Stefaniuc : dxdiagn: Avoid assigning COM objects to interface variables.
Module: wine Branch: master Commit: e4b30b46c348b63eb07d5721338bfaad3353f8d9 URL: https://gitlab.winehq.org/wine/wine/-/commit/e4b30b46c348b63eb07d5721338bfaa... Author: Michael Stefaniuc <mstefani(a)winehq.org> Date: Tue May 9 18:27:29 2023 +0200 dxdiagn: Avoid assigning COM objects to interface variables. --- dlls/dxdiagn/container.c | 2 +- dlls/dxdiagn/provider.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dxdiagn/container.c b/dlls/dxdiagn/container.c index efc8cba448e..2627c321fa1 100644 --- a/dlls/dxdiagn/container.c +++ b/dlls/dxdiagn/container.c @@ -42,7 +42,7 @@ static HRESULT WINAPI IDxDiagContainerImpl_QueryInterface(IDxDiagContainer *ifac if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IDxDiagContainer)) { IUnknown_AddRef(iface); - *ppobj = This; + *ppobj = &This->IDxDiagContainer_iface; return S_OK; } diff --git a/dlls/dxdiagn/provider.c b/dlls/dxdiagn/provider.c index d4a58dc45bc..0df10ea56ef 100644 --- a/dlls/dxdiagn/provider.c +++ b/dlls/dxdiagn/provider.c @@ -70,7 +70,7 @@ static HRESULT WINAPI IDxDiagProviderImpl_QueryInterface(IDxDiagProvider *iface, if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_IDxDiagProvider)) { IUnknown_AddRef(iface); - *ppobj = This; + *ppobj = &This->IDxDiagProvider_iface; return S_OK; }
participants (1)
-
Alexandre Julliard