Sven Baars : msi: Fix a leak on error path (Coverity).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: fe91ae51f1553875c1858df264c0603877d50737
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=fe91ae51f1553875c1858df26...

Author: Sven Baars <sven.wine(a)gmail.com>
Date:   Thu Sep 26 16:32:28 2019 +0200

msi: Fix a leak on error path (Coverity).

Signed-off-by: Sven Baars <sven.wine(a)gmail.com>
Signed-off-by: Hans Leidekker <hans(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/msi/dialog.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index 6ccf46ec30..8a28e4d4af 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -4033,7 +4033,11 @@ static msi_dialog *dialog_create( MSIPACKAGE *package, const WCHAR *name, msi_di
     msiobj_release( &rec->hdr );
 
     rec = MSI_CreateRecord(2);
-    if (!rec) return NULL;
+    if (!rec)
+    {
+        msi_dialog_destroy(dialog);
+        return NULL;
+    }
     MSI_RecordSetStringW(rec, 1, name);
     MSI_RecordSetStringW(rec, 2, szDialogCreated);
     MSI_ProcessMessage(package, INSTALLMESSAGE_ACTIONSTART, rec);