Francois Gouget : testbot/TestAgent: Fix the Ping() RPC.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 69d6211ba314e2a1504f5394cff96c04c4072dc8
URL:    http://source.winehq.org/git/tools.git/?a=commit;h=69d6211ba314e2a1504f5394c...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Thu Dec  6 20:58:12 2012 +0100

testbot/TestAgent: Fix the Ping() RPC.

It's not used for the connection setup so it can be implemented normally.

---

 testbot/lib/WineTestBot/TestAgent.pm |   16 +++++-----------
 1 files changed, 5 insertions(+), 11 deletions(-)

diff --git a/testbot/lib/WineTestBot/TestAgent.pm b/testbot/lib/WineTestBot/TestAgent.pm
index e0066c5..8bc3e59 100644
--- a/testbot/lib/WineTestBot/TestAgent.pm
+++ b/testbot/lib/WineTestBot/TestAgent.pm
@@ -848,16 +848,6 @@ sub _Connect($)
   return 1;
 }
 
-sub _Ping($)
-{
-  my ($self) = @_;
-
-  # Send the RPC and get the reply
-  return $self->_SendRawUInt32($RPC_PING) &&
-         $self->_SendListSize(0) &&
-         $self->_RecvList('');
-}
-
 sub _StartRPC($$)
 {
   my ($self, $RpcId) = @_;
@@ -892,7 +882,11 @@ sub _StartRPC($$)
 sub Ping($)
 {
   my ($self) = @_;
-  return $self->_StartRPC($RPC_PING);
+
+  # Send the RPC and get the reply
+  return $self->_StartRPC($RPC_PING) &&
+         $self->_SendListSize(0) &&
+         $self->_RecvList('');
 }
 
 sub GetVersion($)