Zebediah Figura : winegstreamer: Initialize media source video types from a wg_video_format array.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 98d209752cee9abd8dc31dfe1f28811066b0b83f
URL:    https://gitlab.winehq.org/wine/wine/-/commit/98d209752cee9abd8dc31dfe1f28811...

Author: Zebediah Figura <zfigura(a)codeweavers.com>
Date:   Tue Jan 24 16:25:00 2023 -0600

winegstreamer: Initialize media source video types from a wg_video_format array.

The mf_media_type_from_wg_format function will use the video format to calculate stride.

---

 dlls/winegstreamer/media_source.c | 43 ++++++++++++++++++++++++---------------
 1 file changed, 27 insertions(+), 16 deletions(-)

diff --git a/dlls/winegstreamer/media_source.c b/dlls/winegstreamer/media_source.c
index 1b57d8bfba8..e9db8dcc0a2 100644
--- a/dlls/winegstreamer/media_source.c
+++ b/dlls/winegstreamer/media_source.c
@@ -866,15 +866,15 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
 
     if (format.major_type == WG_MAJOR_TYPE_VIDEO)
     {
-        /* These are the most common native output types of decoders:
-            https://docs.microsoft.com/en-us/windows/win32/medfound/mft-decoder-expose-o... */
-        static const GUID *const video_types[] =
+        /* Try to prefer YUV formats over RGB ones. Most decoders output in the
+         * YUV color space, and it's generally much less expensive for
+         * videoconvert to do YUV -> YUV transformations. */
+        static const enum wg_video_format video_formats[] =
         {
-            &MFVideoFormat_NV12,
-            &MFVideoFormat_YV12,
-            &MFVideoFormat_YUY2,
-            &MFVideoFormat_IYUV,
-            &MFVideoFormat_I420,
+            WG_VIDEO_FORMAT_NV12,
+            WG_VIDEO_FORMAT_YV12,
+            WG_VIDEO_FORMAT_YUY2,
+            WG_VIDEO_FORMAT_I420,
         };
 
         IMFMediaType *base_type = mf_media_type_from_wg_format(&format);
@@ -891,21 +891,32 @@ static HRESULT media_stream_init_desc(struct media_stream *stream)
         stream_types[0] = base_type;
         type_count = 1;
 
-        for (i = 0; i < ARRAY_SIZE(video_types); i++)
+        for (i = 0; i < ARRAY_SIZE(video_formats); ++i)
         {
+            struct wg_format new_format = format;
             IMFMediaType *new_type;
 
-            if (IsEqualGUID(&base_subtype, video_types[i]))
-                continue;
+            new_format.u.video.format = video_formats[i];
 
-            if (FAILED(hr = MFCreateMediaType(&new_type)))
+            if (!(new_type = mf_media_type_from_wg_format(&new_format)))
+            {
+                hr = E_OUTOFMEMORY;
                 goto done;
+            }
             stream_types[type_count++] = new_type;
 
-            if (FAILED(hr = IMFMediaType_CopyAllItems(base_type, (IMFAttributes *) new_type)))
-                goto done;
-            if (FAILED(hr = IMFMediaType_SetGUID(new_type, &MF_MT_SUBTYPE, video_types[i])))
-                goto done;
+            if (video_formats[i] == WG_VIDEO_FORMAT_I420)
+            {
+                IMFMediaType *iyuv_type;
+
+                if (FAILED(hr = MFCreateMediaType(&iyuv_type)))
+                    goto done;
+                if (FAILED(hr = IMFMediaType_CopyAllItems(iyuv_type, (IMFAttributes *)iyuv_type)))
+                    goto done;
+                if (FAILED(hr = IMFMediaType_SetGUID(iyuv_type, &MF_MT_SUBTYPE, &MFVideoFormat_IYUV)))
+                    goto done;
+                stream_types[type_count++] = iyuv_type;
+            }
         }
     }
     else if (format.major_type == WG_MAJOR_TYPE_AUDIO)