Alex Henrie : regedit: Fix memory leak on error path in RenameKey (scan-build).
Module: wine Branch: master Commit: 3d383c468b1b6e784dee13e4b55a0972c79f83f2 URL: https://gitlab.winehq.org/wine/wine/-/commit/3d383c468b1b6e784dee13e4b55a097... Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sun Jun 18 22:32:00 2023 -0600 regedit: Fix memory leak on error path in RenameKey (scan-build). parentPath is allocated before parentKey. --- programs/regedit/edit.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/programs/regedit/edit.c b/programs/regedit/edit.c index 66d3a27dc68..947a6071e0f 100644 --- a/programs/regedit/edit.c +++ b/programs/regedit/edit.c @@ -680,9 +680,7 @@ BOOL RenameKey(HWND hwnd, HKEY hRootKey, LPCWSTR keyPath, LPCWSTR newName) done: RegCloseKey(destKey); - if (parentKey) { - RegCloseKey(parentKey); - free(parentPath); - } + RegCloseKey(parentKey); + free(parentPath); return result; }
participants (1)
-
Alexandre Julliard