Alex Henrie : winhttp: Fix double free on error path in queue_task (scan-build).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: b630718149866ac7056588dc931793d54ae28eb1
URL:    https://gitlab.winehq.org/wine/wine/-/commit/b630718149866ac7056588dc931793d...

Author: Alex Henrie <alexhenrie24(a)gmail.com>
Date:   Wed Jun  7 22:20:46 2023 -0600

winhttp: Fix double free on error path in queue_task (scan-build).

queue_task cannot free the struct because it doesn't know whether the
struct contains pointers to other dynamically allocated memory that also
needs to be freed (as is the case with struct send_request).

---

 dlls/winhttp/request.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c
index 07d0ff19b7c..cf091244002 100644
--- a/dlls/winhttp/request.c
+++ b/dlls/winhttp/request.c
@@ -218,7 +218,6 @@ static DWORD queue_task( struct queue *queue, TASK_CALLBACK task, struct task_he
     if (!callback_running)
     {
         release_object( obj );
-        free( task_hdr );
         ERR( "Submiting threadpool callback failed, err %lu.\n", GetLastError() );
         return ERROR_OUTOFMEMORY;
     }