Henri Verbeet : d3d8/tests: Properly check whether creating a device succeeded in test_flip().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 3932b2f2a75cebae7ab663d4c04f685307f527eb
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=3932b2f2a75cebae7ab663d4c...

Author: Henri Verbeet <hverbeet(a)codeweavers.com>
Date:   Sat Sep 22 03:14:05 2018 +0330

d3d8/tests: Properly check whether creating a device succeeded in test_flip().

Perhaps CreateDevice() should clear the pointer on failure, but that's not
documented behaviour, and Wine currently doesn't.

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/d3d8/tests/visual.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/dlls/d3d8/tests/visual.c b/dlls/d3d8/tests/visual.c
index 24481bd..e8e6bf8 100644
--- a/dlls/d3d8/tests/visual.c
+++ b/dlls/d3d8/tests/visual.c
@@ -8154,9 +8154,8 @@ static void test_flip(void)
     present_parameters.Windowed = TRUE;
     present_parameters.BackBufferCount = 3;
     present_parameters.Flags = D3DPRESENTFLAG_LOCKABLE_BACKBUFFER;
-    hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL,
-            window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device);
-    if (!device)
+    if (FAILED(hr = IDirect3D8_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL,
+            window, D3DCREATE_SOFTWARE_VERTEXPROCESSING, &present_parameters, &device)))
     {
         skip("Failed to create a D3D device, skipping tests.\n");
         IDirect3D8_Release(d3d);