Rémi Bernon : ole32: Reset IMoniker data pointer to NULL on failure.
Module: wine Branch: master Commit: a547efc094ca89461731c49302883e4d45692eb9 URL: https://gitlab.winehq.org/wine/wine/-/commit/a547efc094ca89461731c49302883e4... Author: Rémi Bernon <rbernon(a)codeweavers.com> Date: Fri Dec 2 08:47:56 2022 +0100 ole32: Reset IMoniker data pointer to NULL on failure. To avoid double free when the caller releases the object. --- dlls/ole32/moniker.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/ole32/moniker.c b/dlls/ole32/moniker.c index be6150bc7b6..f98b21bdf2b 100644 --- a/dlls/ole32/moniker.c +++ b/dlls/ole32/moniker.c @@ -161,6 +161,7 @@ static HRESULT get_moniker_comparison_data(IMoniker *pMoniker, MonikerComparison { ERR("Failed to copy comparison data into buffer, hr = %#lx\n", hr); HeapFree(GetProcessHeap(), 0, *moniker_data); + *moniker_data = NULL; return hr; } (*moniker_data)->ulCntData = size;
participants (1)
-
Alexandre Julliard