Gabriel Ivăncescu : mshtml: Use unlink and destructor in the vtbl for HTMLXMLHttpRequestFactory.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 2e5ac78a7c0ca6a65d1ec97184c4053186fa1005
URL:    https://gitlab.winehq.org/wine/wine/-/commit/2e5ac78a7c0ca6a65d1ec97184c4053...

Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com>
Date:   Tue Aug  1 19:45:25 2023 +0300

mshtml: Use unlink and destructor in the vtbl for HTMLXMLHttpRequestFactory.

Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com>

---

 dlls/mshtml/xmlhttprequest.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/dlls/mshtml/xmlhttprequest.c b/dlls/mshtml/xmlhttprequest.c
index 4803b5c55a1..73eea9d7f6d 100644
--- a/dlls/mshtml/xmlhttprequest.c
+++ b/dlls/mshtml/xmlhttprequest.c
@@ -1640,10 +1640,8 @@ static ULONG WINAPI HTMLXMLHttpRequestFactory_Release(IHTMLXMLHttpRequestFactory
 
     TRACE("(%p) ref=%ld\n", This, ref);
 
-    if(!ref) {
+    if(!ref)
         release_dispex(&This->dispex);
-        free(This);
-    }
 
     return ref;
 }
@@ -1766,6 +1764,12 @@ static inline HTMLXMLHttpRequestFactory *factory_from_DispatchEx(DispatchEx *ifa
     return CONTAINING_RECORD(iface, HTMLXMLHttpRequestFactory, dispex);
 }
 
+static void HTMLXMLHttpRequestFactory_destructor(DispatchEx *dispex)
+{
+    HTMLXMLHttpRequestFactory *This = factory_from_DispatchEx(dispex);
+    free(This);
+}
+
 static HRESULT HTMLXMLHttpRequestFactory_value(DispatchEx *iface, LCID lcid, WORD flags, DISPPARAMS *params,
         VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller)
 {
@@ -1790,7 +1794,7 @@ static HRESULT HTMLXMLHttpRequestFactory_value(DispatchEx *iface, LCID lcid, WOR
 }
 
 static const dispex_static_data_vtbl_t HTMLXMLHttpRequestFactory_dispex_vtbl = {
-    NULL,
+    HTMLXMLHttpRequestFactory_destructor,
     NULL,
     HTMLXMLHttpRequestFactory_value
 };