Fabian Maurer : win32u: Prevent use after free (Coverity).
Module: wine Branch: master Commit: df90a32511d44246930b426ee057318ccaa1a874 URL: https://gitlab.winehq.org/wine/wine/-/commit/df90a32511d44246930b426ee057318... Author: Fabian Maurer <dark.shadow4(a)web.de> Date: Wed Nov 2 04:57:33 2022 +0100 win32u: Prevent use after free (Coverity). Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> --- dlls/win32u/message.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/dlls/win32u/message.c b/dlls/win32u/message.c index caffd837c8b..346ae8bede7 100644 --- a/dlls/win32u/message.c +++ b/dlls/win32u/message.c @@ -1368,7 +1368,6 @@ static LRESULT call_window_proc( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lpar call_hooks( WH_CALLWNDPROC, HC_ACTION, same_thread, (LPARAM)&cwp, sizeof(cwp) ); dispatch_win_proc_params( params, sizeof(*params) + size ); - if (params != &p) free( params ); /* and finally the WH_CALLWNDPROCRET hook */ cwpret.lResult = result; @@ -1376,6 +1375,9 @@ static LRESULT call_window_proc( HWND hwnd, UINT msg, WPARAM wparam, LPARAM lpar cwpret.wParam = wparam; cwpret.message = msg; cwpret.hwnd = params->hwnd; + + if (params != &p) free( params ); + call_hooks( WH_CALLWNDPROCRET, HC_ACTION, same_thread, (LPARAM)&cwpret, sizeof(cwpret) ); return result; }
participants (1)
-
Alexandre Julliard