Francois Gouget : testbot: Avoid map when when items must be handled in order.
Module: tools Branch: master Commit: b278c2a057677b8d280cf823d74622b8880658ba URL: https://source.winehq.org/git/tools.git/?a=commit;h=b278c2a057677b8d280cf823... Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Aug 20 09:05:22 2018 +0200 testbot: Avoid map when when items must be handled in order. Instead use 'statement($_) for (@List)' which is just as readable. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/PendingPatchSets.pm | 2 +- testbot/web/Munin.pl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/testbot/lib/WineTestBot/PendingPatchSets.pm b/testbot/lib/WineTestBot/PendingPatchSets.pm index fc22a86..4ef7a66 100644 --- a/testbot/lib/WineTestBot/PendingPatchSets.pm +++ b/testbot/lib/WineTestBot/PendingPatchSets.pm @@ -113,7 +113,7 @@ sub SubmitSubset($$$) if (defined $Part and open(my $PartFile, "<" , "$DataDir/patches/" . $Part->Patch->Id)) { - map { print $CombinedFile $_; } <$PartFile>; + print $CombinedFile $_ for (<$PartFile>); close($PartFile); } } diff --git a/testbot/web/Munin.pl b/testbot/web/Munin.pl index 91155b7..840d912 100755 --- a/testbot/web/Munin.pl +++ b/testbot/web/Munin.pl @@ -474,7 +474,7 @@ sub GetOutput($) # Then print the corresponding data print "===== data =====\n"; - map { print $_ } @Data; + print $_ for (@Data); }
participants (1)
-
Alexandre Julliard