Zebediah Figura : ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: d3c8842a6ef539bde7bc8132343f82673235c83a
URL:    https://gitlab.winehq.org/wine/wine/-/commit/d3c8842a6ef539bde7bc8132343f826...

Author: Zebediah Figura <zfigura(a)codeweavers.com>
Date:   Thu Sep 15 23:32:25 2022 -0500

ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block.

We can only get a successful status that way. This matches sock_recv().

---

 dlls/ntdll/unix/socket.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/dlls/ntdll/unix/socket.c b/dlls/ntdll/unix/socket.c
index 44694f8c404..cc3c898d464 100644
--- a/dlls/ntdll/unix/socket.c
+++ b/dlls/ntdll/unix/socket.c
@@ -1116,6 +1116,9 @@ static NTSTATUS sock_send( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, voi
     }
     SERVER_END_REQ;
 
+    /* the server currently will never succeed immediately */
+    assert(status == STATUS_ALERTED || status == STATUS_PENDING || NT_ERROR(status));
+
     if (!NT_ERROR(status) && is_icmp_over_dgram( fd ))
         sock_save_icmp_id( async );
 
@@ -1132,19 +1135,17 @@ static NTSTATUS sock_send( HANDLE handle, HANDLE event, PIO_APC_ROUTINE apc, voi
          * and returns EWOULDBLOCK, but we have no way of doing that. */
         if (status == STATUS_DEVICE_NOT_READY && async->sent_len)
             status = STATUS_SUCCESS;
-    }
 
-    if (status != STATUS_PENDING)
-    {
         information = async->sent_len;
-        if (!NT_ERROR(status) || (wait_handle && !alerted))
+        if (!NT_ERROR(status) && status != STATUS_PENDING)
         {
             io->Status = status;
             io->Information = information;
         }
-        release_fileio( &async->io );
     }
-    else information = 0;
+
+    if (status != STATUS_PENDING)
+        release_fileio( &async->io );
 
     if (alerted) set_async_direct_result( &wait_handle, status, information, FALSE );
     if (wait_handle) status = wait_async( wait_handle, options & FILE_SYNCHRONOUS_IO_ALERT );