Rémi Bernon : win32u: Introduce new next_process_user_handle_ptr helper.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 7297a8e69c5446694b2c0cc05918b4da15f01426
URL:    https://gitlab.winehq.org/wine/wine/-/commit/7297a8e69c5446694b2c0cc05918b4d...

Author: Rémi Bernon <rbernon(a)codeweavers.com>
Date:   Sat Mar 11 09:24:35 2023 +0100

win32u: Introduce new next_process_user_handle_ptr helper.

And use it instead of next_thread_window_ptr.

---

 dlls/win32u/ntuser_private.h |  6 +-----
 dlls/win32u/window.c         | 48 ++++++++++++++++++++++----------------------
 2 files changed, 25 insertions(+), 29 deletions(-)

diff --git a/dlls/win32u/ntuser_private.h b/dlls/win32u/ntuser_private.h
index 5c337c722a7..c9c2dfa571a 100644
--- a/dlls/win32u/ntuser_private.h
+++ b/dlls/win32u/ntuser_private.h
@@ -52,11 +52,6 @@ struct user_object
 
 #define OBJ_OTHER_PROCESS ((void *)1)  /* returned by get_user_handle_ptr on unknown handles */
 
-HANDLE alloc_user_handle( struct user_object *ptr, unsigned int type ) DECLSPEC_HIDDEN;
-void *get_user_handle_ptr( HANDLE handle, unsigned int type ) DECLSPEC_HIDDEN;
-void release_user_handle_ptr( void *ptr ) DECLSPEC_HIDDEN;
-void *free_user_handle( HANDLE handle, unsigned int type ) DECLSPEC_HIDDEN;
-
 typedef struct tagWND
 {
     struct user_object obj;           /* object header */
@@ -246,6 +241,7 @@ HANDLE alloc_user_handle( struct user_object *ptr, unsigned int type ) DECLSPEC_
 void *free_user_handle( HANDLE handle, unsigned int type ) DECLSPEC_HIDDEN;
 void *get_user_handle_ptr( HANDLE handle, unsigned int type ) DECLSPEC_HIDDEN;
 void release_user_handle_ptr( void *ptr ) DECLSPEC_HIDDEN;
+void *next_process_user_handle_ptr( HANDLE *handle, unsigned int type ) DECLSPEC_HIDDEN;
 UINT win_set_flags( HWND hwnd, UINT set_mask, UINT clear_mask ) DECLSPEC_HIDDEN;
 
 static inline UINT win_get_flags( HWND hwnd )
diff --git a/dlls/win32u/window.c b/dlls/win32u/window.c
index 4db9d99884c..8e7f434833c 100644
--- a/dlls/win32u/window.c
+++ b/dlls/win32u/window.c
@@ -101,6 +101,26 @@ void *get_user_handle_ptr( HANDLE handle, unsigned int type )
     return ptr;
 }
 
+/***********************************************************************
+ *           next_process_user_handle_ptr
+ *
+ * user_lock must be held by caller.
+ */
+void *next_process_user_handle_ptr( HANDLE *handle, unsigned int type )
+{
+    struct user_object *ptr;
+    WORD index = *handle ? USER_HANDLE_TO_INDEX( *handle ) + 1 : 0;
+
+    while (index < NB_USER_HANDLES)
+    {
+        if (!(ptr = user_handles[index++])) continue;  /* OBJ_OTHER_PROCESS */
+        if (ptr->type != type) continue;
+        *handle = ptr->handle;
+        return ptr;
+    }
+    return NULL;
+}
+
 /***********************************************************************
  *           set_user_handle_ptr
  */
@@ -142,27 +162,6 @@ void *free_user_handle( HANDLE handle, unsigned int type )
     return ptr;
 }
 
-/***********************************************************************
- *           next_thread_window
- */
-static WND *next_thread_window_ptr( HWND *hwnd )
-{
-    struct user_object *ptr;
-    WND *win;
-    WORD index = *hwnd ? USER_HANDLE_TO_INDEX( *hwnd ) + 1 : 0;
-
-    while (index < NB_USER_HANDLES)
-    {
-        if (!(ptr = user_handles[index++])) continue;
-        if (ptr->type != NTUSER_OBJ_WINDOW) continue;
-        win = (WND *)ptr;
-        if (win->tid != GetCurrentThreadId()) continue;
-        *hwnd = ptr->handle;
-        return win;
-    }
-    return NULL;
-}
-
 /*******************************************************************
  *           get_hwnd_message_parent
  *
@@ -4846,13 +4845,14 @@ BOOL WINAPI NtUserDestroyWindow( HWND hwnd )
 void destroy_thread_windows(void)
 {
     WND *win, *free_list = NULL;
-    HWND hwnd = 0;
+    HANDLE handle = 0;
 
     user_lock();
-    while ((win = next_thread_window_ptr( &hwnd )))
+    while ((win = next_process_user_handle_ptr( &handle, NTUSER_OBJ_WINDOW )))
     {
+        if (win->tid != GetCurrentThreadId()) continue;
         free_dce( win->dce, win->obj.handle );
-        set_user_handle_ptr( hwnd, NULL );
+        set_user_handle_ptr( handle, NULL );
         win->obj.handle = free_list;
         free_list = win;
     }