Francois Gouget : winetest/dissect: Remove some pointless sprintfs.
Module: tools Branch: master Commit: 91fa8fe2d6d989eee5960fbd9133449d5ee7a0d9 URL: http://source.winehq.org/git/tools.git/?a=commit;h=91fa8fe2d6d989eee5960fbd9... Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Mar 23 13:02:14 2017 +0100 winetest/dissect: Remove some pointless sprintfs. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- winetest/dissect | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/winetest/dissect b/winetest/dissect index c6b4b71..d8fc7cf 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -130,9 +130,9 @@ $_ = <IN>; my $box = create_box( "version", "version", "Version information for $tag" ); $box->{data} .= "<h2>Build version</h2>\n"; $box->{data} .= "<table class=\"output\">\n"; -$box->{data} .= sprintf "<tr><td>Build</td><td><a title=\"%s\" href=\"$gitweb/?a=shortlog;h=%s\">%s</a></td></tr>\n", $testbuild, $testbuild, $shortbuild; +$box->{data} .= "<tr><td>Build</td><td><a title=\"$testbuild\" href=\"$gitweb/?a=shortlog;h=$testbuild\">$shortbuild</a></td></tr>\n"; $box->{data} .= "<tr><td>Tag</td><td><a title=\"Full report\" href=\"report.html\">$tag</a></td></tr></table>\n"; -$box->{data} .= sprintf "<div class=\"output\"> </div>\n"; +$box->{data} .= "<div class=\"output\"> </div>\n"; while (($_ = <IN>) =~ s/^ //) { chomp; @@ -301,7 +301,7 @@ while (<IN>) { } if ($3 eq "skipped") { - $testbox->{data} .= sprintf "<div class=\"test result skipped\">Skipped by user request.</div>\n"; + $testbox->{data} .= "<div class=\"test result skipped\">Skipped by user request.</div>\n"; print SUM "- $dll $unit skipped - - - $source $rev\n"; $dll = undef; mydie "too many tests skipped by user request\n" if ++$user_skips > $maxuserskips; @@ -428,7 +428,7 @@ for (my $i = 0; $i <= $#boxes; $i++) printf REPORT "<div class=\"updownbar\"><table><tr><td width=\"100%%\">%s</td>\n", $boxes[$i]->{title}; printf REPORT "<td class=\"arrow\"><a href=\"#%s\">↑</a></td>\n", $boxes[$i]->{prev} if defined $boxes[$i]->{prev}; printf REPORT "<td class=\"arrow\"><a href=\"#%s\">↓</a></td>\n", $boxes[$i]->{next} if defined $boxes[$i]->{next}; - printf REPORT "</tr></table></div>\n"; + print REPORT "</tr></table></div>\n"; print REPORT $boxes[$i]->{data}, "</div>\n"; } print REPORT end_html();
participants (1)
-
Alexandre Julliard