Francois Gouget : user32/tests: Use wine_dbgstr_an() to trace malformed Unicode strings.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 47d492742477e5d0e94b2efda91ef7b405d34300
URL:    https://gitlab.winehq.org/wine/wine/-/commit/47d492742477e5d0e94b2efda91ef7b...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Wed Dec 21 16:11:31 2022 +0100

user32/tests: Use wine_dbgstr_an() to trace malformed Unicode strings.

Using wine_dbgstr_wn() causes out-of-bounds memory accesses when given
Unicode strings with odd sizes, most obviously 1 byte strings.
Also trace the expected Ansi string for round-trip tests.

---

 dlls/user32/tests/clipboard.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/user32/tests/clipboard.c b/dlls/user32/tests/clipboard.c
index 7414af996fb..09f01b7481a 100644
--- a/dlls/user32/tests/clipboard.c
+++ b/dlls/user32/tests/clipboard.c
@@ -2269,7 +2269,7 @@ static void test_string_data(void)
             memcpy( bufferW, test_data[i].strW, test_data[i].len );
             bufferW[(test_data[i].len + 1) / sizeof(WCHAR) - 1] = 0;
             ok( !memcmp( data, bufferW, test_data[i].len ),
-                "wrong data %s\n", wine_dbgstr_wn( data, (test_data[i].len + 1) / sizeof(WCHAR) ));
+                "wrong data %s\n", wine_dbgstr_an( data, test_data[i].len ));
         }
         r = CloseClipboard();
         ok( r, "gle %ld\n", GetLastError() );
@@ -2314,8 +2314,7 @@ static void test_string_data_process( int i )
         ok( len == test_data[i].len, "wrong size %u / %u\n", len, test_data[i].len );
         memcpy( bufferW, test_data[i].strW, test_data[i].len );
         bufferW[(test_data[i].len + 1) / sizeof(WCHAR) - 1] = 0;
-        ok( !memcmp( data, bufferW, len ),
-            "wrong data %s\n", wine_dbgstr_wn( data, (len + 1) / sizeof(WCHAR) ));
+        ok( !memcmp( data, bufferW, len ), "wrong data %s\n", wine_dbgstr_an( data, len ));
         data = GetClipboardData( CF_TEXT );
         if (test_data[i].len >= sizeof(WCHAR))
         {
@@ -2325,7 +2324,8 @@ static void test_string_data_process( int i )
                                         bufferA, ARRAY_SIZE(bufferA), NULL, NULL );
             bufferA[len2 - 1] = 0;
             ok( len == len2, "wrong size %u / %u\n", len, len2 );
-            ok( !memcmp( data, bufferA, len ), "wrong data %.*s\n", len, (char *)data );
+            ok( !memcmp( data, bufferA, len ), "wrong data %s, expected %s\n",
+                wine_dbgstr_an( data, len ), wine_dbgstr_an( bufferA, len2 ));
         }
         else
         {