Henri Verbeet : wined3d: Reject blits between depth/stencil and colour attachments in the FBO blitter.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 850f465c67994f2f54101eeff991ace5d6cb8fd2
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=850f465c67994f2f54101eeff...

Author: Henri Verbeet <hverbeet(a)codeweavers.com>
Date:   Thu May  6 16:59:19 2021 +0200

wined3d: Reject blits between depth/stencil and colour attachments in the FBO blitter.

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/wined3d/texture.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c
index 24ff5874841..2caad29d369 100644
--- a/dlls/wined3d/texture.c
+++ b/dlls/wined3d/texture.c
@@ -269,6 +269,7 @@ static bool fbo_blitter_supported(enum wined3d_blit_op blit_op, const struct win
 {
     const struct wined3d_format *src_format = src_resource->format;
     const struct wined3d_format *dst_format = dst_resource->format;
+    bool src_ds, dst_ds;
 
     if ((wined3d_settings.offscreen_rendering_mode != ORM_FBO) || !gl_info->fbo_ops.glBlitFramebuffer)
         return false;
@@ -280,6 +281,16 @@ static bool fbo_blitter_supported(enum wined3d_blit_op blit_op, const struct win
     if (src_resource->type != WINED3D_RTYPE_TEXTURE_2D)
         return false;
 
+    /* We can't copy between depth/stencil and colour attachments. One notable
+     * way we can end up here is when copying between typeless resources with
+     * formats like R16_TYPELESS, which can end up using either a
+     * depth/stencil or a colour format on the OpenGL side, depending on the
+     * resource's bind flags. */
+    src_ds = src_format->depth_size || src_format->stencil_size;
+    dst_ds = dst_format->depth_size || dst_format->stencil_size;
+    if (src_ds != dst_ds)
+        return false;
+
     switch (blit_op)
     {
         case WINED3D_BLIT_OP_COLOR_BLIT: