Hans Leidekker : msi: Avoid a double free.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: b817fb1aaa3ede132dff5932ba97e430558299cc
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=b817fb1aaa3ede132dff5932ba...

Author: Hans Leidekker <hans(a)codeweavers.com>
Date:   Fri May 20 12:32:57 2011 +0200

msi: Avoid a double free.

---

 dlls/msi/media.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/dlls/msi/media.c b/dlls/msi/media.c
index 608e84c..9de2566 100644
--- a/dlls/msi/media.c
+++ b/dlls/msi/media.c
@@ -238,10 +238,10 @@ static INT_PTR CDECL cabinet_open_stream( char *pszFile, int oflag, int pmode )
     if (msi_clone_open_stream( package_disk.package->db, cab->storage, encoded, &stream ) != ERROR_SUCCESS)
     {
         hr = IStorage_OpenStream( cab->storage, encoded, NULL, STGM_READ|STGM_SHARE_EXCLUSIVE, 0, &stream );
-        msi_free( encoded );
         if (FAILED(hr))
         {
             WARN("failed to open stream 0x%08x\n", hr);
+            msi_free( encoded );
             return 0;
         }
     }