Zebediah Figura : vkd3d-shader/hlsl: Use hlsl_new_synthetic_var() in hlsl_new_func_decl().

[Alexandre Julliard]

Module: vkd3d
Branch: master
Commit: da56f41cebb2a8476bde085670c306d6e1fa10aa
URL:    https://gitlab.winehq.org/wine/vkd3d/-/commit/da56f41cebb2a8476bde085670c306...

Author: Zebediah Figura <zfigura(a)codeweavers.com>
Date:   Sun Oct 30 17:46:38 2022 -0500

vkd3d-shader/hlsl: Use hlsl_new_synthetic_var() in hlsl_new_func_decl().

---

 libs/vkd3d-shader/hlsl.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c
index 3f80fcf2..11cb2e7e 100644
--- a/libs/vkd3d-shader/hlsl.c
+++ b/libs/vkd3d-shader/hlsl.c
@@ -1193,17 +1193,12 @@ struct hlsl_ir_function_decl *hlsl_new_func_decl(struct hlsl_ctx *ctx, struct hl
 
     if (!hlsl_types_are_equal(return_type, ctx->builtin_types.Void))
     {
-        struct hlsl_ir_var *return_var;
-        char name[28];
-
-        sprintf(name, "<retval-%p>", decl);
-        if (!(return_var = hlsl_new_var(ctx, hlsl_strdup(ctx, name), return_type, loc, semantic, 0, NULL)))
+        if (!(decl->return_var = hlsl_new_synthetic_var(ctx, "retval", return_type, &loc)))
         {
             vkd3d_free(decl);
             return NULL;
         }
-        list_add_tail(&ctx->globals->vars, &return_var->scope_entry);
-        decl->return_var = return_var;
+        decl->return_var->semantic = *semantic;
     }
 
     return decl;