Juan Lang : crypt32: Remove a test because of a Windows 2003 SP1 bug.
Module: wine Branch: master Commit: 8240395073cc44c4d698e4037ebb14731a0450b4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8240395073cc44c4d698e4037e... Author: Juan Lang <juan.lang(a)gmail.com> Date: Thu Oct 25 09:05:38 2007 -0700 crypt32: Remove a test because of a Windows 2003 SP1 bug. --- dlls/crypt32/tests/cert.c | 14 ++++---------- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/dlls/crypt32/tests/cert.c b/dlls/crypt32/tests/cert.c index 3c6aaa4..14549eb 100644 --- a/dlls/crypt32/tests/cert.c +++ b/dlls/crypt32/tests/cert.c @@ -1374,17 +1374,11 @@ static void testGetIssuerCert(void) flags); if (parent) CertFreeCertificateContext(parent); - /* Now check just the time */ - flags = CERT_STORE_TIME_VALIDITY_FLAG; - parent = CertGetIssuerCertificateFromStore(store, child, NULL, &flags); - ok(parent != NULL, "CertGetIssuerCertificateFromStore failed: %08x\n", - GetLastError()); - /* Oops: the child is not expired, so the time validity check actually - * succeeds, even though the signing cert is expired. + /* Checking time validity is not productive, because while most Windows + * versions return 0 (time valid) because the child is not expired, + * Windows 2003 SP1 returns that it is expired. Thus the range of + * possibilities is covered, and a test verifies nothing. */ - ok(!flags, "Expected check to succeed, got %08x\n", flags); - if (parent) - CertFreeCertificateContext(parent); CertFreeCertificateContext(child); CertCloseStore(store, 0);
participants (1)
-
Alexandre Julliard