Jinoh Kang : combase: Compare AddRef() return value against 1 instead of 0 in find_proxy_manager.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: f55f0b834292eff17b232cf293372a0de80b14f7
URL:    https://gitlab.winehq.org/wine/wine/-/commit/f55f0b834292eff17b232cf293372a0...

Author: Jinoh Kang <jinoh.kang.kr(a)gmail.com>
Date:   Wed May 17 23:30:16 2023 +0900

combase: Compare AddRef() return value against 1 instead of 0 in find_proxy_manager.

Today, find_proxy_manager() tests if AddRef() returns 0 in an attempt to
protect against a race condition bug.

Note that AddRef does not return zero in normal circumstances, since
AddRef returns the reference count after the increment, not before.

Fix this by comparing the return value of AddRef() against 1, not 0.

---

 dlls/combase/marshal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/combase/marshal.c b/dlls/combase/marshal.c
index a3da851b139..360c2c3e987 100644
--- a/dlls/combase/marshal.c
+++ b/dlls/combase/marshal.c
@@ -1949,7 +1949,7 @@ static BOOL find_proxy_manager(struct apartment * apt, OXID oxid, OID oid, struc
             /* be careful of a race with ClientIdentity_Release, which would
              * cause us to return a proxy which is in the process of being
              * destroyed */
-            if (IMultiQI_AddRef(&proxy->IMultiQI_iface) != 0)
+            if (IMultiQI_AddRef(&proxy->IMultiQI_iface) != 1)
             {
                 *proxy_found = proxy;
                 found = TRUE;