Nikolay Sivov : msxml3: Silence a warning in ::get_baseName() for document nodes.
Module: wine Branch: master Commit: d24d007fa5ef35abb5a83d9b399645243b242356 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d24d007fa5ef35abb5a83d9b39... Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jun 22 22:47:36 2010 +0400 msxml3: Silence a warning in ::get_baseName() for document nodes. --- dlls/msxml3/node.c | 1 + dlls/msxml3/tests/domdoc.c | 5 +++++ 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c index 31c6e46..135844f 100644 --- a/dlls/msxml3/node.c +++ b/dlls/msxml3/node.c @@ -1632,6 +1632,7 @@ static HRESULT WINAPI xmlnode_get_baseName( break; case XML_TEXT_NODE: case XML_COMMENT_NODE: + case XML_DOCUMENT_NODE: break; default: ERR("Unhandled type %d\n", This->node->type ); diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 605628f..d85e9fb 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -656,6 +656,11 @@ if (0) r = IXMLDOMDocument_get_nodeName( doc, NULL ); ok ( r == E_INVALIDARG, "get_nodeName (NULL) wrong code\n"); + str = (BSTR)0xdeadbeef; + r = IXMLDOMDocument_get_baseName( doc, &str ); + ok ( r == S_FALSE, "got 0x%08x\n", r); + ok (str == NULL, "got %p\n", str); + /* content doesn't matter here */ str = NULL; r = IXMLDOMDocument_get_nodeName( doc, &str );
participants (1)
-
Alexandre Julliard