Rob Shearman : wintrust: Add explicit "!= NO_ERROR" to expressions that use variables containing error codes as booleans.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 19e9b665c6570c36dc5e7517e19aa0c0a45b9c35
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=19e9b665c6570c36dc5e7517e1...

Author: Rob Shearman <robertshearman(a)gmail.com>
Date:   Fri Sep 12 13:01:20 2008 +0100

wintrust: Add explicit "!= NO_ERROR" to expressions that use variables containing error codes as booleans.

---

 dlls/wintrust/softpub.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/dlls/wintrust/softpub.c b/dlls/wintrust/softpub.c
index c2eb1eb..f8bf69e 100644
--- a/dlls/wintrust/softpub.c
+++ b/dlls/wintrust/softpub.c
@@ -849,14 +849,14 @@ HRESULT WINAPI GenericChainFinalProv(CRYPT_PROVIDER_DATA *data)
             else
                 err = ERROR_OUTOFMEMORY;
         }
-        if (!err)
+        if (err == NO_ERROR)
             err = policyCallback(data, TRUSTERROR_STEP_FINAL_POLICYPROV,
              data->dwRegPolicySettings, data->csSigners, signers, policyArg);
         data->psPfns->pfnFree(signers);
     }
-    if (err)
+    if (err != NO_ERROR)
         data->padwTrustStepErrors[TRUSTERROR_STEP_FINAL_POLICYPROV] = err;
-    TRACE("returning %d (%08x)\n", !err ? S_OK : S_FALSE,
+    TRACE("returning %d (%08x)\n", err == NO_ERROR ? S_OK : S_FALSE,
      data->padwTrustStepErrors[TRUSTERROR_STEP_FINAL_POLICYPROV]);
     return err == NO_ERROR ? S_OK : S_FALSE;
 }