Alex Henrie : uninstaller: Don't overallocate in FetchFromRootKey.
Module: wine Branch: master Commit: 8943fcbca4963ac6740a5c6e13d5fc9b7748cad2 URL: https://gitlab.winehq.org/wine/wine/-/commit/8943fcbca4963ac6740a5c6e13d5fc9... Author: Alex Henrie <alexhenrie24(a)gmail.com> Date: Sat Sep 9 12:06:36 2023 -0600 uninstaller: Don't overallocate in FetchFromRootKey. --- programs/uninstaller/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/programs/uninstaller/main.c b/programs/uninstaller/main.c index 027937ba255..15f63976838 100644 --- a/programs/uninstaller/main.c +++ b/programs/uninstaller/main.c @@ -258,7 +258,7 @@ static int FetchFromRootKey(HKEY root) type == REG_DWORD && value == 1) { command = HeapAlloc(GetProcessHeap(), 0, - (lstrlenW(L"msiexec /x%s") + lstrlenW(subKeyName)) * sizeof(WCHAR)); + sizeof(L"msiexec /x") + wcslen(subKeyName) * sizeof(WCHAR)); wsprintfW(command, L"msiexec /x%s", subKeyName); } else if (!RegQueryValueExW(hkeyApp, L"UninstallString", NULL, NULL, NULL, &uninstlen))
participants (1)
-
Alexandre Julliard