Henri Verbeet : d3d8: Don' t return a pointer to the implementation in IDirect3DCubeTexture8Impl_QueryInterface ().

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 635ab65651484760f9b55fef3dc2049c76e4b14f
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=635ab65651484760f9b55fef3d...

Author: Henri Verbeet <hverbeet(a)codeweavers.com>
Date:   Sun Mar 25 20:56:30 2012 +0200

d3d8: Don't return a pointer to the implementation in IDirect3DCubeTexture8Impl_QueryInterface().

---

 dlls/d3d8/cubetexture.c |   16 ++++++++--------
 1 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/dlls/d3d8/cubetexture.c b/dlls/d3d8/cubetexture.c
index f092f35..c28eeb6 100644
--- a/dlls/d3d8/cubetexture.c
+++ b/dlls/d3d8/cubetexture.c
@@ -31,20 +31,20 @@ static inline IDirect3DCubeTexture8Impl *impl_from_IDirect3DCubeTexture8(IDirect
 static HRESULT WINAPI IDirect3DCubeTexture8Impl_QueryInterface(IDirect3DCubeTexture8 *iface,
         REFIID riid, void **ppobj)
 {
-    IDirect3DCubeTexture8Impl *This = impl_from_IDirect3DCubeTexture8(iface);
-
     TRACE("iface %p, riid %s, object %p.\n", iface, debugstr_guid(riid), ppobj);
 
-    if (IsEqualGUID(riid, &IID_IUnknown)
-        || IsEqualGUID(riid, &IID_IDirect3DResource8)
-        || IsEqualGUID(riid, &IID_IDirect3DBaseTexture8)
-        || IsEqualGUID(riid, &IID_IDirect3DCubeTexture8)) {
+    if (IsEqualGUID(riid, &IID_IDirect3DCubeTexture8)
+            || IsEqualGUID(riid, &IID_IDirect3DBaseTexture8)
+            || IsEqualGUID(riid, &IID_IDirect3DResource8)
+            || IsEqualGUID(riid, &IID_IUnknown))
+    {
         IUnknown_AddRef(iface);
-        *ppobj = This;
+        *ppobj = iface;
         return S_OK;
     }
 
-    WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj);
+    WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(riid));
+
     *ppobj = NULL;
     return E_NOINTERFACE;
 }