Alexandre Julliard : server: Avoid a potential server crash when a thread dies on startup.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 3557b9818cccb0c5ceab8bb52d5780208163b771
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=3557b9818cccb0c5ceab8bb52d...

Author: Alexandre Julliard <julliard(a)winehq.org>
Date:   Mon Aug 23 19:50:23 2010 +0200

server: Avoid a potential server crash when a thread dies on startup.

---

 server/thread.c |   28 +++++++++++++++-------------
 1 files changed, 15 insertions(+), 13 deletions(-)

diff --git a/server/thread.c b/server/thread.c
index 67ef6cf..a1d2d4b 100644
--- a/server/thread.c
+++ b/server/thread.c
@@ -1102,8 +1102,18 @@ DECL_HANDLER(init_thread)
 {
     unsigned int prefix_cpu_mask = get_prefix_cpu_mask();
     struct process *process = current->process;
-    int reply_fd = thread_get_inflight_fd( current, req->reply_fd );
-    int wait_fd = thread_get_inflight_fd( current, req->wait_fd );
+    int wait_fd, reply_fd;
+
+    if ((reply_fd = thread_get_inflight_fd( current, req->reply_fd )) == -1)
+    {
+        set_error( STATUS_TOO_MANY_OPENED_FILES );
+        return;
+    }
+    if ((wait_fd = thread_get_inflight_fd( current, req->wait_fd )) == -1)
+    {
+        set_error( STATUS_TOO_MANY_OPENED_FILES );
+        goto error;
+    }
 
     if (current->reply_fd)  /* already initialised */
     {
@@ -1111,19 +1121,11 @@ DECL_HANDLER(init_thread)
         goto error;
     }
 
-    if (reply_fd == -1 || fcntl( reply_fd, F_SETFL, O_NONBLOCK ) == -1) goto error;
+    if (fcntl( reply_fd, F_SETFL, O_NONBLOCK ) == -1) goto error;
 
     current->reply_fd = create_anonymous_fd( &thread_fd_ops, reply_fd, ¤t->obj, 0 );
-    reply_fd = -1;
-    if (!current->reply_fd) goto error;
-
-    if (wait_fd == -1)
-    {
-        set_error( STATUS_TOO_MANY_OPENED_FILES );  /* most likely reason */
-        return;
-    }
-    if (!(current->wait_fd  = create_anonymous_fd( &thread_fd_ops, wait_fd, ¤t->obj, 0 )))
-        return;
+    current->wait_fd  = create_anonymous_fd( &thread_fd_ops, wait_fd, ¤t->obj, 0 );
+    if (!current->reply_fd || !current->wait_fd) return;
 
     if (!is_valid_address(req->teb))
     {