Gabriel Ivăncescu : mshtml: Don't NULL out the doc's window when unlinking the window.
Module: wine Branch: master Commit: 1b3c6c39c73bef94f42c537d8177d73ddf7fc1c7 URL: https://gitlab.winehq.org/wine/wine/-/commit/1b3c6c39c73bef94f42c537d8177d73... Author: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> Date: Fri Nov 10 17:43:29 2023 +0200 mshtml: Don't NULL out the doc's window when unlinking the window. This would cause a leak since we have a cyclic ref now. Signed-off-by: Gabriel Ivăncescu <gabrielopcode(a)gmail.com> --- dlls/mshtml/htmlwindow.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index fc17635542d..11c7c6d892d 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -3969,7 +3969,6 @@ static void HTMLWindow_unlink(DispatchEx *dispex) if(This->doc) { HTMLDocumentNode *doc = This->doc; - This->doc->window = NULL; This->doc = NULL; IHTMLDOMNode_Release(&doc->node.IHTMLDOMNode_iface); }
participants (1)
-
Alexandre Julliard