Michael Stefaniuc : quartz: Remove an always true conditional subexpression (PVS-Studio).
Module: wine Branch: master Commit: 2e54309f39821f88eca80ad79068cc3df135af60 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2e54309f39821f88eca80ad790... Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Feb 18 00:11:40 2015 +0100 quartz: Remove an always true conditional subexpression (PVS-Studio). --- dlls/quartz/pin.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/quartz/pin.c b/dlls/quartz/pin.c index 78b6fa2..8377be5 100644 --- a/dlls/quartz/pin.c +++ b/dlls/quartz/pin.c @@ -268,7 +268,7 @@ HRESULT WINAPI PullPin_ReceiveConnection(IPin * iface, IPin * pReceivePin, const props.cbAlign = 1; props.cbPrefix = 0; - if (SUCCEEDED(hr) && (This->fnQueryAccept(This->pUserData, pmt) != S_OK)) + if (This->fnQueryAccept(This->pUserData, pmt) != S_OK) hr = VFW_E_TYPE_NOT_ACCEPTED; /* FIXME: shouldn't we just map common errors onto * VFW_E_TYPE_NOT_ACCEPTED and pass the value on otherwise? */
participants (1)
-
Alexandre Julliard