Marcus Meissner : winhttp: Avoid leaking authinfo on error (Coverity).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 0fe44e1be6f20e4f64a70c68b4f3252e031aa62c
URL:    http://source.winehq.org/git/wine.git/?a=commit;h=0fe44e1be6f20e4f64a70c68b4...

Author: Marcus Meissner <marcus(a)jet.franken.de>
Date:   Thu Apr 17 08:43:14 2014 +0200

winhttp: Avoid leaking authinfo on error (Coverity).

---

 dlls/winhttp/request.c |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c
index ed3430a..374051a 100644
--- a/dlls/winhttp/request.c
+++ b/dlls/winhttp/request.c
@@ -1628,7 +1628,11 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla
         {
             int len = strlenW( ++p );
             in.cbBuffer = decode_base64( p, len, NULL );
-            if (!(in.pvBuffer = heap_alloc( in.cbBuffer ))) return FALSE;
+            if (!(in.pvBuffer = heap_alloc( in.cbBuffer ))) {
+                destroy_authinfo( authinfo );
+                *auth_ptr = NULL;
+                return FALSE;
+            }
             decode_base64( p, len, in.pvBuffer );
         }
         out.BufferType = SECBUFFER_TOKEN;
@@ -1636,6 +1640,8 @@ static BOOL do_authorization( request_t *request, DWORD target, DWORD scheme_fla
         if (!(out.pvBuffer = heap_alloc( authinfo->max_token )))
         {
             heap_free( in.pvBuffer );
+            destroy_authinfo( authinfo );
+            *auth_ptr = NULL;
             return FALSE;
         }
         out_desc.ulVersion = 0;