Francois Gouget : testbot: Fix the type of inherited auto-increment columns.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 0833f114a3db28343f89a03b27748ff2d9306ac9
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=0833f114a3db28343f89a03b...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Mon May 30 18:44:40 2022 +0200

testbot: Fix the type of inherited auto-increment columns.

Some objects, such as jobs, use a database-generated auto-increment
integer as their primary key. However objects that 'inherit' such
primary keys, such as Steps, do not. So the corresponding property
descriptor should be a regular integer. Otherwise the DBIBackend will
try to fetch a unique id that does not exist.
Fortunately this issue has so far been masked by the 'master columns'
mechanism.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 testbot/lib/WineTestBot/Records.pm | 2 +-
 testbot/lib/WineTestBot/Steps.pm   | 2 +-
 testbot/lib/WineTestBot/Tasks.pm   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/lib/WineTestBot/Records.pm b/testbot/lib/WineTestBot/Records.pm
index fd8e574..6002d1c 100644
--- a/testbot/lib/WineTestBot/Records.pm
+++ b/testbot/lib/WineTestBot/Records.pm
@@ -83,7 +83,7 @@ my @PropertyDescriptors = (
   CreateBasicPropertyDescriptor("Value", "Value", !1, !1, "A", 64),
 );
 my @FlatPropertyDescriptors = (
-  CreateBasicPropertyDescriptor("RecordGroupId", "Group id", 1, 1, "S", 10),
+  CreateBasicPropertyDescriptor("RecordGroupId", "Group id", 1, 1, "N", 10),
   @PropertyDescriptors
 );
 
diff --git a/testbot/lib/WineTestBot/Steps.pm b/testbot/lib/WineTestBot/Steps.pm
index 0f65d63..860dc49 100644
--- a/testbot/lib/WineTestBot/Steps.pm
+++ b/testbot/lib/WineTestBot/Steps.pm
@@ -247,7 +247,7 @@ my @PropertyDescriptors = (
 );
 SetDetailrefKeyPrefix("Step", @PropertyDescriptors);
 my @FlatPropertyDescriptors = (
-  CreateBasicPropertyDescriptor("JobId", "Job id", 1, 1, "S", 10),
+  CreateBasicPropertyDescriptor("JobId", "Job id", 1, 1, "N", 10),
   @PropertyDescriptors
 );
 
diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm
index 5cc2cc6..50ce960 100644
--- a/testbot/lib/WineTestBot/Tasks.pm
+++ b/testbot/lib/WineTestBot/Tasks.pm
@@ -368,7 +368,7 @@ my @PropertyDescriptors = (
   CreateBasicPropertyDescriptor("TestFailures", "Failures", !1, !1, "N", 6),
 );
 my @FlatPropertyDescriptors = (
-  CreateBasicPropertyDescriptor("JobId", "Job id", 1, 1, "S", 10),
+  CreateBasicPropertyDescriptor("JobId", "Job id", 1, 1, "N", 10),
   CreateBasicPropertyDescriptor("StepNo", "Step no",  1,  1, "N", 2),
   @PropertyDescriptors
 );