Rémi Bernon : win32u: Close device manager source key in write_source_to_registry.

[Alexandre Julliard]

Module: wine
Branch: master
Commit: df1c70ee35de94b95bfe509bf8b89a9425238bef
URL:    https://gitlab.winehq.org/wine/wine/-/commit/df1c70ee35de94b95bfe509bf8b89a9...

Author: Rémi Bernon <rbernon(a)codeweavers.com>
Date:   Thu Apr 11 14:04:58 2024 +0200

win32u: Close device manager source key in write_source_to_registry.

---

 dlls/win32u/sysparams.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/dlls/win32u/sysparams.c b/dlls/win32u/sysparams.c
index b0b9a5cc907..916b84abbba 100644
--- a/dlls/win32u/sysparams.c
+++ b/dlls/win32u/sysparams.c
@@ -1280,6 +1280,7 @@ static BOOL write_source_to_registry( const struct source *source, HKEY *source_
     NtClose( hkey );
 
     /* Following information is Wine specific, it doesn't really exist on Windows. */
+    if (*source_key) NtClose( *source_key );
     *source_key = reg_create_ascii_key( NULL, source->path, REG_OPTION_VOLATILE, NULL );
     set_reg_ascii_value( *source_key, "GPUID", gpu->path );
     set_reg_value( *source_key, state_flagsW, REG_DWORD, &source->state_flags,
@@ -1302,12 +1303,6 @@ static void add_source( const char *name, UINT state_flags, void *param )
 
     TRACE( "name %s, state_flags %#x\n", name, state_flags );
 
-    if (ctx->source_key)
-    {
-        NtClose( ctx->source_key );
-        ctx->source_key = NULL;
-    }
-
     memset( &ctx->source, 0, sizeof(ctx->source) );
     ctx->source.gpu = &ctx->gpu;
     ctx->source.id = ctx->source_count;