Nikolay Sivov : mfplay: Fix a leak on error path in synchronous CreateMediaItemFromURL() (Coverity).
Module: wine Branch: master Commit: 5512eceada778e8502af65408c4fbdfd4755e3fa URL: https://source.winehq.org/git/wine.git/?a=commit;h=5512eceada778e8502af65408... Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Apr 13 09:03:33 2021 +0300 mfplay: Fix a leak on error path in synchronous CreateMediaItemFromURL() (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mfplay/player.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/mfplay/player.c b/dlls/mfplay/player.c index e061e21acb8..a95e1d3ca36 100644 --- a/dlls/mfplay/player.c +++ b/dlls/mfplay/player.c @@ -835,7 +835,12 @@ static HRESULT media_player_create_item_from_url(struct media_player *player, } if (SUCCEEDED(hr)) + { *ret = &item->IMFPMediaItem_iface; + IMFPMediaItem_AddRef(*ret); + } + + IMFPMediaItem_Release(&item->IMFPMediaItem_iface); return hr; }
participants (1)
-
Alexandre Julliard