Michael Stefaniuc : oleaut32: Remove an always true if-subcondition ( PVS-Studio).
Module: wine Branch: master Commit: 45839dccee543f8dbb28ac8f93e2cc921efa12ba URL: http://source.winehq.org/git/wine.git/?a=commit;h=45839dccee543f8dbb28ac8f93... Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Thu Oct 29 10:37:50 2015 +0100 oleaut32: Remove an always true if-subcondition (PVS-Studio). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oleaut32/variant.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/oleaut32/variant.c b/dlls/oleaut32/variant.c index 8ca9cf9..b31e8bc 100644 --- a/dlls/oleaut32/variant.c +++ b/dlls/oleaut32/variant.c @@ -3606,7 +3606,7 @@ HRESULT WINAPI VarDiv(LPVARIANT left, LPVARIANT right, LPVARIANT result) } /* Determine return type */ - if (!(rightvt == VT_EMPTY)) + if (rightvt != VT_EMPTY) { if (leftvt == VT_NULL || rightvt == VT_NULL) { @@ -3639,7 +3639,7 @@ HRESULT WINAPI VarDiv(LPVARIANT left, LPVARIANT right, LPVARIANT result) else if (leftvt == VT_R4 || rightvt == VT_R4) resvt = VT_R4; } - else if (leftvt == VT_NULL && rightvt == VT_EMPTY) + else if (leftvt == VT_NULL) { V_VT(result) = VT_NULL; hres = S_OK;
participants (1)
-
Alexandre Julliard