Zebediah Figura : kernel32: Reimplement CreateHardLink() on top of NtSetInformationFile(FileLinkInformation).

[Alexandre Julliard]

Module: wine
Branch: master
Commit: 4e98b0810bb0fcaf5e3acae0f4eccf38710de9b2
URL:    https://source.winehq.org/git/wine.git/?a=commit;h=4e98b0810bb0fcaf5e3acae0f...

Author: Zebediah Figura <z.figura12(a)gmail.com>
Date:   Tue Mar  3 23:20:37 2020 -0600

kernel32: Reimplement CreateHardLink() on top of NtSetInformationFile(FileLinkInformation).

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 dlls/kernel32/path.c | 46 +++++++++++++++++++++-------------------------
 1 file changed, 21 insertions(+), 25 deletions(-)

diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c
index c50b631d7c..617b14a717 100644
--- a/dlls/kernel32/path.c
+++ b/dlls/kernel32/path.c
@@ -663,10 +663,13 @@ BOOL WINAPI MoveFileA( LPCSTR source, LPCSTR dest )
 BOOL WINAPI CreateHardLinkW(LPCWSTR lpFileName, LPCWSTR lpExistingFileName,
     LPSECURITY_ATTRIBUTES lpSecurityAttributes)
 {
-    NTSTATUS status;
     UNICODE_STRING ntDest, ntSource;
-    ANSI_STRING unixDest, unixSource;
+    FILE_LINK_INFORMATION *info = NULL;
+    OBJECT_ATTRIBUTES attr;
+    IO_STATUS_BLOCK io;
     BOOL ret = FALSE;
+    HANDLE file;
+    ULONG size;
 
     TRACE("(%s, %s, %p)\n", debugstr_w(lpFileName),
         debugstr_w(lpExistingFileName), lpSecurityAttributes);
@@ -679,37 +682,30 @@ BOOL WINAPI CreateHardLinkW(LPCWSTR lpFileName, LPCWSTR lpExistingFileName,
         goto err;
     }
 
-    unixSource.Buffer = unixDest.Buffer = NULL;
-    status = wine_nt_to_unix_file_name( &ntSource, &unixSource, FILE_OPEN, FALSE );
-    if (!status)
+    size = offsetof( FILE_LINK_INFORMATION, FileName ) + ntDest.Length;
+    if (!(info = HeapAlloc( GetProcessHeap(), 0, size )))
     {
-        status = wine_nt_to_unix_file_name( &ntDest, &unixDest, FILE_CREATE, FALSE );
-        if (!status) /* destination must not exist */
-        {
-            status = STATUS_OBJECT_NAME_EXISTS;
-        } else if (status == STATUS_NO_SUCH_FILE)
-        {
-            status = STATUS_SUCCESS;
-        }
+        SetLastError( ERROR_OUTOFMEMORY );
+        goto err;
     }
 
-    if (status)
-         SetLastError( RtlNtStatusToDosError(status) );
-    else if (!link( unixSource.Buffer, unixDest.Buffer ))
-    {
-        TRACE("Hardlinked '%s' to '%s'\n", debugstr_a( unixDest.Buffer ),
-                debugstr_a( unixSource.Buffer ));
-        ret = TRUE;
-    }
-    else
-        FILE_SetDosError();
+    InitializeObjectAttributes( &attr, &ntSource, OBJ_CASE_INSENSITIVE, 0, NULL );
+    if (!(ret = set_ntstatus( NtOpenFile( &file, SYNCHRONIZE, &attr, &io, FILE_SHARE_READ | FILE_SHARE_WRITE,
+            FILE_SYNCHRONOUS_IO_NONALERT ) )))
+        goto err;
+
+    info->ReplaceIfExists = FALSE;
+    info->RootDirectory = NULL;
+    info->FileNameLength = ntDest.Length;
+    memcpy( info->FileName, ntDest.Buffer, ntDest.Length );
+    ret = set_ntstatus( NtSetInformationFile( file, &io, info, size, FileLinkInformation ) );
 
-    RtlFreeAnsiString( &unixSource );
-    RtlFreeAnsiString( &unixDest );
+    NtClose( file );
 
 err:
     RtlFreeUnicodeString( &ntSource );
     RtlFreeUnicodeString( &ntDest );
+    HeapFree( GetProcessHeap(), 0, info );
     return ret;
 }