Francois Gouget : testbot/web: Simplify generating the Submit page header.

[Alexandre Julliard]

Module: tools
Branch: master
Commit: 2752cda32ea515e5a7cac60ef342961394b25170
URL:    https://source.winehq.org/git/tools.git/?a=commit;h=2752cda32ea515e5a7cac60e...

Author: Francois Gouget <fgouget(a)codeweavers.com>
Date:   Fri Apr 22 00:03:21 2022 +0200

testbot/web: Simplify generating the Submit page header.

This takes advantage of the fact that all of the @Headers parts are
joined with linebreaks.

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard(a)winehq.org>

---

 testbot/web/Submit.pl | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 9292d38..ca225b6 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -620,14 +620,13 @@ sub GetHeaderText($)
   }
   if ($self->{Page} == 2 or $self->{Page} == 4)
   {
-    my $HeaderText = "Select the VMs on which you want to run your test.";
+    push @Headers, "Select the VMs on which you want to run your test.";
     my $VMs = CreateVMs();
     $VMs->AddFilter("Status", ["offline", "maintenance"]);
     if (!$VMs->IsEmpty())
     {
-      $HeaderText .= "<br>NOTE: Offline VMs and those undergoing maintenance will not be able to run your tests right away.";
+      push @Headers, "NOTE: Offline VMs and those undergoing maintenance will not be able to run your tests right away.";
     }
-    push @Headers, $HeaderText;
   }
   if (($self->{Page} == 3 or $self->{Page} == 0) and $self->{Impacts})
   {
@@ -652,7 +651,7 @@ sub GetHeaderText($)
       }
       push @TestExecutables, "$ModuleName: ". join(" ", @TestUnits) if (@TestUnits);
     }
-    push @Headers, join("<br>\n", "Here is a list of the test executables impacted by the patch (patched test units, if any, are in italics).", @TestExecutables);
+    push @Headers, "Here is a list of the test executables impacted by the patch (patched test units, if any, are in italics).", @TestExecutables;
   }
 
   return join("<br>\n", @Headers);