Alexandru Băluț : Changed the main page to use a single image instead of 10 images for the rounded icons (try 2)

[Jeremy Newman]

Module: website
Branch: master
Commit: 6a73a1c06a46231b151b654f41c94c0ec18b183d
URL:    http://source.winehq.org/git/website.git/?a=commit;h=6a73a1c06a46231b151b654...

Author: Alexandru Băluț <alexandru.balut(a)gmail.com>
Date:   Sat Jun 12 01:40:45 2010 +0200

Changed the main page to use a single image instead of 10 images for the rounded icons (try 2)

--0016367d6d4e2cc6fe0488c9ac0f
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

The previous patch is incomplete. I attached the patch with the
home.template file for de, es, fr, and pl changed accordingly. Please have =
a
look.

Thanks,
Alex

On Fri, Jun 11, 2010 at 17:51, Alexandru B=C4=83lu=C8=9B <alexandru.balut(a)g=
mail.com>wrote:
> On Firefox it can be noticed very easily, when you load the winehq.orgpag=
> e, and move the mouse over the icons, it takes a while until the hover
> images are loaded. You can clearly see the icon flickering. This patch fi=
> xes
> this problem by using a single image instead of 10 images.
>
> I had to change a bit the structure of the main page menu, to be able to
> preserve the current layout.
>
> Notice when you go to winehq.org and you hover the About link, it does no=
> t
> change its icon. To make ":hover" work in IE8, I had to change
> content_nobox.template and set the doctype to HTML 4.01 strict. As far as=
>  I
> checked, this only changes a tiny bit how the pages look. For example, th=
> e
> search box is 2px wider.
>
> I tested that:
> - the icons are changing when hovering them or the associated text;
> - the page looks the same (or better, see IE8);
> - when resizing the window very small, it looks reasonably ok (looks bett=
> er
> in the current format, but this is a corner case);
> - when resizing the window very large, it looks ok.
>
> I tested on:
> - Linux: Chrome, Epiphany, Firefox, Opera
> - Windows: Chrome, IE8, Firefox
>
> Thanks,
> Alex

The previous patch is incomplete. I attached the patch with the home.template file for de, es, fr, and pl changed accordingly. Please have a look.<div><br></div><div>Thanks,</div><div>Alex<br><br><div class="gmail_quote">On Fri, Jun 11, 2010 at 17:51, Alexandru Băluț <span dir="ltr"><<a href="mailto:alexandru.balut(a)gmail.com" target="_blank">alexandru.balut(a)gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Firefox it can be noticed very easily, when you load the <a href="http://winehq.org" target="_blank">winehq.org</a> page, and move the mouse over the icons, it takes a while until the hover images are loaded. You can clearly see the icon flickering. This patch fixes this problem by using a single image instead of 10 images.<div>

<br></div><div>I had to change a bit the structure of the main page menu, to be able to preserve the current layout.</div><div><br></div><div>Notice when you go to <a href="http://winehq.org" target="_blank">winehq.org</a> and you hover the About link, it does not change its icon. To make ":hover" work in IE8, I had to change content_nobox.template and set the doctype to HTML 4.01 strict. As far as I checked, this only changes a tiny bit how the pages look. For example, the search box is 2px wider.</div>

<div><div><br></div><div>I tested that:</div><div>- the icons are changing when hovering them or the associated text;</div>
<div>- the page looks the same (or better, see IE8);</div><div>- when resizing the window very small, it looks reasonably ok (looks better in the current format, but this is a corner case);</div><div>- when resizing the window very large, it looks ok.</div>

<div><br></div><div>I tested on:</div></div><div>- Linux: Chrome, Epiphany, Firefox, Opera</div><div>- Windows: Chrome, IE8, Firefox</div><div><br></div><div>
Thanks,</div><div>Alex</div>
</blockquote></div><br></div>

---

 images/home_icons.png                        |  Bin 0 -> 21418 bytes
 images/main_devel.png                        |  Bin 4385 -> 0 bytes
 images/main_devel_s.png                      |  Bin 4572 -> 0 bytes
 images/main_dl.png                           |  Bin 4439 -> 0 bytes
 images/main_dl_s.png                         |  Bin 4633 -> 0 bytes
 images/main_donate.png                       |  Bin 4235 -> 0 bytes
 images/main_donate_s.png                     |  Bin 4455 -> 0 bytes
 images/main_help.png                         |  Bin 4148 -> 0 bytes
 images/main_help_s.png                       |  Bin 4384 -> 0 bytes
 images/main_info.png                         |  Bin 3891 -> 0 bytes
 images/main_info_s.png                       |  Bin 4199 -> 0 bytes
 include/themes/winehq/content_nobox.template |    2 +-
 styles.css                                   |   39 ++++++++--------
 templates/de/home.template                   |   61 +++++++++++++++---------
 templates/en/home.template                   |   63 +++++++++++++++---------
 templates/es/home.template                   |   65 ++++++++++++++++----------
 templates/fr/home.template                   |   61 +++++++++++++++---------
 templates/pl/home.template                   |   61 +++++++++++++++---------
 18 files changed, 213 insertions(+), 139 deletions(-)

Diff:   http://source.winehq.org/git/website.git/?a=commitdiff;h=6a73a1c06a46231b151...