May 2002 - Wine-devel - list.winehq.org

shlwapi shreg tests failed
by Sylvain Petreolle 28 May '02

28 May '02

../../programs/winetest/runtest -q -P wine -M shlwapi.dll -T ../.. -p tests/shlwapi_test tests/shreg.c && touch tests/shreg.ok tests/shreg.c:125: Test failed: (21,20) tests/shreg.c:145: Test failed: (21,20) (both are in test_SHQUeryValueEx) ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 8

Re: Improvement for GetTimeZoneInformation
by Huw D M Davies 28 May '02

28 May '02

On Mon, May 27, 2002 at 11:12:07PM -0400, Vincent Béron wrote: > I need some help to finish this implementation. I don't have access to > an english version of Windows NT4 or 2K or XP, so I couldn't finish the > array of the timezones. COuld somebody help me a bit on this one? I'm > planning on actually writing the equivalence in Unix timezones, so you > only need to give me the names of the Windows timezones. I have a small > program to help you if you need it. > > Changelog: > - Improves the implementation of GetTimeZoneInformation. Missing some > Windows timezone names. In Windows there's a whole load of TimeZone information under \HLKM\Software\Microsoft\Windows\CurrentVersion\Time Zones I expect we should read the data from there rather than hardcode it; all we'd need to add would be a lookup table of Unix TZ names. Huw.

1 0

Re: Time related functions patches (bug #725)
by Vincent Béron 28 May '02

28 May '02

Note to self: read the docs thoroughly before submitting a patch. These 2 patches replace the similarly named patches in the parent message. There was a slight problem in the daylight saving part. Changelog: - Fix LocalFileTimeToFileTime (was offset if daylight was active). - Fix FileTimeToLocalFileTime (the case when timegm is absent was wrong, and gave different results than timegm). Vincent diff -urN wine-orig/files/dos_fs.c wine-pas-compilé/files/dos_fs.c --- wine-orig/files/dos_fs.c Thu May 23 16:36:46 2002 +++ wine-pas-compilé/files/dos_fs.c Sun May 26 21:20:25 2002 @@ -2174,11 +2174,14 @@ { struct tm *xtm; DWORD remainder; + time_t utctime; - /* convert from local to UTC. Perhaps not correct. FIXME */ - time_t unixtime = DOSFS_FileTimeToUnixTime( localft, &remainder ); - xtm = gmtime( &unixtime ); - DOSFS_UnixTimeToFileTime( mktime(xtm), utcft, remainder ); + /* Converts from local to UTC. */ + time_t localtime = DOSFS_FileTimeToUnixTime( localft, &remainder ); + xtm = gmtime( &localtime ); + utctime = mktime(xtm); + if(xtm->tm_isdst > 0) utctime-=3600; + DOSFS_UnixTimeToFileTime( utctime, utcft, remainder ); return TRUE; } diff -urN wine-orig/files/dos_fs.c wine-pas-compilé/files/dos_fs.c --- wine-orig/files/dos_fs.c Thu May 23 16:36:46 2002 +++ wine-pas-compilé/files/dos_fs.c Sun May 26 21:20:25 2002 @@ -2193,7 +2193,7 @@ LPFILETIME localft ) { DWORD remainder; - /* convert from UTC to local. Perhaps not correct. FIXME */ + /* Converts from UTC to local. */ time_t unixtime = DOSFS_FileTimeToUnixTime( utcft, &remainder ); #ifdef HAVE_TIMEGM struct tm *xtm = localtime( &unixtime ); @@ -2203,14 +2203,13 @@ DOSFS_UnixTimeToFileTime( localtime, localft, remainder ); #else - struct tm *xtm,*gtm; - time_t time1,time2; + struct tm *xtm; + time_t time; - xtm = localtime( &unixtime ); - gtm = gmtime( &unixtime ); - time1 = mktime(xtm); - time2 = mktime(gtm); - DOSFS_UnixTimeToFileTime( 2*time1-time2, localft, remainder ); + xtm = gmtime( &unixtime ); + time = mktime(xtm); + if(xtm->tm_isdst > 0) time-=3600; + DOSFS_UnixTimeToFileTime( 2*unixtime-time, localft, remainder ); #endif return TRUE; }

1 0

Re: SafeDisc-1 semi-cleaned note...
by Laurent Pinchart 28 May '02

28 May '02

> > The second one has been written by Alexandre to fix the process > > suspension at creation time. Once again I'd like to hear from him to know > > what he doesn't like about the code, as he's the one who wrote it :-) > > And I would also like to see this patch converted/ported to the current cvs > wine. Because the init_event has gone, and so most of the code in this > patch does not pertain. > > I tried to do it myself, but have failed... So for now I cant update my > wine for the current cvs version (though I would like to :) I've just had a look at the code and I can't see a way to merge the patch. Alexandre, could you have a look at that ? It seems that you removed the init_event cause it wasn't needed anymore, but it is by SafeDisc. Or can you think about another way to fix that ? Thanks in advance. Laurent Pinchart

1 0

Asian characters printing - not supported
by leanne 27 May '02

27 May '02

Dear all, We tried to print Chinese on notepad but failed. We found that WINE default only writes western characters to postscript. Is that true? Here is the .ps we produced from notepad on WINE. We were trying to print a text of Chinese. ~~~~~~~~~~~~~~~~ %%% 7 args %!PS-Adobe-3.0 %%Creator: Wine PostScript Driver %%Title: 未命名 - 記事本 %%BoundingBox: 18 36 594 756 %%Pages: (atend) %%Orientation: Portrait %%EndComments %%BeginProlog /tmpmtrx matrix def /hatch { pathbbox /b exch def /r exch def /t exch def /l exch def /gap 32 def l cvi gap idiv gap mul gap r cvi gap idiv gap mul {t moveto 0 b t sub rlineto} for } bind def %%EndProlog %%BeginSetup mark { %%BeginFeature: *PageSize Letter <</PageSize[612 792]/ImagingBBox null>>setpagedevice %%EndFeature } stopped cleartomark %%EndSetup %%Page: 1 1 %%BeginPageSetup /pgsave save def 72 600 div 72 600 div scale 150 6300 translate 1 -1 scale 0 rotate %%EndPageSetup 0.00 setgray % /InnMing-Light-HKscs-B5-H findfont /AvantGarde-Book findfont [84 0 0 -84 0 0] 0 10 div matrix rotate matrix concatmatrix makefont setfont 457 132 moveto /space glyphshow /space glyphshow /space glyphshow /space glyphshow /space glyphshow /space glyphshow /yen glyphshow /onequarter glyphshow /copyright glyphshow /R glyphshow /brokenbar glyphshow /W glyphshow /space glyphshow /space glyphshow /space glyphshow /space glyphshow 0.00 setgray /AvantGarde-Book findfont [167 0 0 -167 0 0] 0 10 div matrix rotate matrix concatmatrix makefont setfont 457 667 moveto (This is a test. ) show ====================================== later we edit the .ps and add: /InnMing-Light-HKscs-B5-H findfont [167 0 0 -167 0 0] 0 10 div matrix rotate matrix concatmatrix makefont setfont (我們都是好朋友。) show ====================================== /AvantGarde-Book findfont [167 0 0 -167 0 0] 0 10 div matrix rotate matrix concatmatrix makefont setfont /threesuperior glyphshow /o glyphshow /logicalnot glyphshow /O glyphshow /currency glyphshow /at glyphshow /space glyphshow /Oacute glyphshow /guillemotleft glyphshow /D glyphshow /plusminus glyphshow /grave glyphshow /yen glyphshow /i glyphshow /periodcentered glyphshow /R glyphshow /ordfeminine glyphshow /ordmasculine glyphshow /ordfeminine glyphshow /F glyphshow /brokenbar glyphshow /egrave glyphshow /exclamdown glyphshow /C glyphshow /section glyphshow /Uacute glyphshow /currency glyphshow 0.00 setgray /AvantGarde-Book findfont [84 0 0 -84 0 0] 0 10 div matrix rotate matrix concatmatrix makefont setfont 457 5832 moveto /space glyphshow .... ~~~~~~~~~~~~~~~~~~~~~ I would like to ask if WINE will support multi-byte character printing? Thanks very much. Leanne Tsang ThizLinux Laboratory Limited

4 6

null midi device
by Chris 27 May '02

27 May '02

i'd like to contribute to the wine codebase and for some applications of mine they request i have a midi device, but since i don't have one in linux, wine doesn't show one either. i'd like to create a null midi device in wine then, sort of like an optional midi device that appears to the application to be a midi device and works fine but doesn't play any music (so the application will at least run). does anything like this already exist in wine, if not, how hard would any of you experienced wine developers think it would be to create this? where should i start? thanks for any help you can offer. -- Chris chris(a)luethy.net

3 2

Re: Patches for Wine on 256 colour display and sparc
by Tony Lambregts 27 May '02

27 May '02

Gregg Mattinson wrote: >This patch is against the wine-20020509 snapshot. > >include/winnt.h: > - Fixed the LARGE_INTEGER and ULARGE_INTEGER unions for big endian. > >server/trace.c: > - Removed crash from dump_uints > >dlls/ntdll/time.c: > - Removed alignment problem in RtlSecondsSince19?0ToTime > >graphics/x11drv/palette.c: > - Icon colours on 256 colour display were wrong. > - Caused by using 0 in X11DRV_PALETTE_XPixelToPalette to represent free colour > - index 0 originally mapped to pixel 1 > - X11DRV_PALETTE_FillDefaultColors mapped index 50 to pixel 1, and hence pixel >1 was now mapped to 50 instead of 0. > - Replaced 0's with -1's > >Gregg Mattinson >Co-op Developer >Sun Microsystems of Canada > > >------------------------------------------------------------------------ > > > [snip] >*** server/,trace.c Thu May 23 10:42:47 2002 >--- server/trace.c Wed May 15 13:45:54 2002 >*************** >*** 47,57 **** > static void dump_uints( const int *ptr, int len ) > { > fputc( '{', stderr ); >! while (len > 0) > { >! fprintf( stderr, "%08x", *ptr++ ); >! if (--len) fputc( ',', stderr ); > } > fputc( '}', stderr ); > } > >--- 47,64 ---- > static void dump_uints( const int *ptr, int len ) > { > fputc( '{', stderr ); >! if (!ptr) > { >! fprintf( stderr, "dump_uints error: ptr is NULL" ); > ^ [snip] This patch is not in diff -u format. Please resubmit using diff -u. I recomend that you break the patchs up, one patch for each file or related .c and .h. Please look at the following. http://www.winehq.com/Docs/wine-devel/patches.shtml Tony Lambregts

1 0

Re: conflict on "NOERROR" #define
by Tony Lambregts 27 May '02

27 May '02

Philip Brown wrote: >in include/winerror.h, you need to add at line 1484: > >#ifdef NOERROR /* Solaris thing, in /usr/include/arpa/nameser_compat.h */ ># undef NOERROR >#endif > > > > > This is not a patch. The way I made the attached patch was, first cut and paste frome your email into winerror.h then run "cvs diff -u winerror.h > winerror.dif". If you don't have cvs and are running from tarball then the following is acceptable "diff -u winerror.old winerror.h > winerror.dif" (winerror.old is the unmodified version of winerror.h) http://www.winehq.org/Docs/wine-devel/patches.shtml Tony Lambregts Index: winerror.h =================================================================== RCS file: /home/wine/wine/include/winerror.h,v retrieving revision 1.42 diff -u -r1.42 winerror.h --- winerror.h 19 May 2002 22:27:42 -0000 1.42 +++ winerror.h 27 May 2002 17:53:44 -0000 @@ -1481,7 +1481,9 @@ /* HRESULT values for OLE, SHELL and other Interface stuff */ /* the codes 4000-40ff are reserved for OLE */ -#undef NOERROR /* arpa/nameser_compat.h defines this */ +#ifdef NOERROR /* Solaris thing, in /usr/include/arpa/nameser_compat.h */ +# undef NOERROR +#endif #define NOERROR 0L #define S_OK ((HRESULT)0L) #define S_FALSE ((HRESULT)1L)

1 0

Re: Clear an old button text in WM_SETTEXT as Windows does
by Andriy Palamarchuk 27 May '02

27 May '02

--- Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > Hello. > > This is a fix for WineHQ bug #437. > > P.S. > Could somebody with slightly more free time fix > DrawText(DT_CALCRECT), > since it returns width much larger than an expected > value? Dmitry, I advise you to create a bug for this issue in Bugzilla with detailed description, so the problem won't be lost. If the issue can be fixed by newbie, you can put it in the list of bug 406, if it is more difficult - to 455. Andriy __________________________________________________ Do You Yahoo!? LAUNCH - Your Yahoo! Music Experience http://launch.yahoo.com

3 4

note on bug status for lower numbered bugs...
by Dustin Navea 26 May '02

26 May '02

I am the one doing all the work on Bugzilla last night and today to close/resolve the bugs that are fixed and remind people of the ones that aren't. I hit 1-100 last night and today and I will get 100-200 on Tuesday, that should help cleanup some of the mess on there ;) -Dustin P.S. are Jim or Susan at codeweavers still active in the wine project, i.e. still working for codeweavers, or are their email addresses just dummies now? __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

1 0