December 2003 - Wine-devel - list.winehq.org

Re: Implement RegFlushKey
by Shachar Shemesh 29 Dec '03

29 Dec '03

Mike Hearn wrote: >This implementation is a little inefficient but without using a random >access binary db as Windows does (which I am not going to advocate) it's >the best we can do. > > > Ok, I'm going to be flamed for this, but I'm going to go ahead and ask. This is a request to understand, not a suggestion (yet?). Why not use a general purpose DB system? (postgresql, mysql, whatever) After all, the registry is just a tree shaped database. We can do that using standard SQL, and fall back to our current method if a proper DB is not found. Shachar -- Shachar Shemesh Open Source integration & consulting Home page & resume - http://www.shemesh.biz/

8 10

Yeah - our RichEDit needs some work
by Subhobroto Sinha 29 Dec '03

29 Dec '03

;) Actually, I noticed this many times before(text not displaying at all in a RichEdit control..) I am one of those (un)fortunate enough to not have a real Windows, and often download Win32 freeware to see how WINE's doing from time to time... IMHO, one of the best tests are Steve Gibson's (www.grc.com) freeware tools - this guy writes in pure ASM. and thus we can be sure that his code will be the least messy (lesser MS stuff..) However, if you try his 'Wizmo' or 'DCOMObulator', you will see that the RichEdit textareas as blank ! Unfortunately, the guy does not release his source (though I have reason to believe he would to anyone asking for it..) You may try them out in WINE guys, they are REALLY small (small code - that's a rarity on Windows nowdays.. people nowdays do not even use Win32 SDK,leave alone ASM) Guess we really need some work at RichEdits... I posted this mainly because it seems Zimler Attila wants to help - so there you are (^-^) BTW: CodeWeavers have good support for RichEdit controls, but why does not WINE ? Regards Subhobroto Sinha

5 4

Re: default config file creation
by Ivan Leo Murray-Smith 29 Dec '03

29 Dec '03

> Should we be performing the config file check inside wine at startup? Already wine is a wrapper that starts wine-pthread or wine-kthread, and don't forget about performance. >For this config check should we do something like: >if no config -> copy over default config > >if windows drive doesn't exist -> create fake windows drive and setup dll/ >application symlinks? Exactly, can you think of anything more usable? Ivan.

1 0

Re: cabinet.Extract
by Gregory M. Turner 29 Dec '03

29 Dec '03

On Sunday 28 December 2003 02:53 pm, Stefan Leichter wrote: > Hello, > > during playing with ie5.5 installer i noticed that the installing of some > cab files failed directly after the extract call. Doing exactly the same > extract call with the same cabinet file and the same content of the first > parameter i got a crash with native cabinet dll. The debugger shows at the > end of the function a "ret 8" assembler comand. > This means to remove 8 words (not bytes) from the stack because the segment > attribute is set to 32 bit (the pop command right before the ret is done > for a 32 bit register and does not have the opcode 0x66 in front to change > the register length). > Therefore the function extract must have 4 parameters instead of two. > > The bad thing is that the installer throws an exception instead of > aborting. > > ChangeLog > -------------- > the function ectract has four parameters not two Hmm, sounds like you are more of a natural at deducing this stuff than I, so I am happy to defer to your judgement... but I am slightly surprised, as I vaguely recall convincing myself that I had verified that it was right. Since ie5setup was probably my test app, maybe I added arguments until I stopped seeing winedbg, and declared it to be a success :P ... or did someone else do this part? Can't remember. No objection -- if its an improvement in ie5setup, it's surely right. Just thinking "aloud". Thanks for debugging this. Out of curiosity, was it w98 or NT you were (not) emulating? -- gmt "It is to be the assent and ratification of the several States, derived from the supreme authority in each State, the authority of the people themselves. The act, therefore, establishing the Constitution, will not be a NATIONAL, but a FEDERAL act." --James Madison, Federalist No. 39

2 1

Re: cabinet.Extract
by Stefan Leichter 29 Dec '03

29 Dec '03

Hello Alexandre, please ignore the patch it is wrong. Looks like i have to learn more assembler. Bye Stefan ---------- Weitergeleitete Nachricht ---------- Subject: cabinet.Extract Date: Sonntag, 28. Dezember 2003 21:53 From: Stefan Leichter <Stefan.Leichter(a)camLine.com> To: Wine Patches <wine-patches(a)winehq.org> Hello, during playing with ie5.5 installer i noticed that the installing of some cab files failed directly after the extract call. Doing exactly the same extract call with the same cabinet file and the same content of the first parameter i got a crash with native cabinet dll. The debugger shows at the end of the function a "ret 8" assembler comand. This means to remove 8 words (not bytes) from the stack because the segment attribute is set to 32 bit (the pop command right before the ret is done for a 32 bit register and does not have the opcode 0x66 in front to change the register length). Therefore the function extract must have 4 parameters instead of two. The bad thing is that the installer throws an exception instead of aborting. ChangeLog -------------- the function ectract has four parameters not two -------------------------------------------------------

1 0

Question about replacing a stub...
by Joshua Walker 29 Dec '03

29 Dec '03

Hi all. On my ever winding quest to fill in the win32 API documentation, I have found, I think, an intresting issue. When the documentation is generated with c2man.pl, it checks the .spec file to see if the function is a stub or not. The problem is that if it is a stub, no documentation will be generated for that API. I've decieded to take it upon myself to "fill in the blankes" as it were, but I need to know if I'm doing this correctly. For my example I'm going to use the stubbed function "AdjustTokenGroups" that is found in avdapi32.dll. The fist thing I did was update the .spec file so c2man.pl will parse the function correctly. I changed @ stub AdjustTokenGroups to: @ stdcall AdjustTokenGroups (long long ptr long ptr ptr) That allows c2man to parse the function. So now all I need to do is add that function to security.c. I added the following. --------------------- /****************************************************** * AdjustTokenGroups [ADVAPI32.@] * * Adjust the group privileges of an open token handle. * */ BOOL WINAPI AdjustTokenGroups( HANDLE TokenHandle, BOOL ResetToDefault, PTOKEN_GROUPS NewState, DWORD BufferLength, PTOKEN_GROUPS PreviousState, PDWORD ReturnLength ) { } ------------------------- And whamo-blamo, the documentation is generated... Now, I'm not too hot on coding, did I just break something to get my API to document? Should I be adding a fixme? Should I be returning something even though it's an empty function? I didn't compile it to see if it worked.The AdjustTokenGroups.html file that was generated says "Not defined in a Wine header. The function is either undocumented, or missing from Wine." Is it ok to leave that right now? Should I me putting something in a header file somewhere? Just wondering. -Joshua

2 2

Re: Re: wchar_t on GNU and Win32 - two worlds apart !
by Subhobroto Sinha 29 Dec '03

29 Dec '03

The program runs on Windows just fine because Windows Unicode function expects wchar_t to be 2 bytes (unlike GNU's) which is what it gets.. So the program runs on wine correctly too... But I want the app to be a native ELF using GLibc's own Internal functions... I have assumed that the user may not have WINE Regards On Sun, 28 Dec 2003 Dan Kegel wrote : >Dan Kegel wrote: >>I'm way out of touch with Wine these days, but here's > >[ meant to say "my two bits"... obviously my mind is wandering... ] > >>1. If you want to get something useful done, switch to C. Mixing >>g++ and Winelib seems to be a bit tricky, and you might end up >>spending all your time on that instead of solving the problem you >>originally wanted to solve. >> >>2. If you insist on using C++: >>if the problem resists analysis, perhaps you could use Valgrind >>to help track down the problem. > >3. Compile with MS Visual C++. I run MSVC++ 4.0 on Wine just fine, >and I bet even newer versions will run the commandline versions >of the compilers ok on wine. > >#3 really is the best option, since then your app will >run fine both on Windows and on Wine... > >- Dan > >

3 2

(no subject)
by Kevin Atkinson 29 Dec '03

29 Dec '03

I am having a problem compiling a simple winelib program which relies on a dll which uses the stdcall calling convention. I used pexports on the dll avisynth_c.dll to created the spec and then edited the file to removed the leading underscore in the names (without that it would not link). That file is attached. Than with only "avisynth_c.h", "avs2yuv.cpp" and "libavisynth_c.def" in the current directory. I ran winemaker --console -iavisynth_c --single-target avs2yuv.exe . ./configure --with-wine=/opt/wine/ make then I copy the required DLL in the current directory and attempt to run it. But I get: ./avs2yuv err:module:import_dll No implementation for avisynth_c.dll.avs_create_script_environment imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_get_frame imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_get_video_info imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_invoke imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_release_value imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_release_video_frame imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef err:module:import_dll No implementation for avisynth_c.dll.avs_take_clip imported from L"C:\\WINDOWS\\SYSTEM\\avs2yuv.exe", setting to 0xdeadbeef Usage avs2yuv4mpeg <avsfile> <outfile> Does anyone know what is going on. Here is the output of make if it will help: sed -e 's,@bindir\@,/usr/local/bin,g' -e 's,@winelibdir\@,.,g' ./wineapploader.in >wineapploader || rm -f wineapploader LD_LIBRARY_PATH="/opt/wine//lib:$LD_LIBRARY_PATH" /opt/wine//bin/winebuild -o avs2yuv.exe.dbg.c --debug -C. avs2yuv.cpp gcc -c -I. -I/opt/wine//include/wine/windows -g -O2 -fPIC -D_REENTRANT -o avs2yuv.exe.dbg.o avs2yuv.exe.dbg.c g++ -c -I. -I/opt/wine//include/wine/windows -g -O2 -fpermissive -fno-for-scope -D_REENTRANT -o avs2yuv.o avs2yuv.cpp LD_LIBRARY_PATH="/opt/wine//lib:$LD_LIBRARY_PATH" /opt/wine//bin/winebuild -fPIC -o avs2yuv.exe.spec.c --exe avs2yuv.exe -mcui avs2yuv.o -L/opt/wine//lib/wine -lavisynth_c gcc -c -I. -I/opt/wine//include/wine/windows -g -O2 -fPIC -D_REENTRANT -o avs2yuv.exe.spec.o avs2yuv.exe.spec.c g++ -shared -Wl,-Bsymbolic -o avs2yuv.exe.so avs2yuv.o avs2yuv.exe.dbg.o avs2yuv.exe.spec.o -L/opt/wine//lib -lwine -lwine_unicode -lwine_uuid -lm test -f avs2yuv || install ./wineapploader avs2yuv I attached the zip file with the source and any files I thought were relevant. If required I can send additional files dll's in a private email (such as the required dll's). Wine version 20031212 built from source on a RedHat System. I had the exact same problem when I used the debs from unstable (also version 20031212) on a libranet system. Is this a bug, or am I doing something wrong? When I used a a version of avisynth_c.dll which used cdecl on all API functions -- without changing the .def or header files -- instead of stdlib I do not have this problem. Naturally I do not expect it to run since I didn't recompile my code with the proper header files. I discovered this by accident because the previous version used cdecl and I had some old dll laying around in a place wine was able to find. Can anyone help me get this working? Am I doing something wrong or is this a bug in wine? Thanks in advance. --- http://kevin.atkinson.dhs.org

4 26

Re: default config file creation
by Ivan Leo Murray-Smith 29 Dec '03

29 Dec '03

>I was wondering if it would make more sense during the compile process to take >the default configuration files, config, system.reg, user.reg and userdef.reg >and convert these to binary form and compile them into the wine binary >itself. We could detect the lack of these files at startup and install them >for the user. Very cool idea, it would increase usability a lot. You don't really need to compile the files, you can just install them in /usr/share/doc/wine-yyyymmdd/samples or something like that and copy them to $HOME/.wine if needed. )There wouldn't be any performance loss as these files are read at startup anyway.Wine could also create a fake c drive in the users home and create a link to it it needed. Ivan.

3 2

Re: wchar_t on GNU and Win32 - two worlds apart !
by Dan Kegel 29 Dec '03

29 Dec '03

Subhobroto Sinha wrote: > The program runs on Windows just find because Windows Unicode function expects wchar_t to be 2 bytes (ulike GNU's) > > So the program runs on wine correctly too... > > But I want the app to be a native ELF using GLibc's own Internal functions... > > I have assumed that the user may not have WINE What good is a start menu that reads windows .lnk files if the user doesn't have wine? - Dan

1 0