February 2003 - Wine-devel - list.winehq.org

Re: loader: fix loadorder
by Alexandre Julliard 15 Feb '03

15 Feb '03

"Dimitrie O. Paun" <dpaun(a)rogers.com> writes: > ChangeLog > Revert default loadorder to native DLLs firsts, to use > the programs supplied ones if available. > (Bug discovered and investigated by Tony Lambregts) I don't think we should revert it, using builtins by default is a good idea IMO. We just need to handle dlls with an explicit path differently; how about something like this? Index: loader/loadorder.c =================================================================== RCS file: /opt/cvs-commit/wine/loader/loadorder.c,v retrieving revision 1.60 diff -u -r1.60 loadorder.c --- loader/loadorder.c 23 Oct 2002 20:20:59 -0000 1.60 +++ loader/loadorder.c 14 Feb 2003 19:24:14 -0000 @@ -103,6 +103,12 @@ LOADORDER_BI, LOADORDER_DLL, 0, 0 }; +/* default for modules with an explicit path */ +static const enum loadorder_type default_path_loadorder[LOADORDER_NTYPES] = +{ + LOADORDER_DLL, LOADORDER_BI, 0, 0 +}; + static struct loadorder_list cmdline_list; @@ -674,13 +680,18 @@ debugstr_loadorder(loadorder), debugstr_a(path) ); goto done; } - } - - /* and last the hard-coded default */ - memcpy( loadorder, default_loadorder, sizeof(default_loadorder) ); - TRACE( "got hardcoded default %s for %s\n", - debugstr_loadorder(loadorder), debugstr_a(path) ); + /* and last the hard-coded default */ + memcpy( loadorder, default_loadorder, sizeof(default_loadorder) ); + TRACE( "got hardcoded default %s for %s\n", + debugstr_loadorder(loadorder), debugstr_a(path) ); + } + else /* module contains an explicit path */ + { + memcpy( loadorder, default_path_loadorder, sizeof(default_path_loadorder) ); + TRACE( "got hardcoded path default %s for %s\n", + debugstr_loadorder(loadorder), debugstr_a(path) ); + } done: if (app_key) NtClose( app_key ); -- Alexandre Julliard julliard(a)winehq.com

4 3

How to debug a windows app
by Gerhard W. Gruber 15 Feb '03

15 Feb '03

I noticed that Agent crashes frequently when sending email. It shows an exception which I never saw on Winodws because Agent is rather stable. Now I want to take a look at it, but I need to know how I can debug a windows app running under wine. -- Gerhard Gruber Für jedes menschliche Problem gibt es immer eine einfache Lösung: Klar, einleuchtend und falsch. (Henry Louis Mencken)

3 3

Re: msvcrt _tempnam dll
by Paul Millar 15 Feb '03

15 Feb '03

Hi Uwe, On Sat, 15 Feb 2003, Uwe Bonnes wrote: > Test succeeds with native msvcrt.dll. Patch to msvcrt/file.c comming. Is it worth marking the tests as todo and removing the todo once wine passes the tests? Just a thought ... ---- Paul Millar

1 0

Re: small ctl3d fix
by Dmitry Timoshkov 15 Feb '03

15 Feb '03

"Rok Mandeljc" <rokmandeljc(a)hotmail.com> wrote: > > > Dmitry's patch doesn't fix my problem, because app call only > > > Ctl3dIsAutoSubclass and it expects it to be true. > > > > > > ChangeLog: > > > Changed default internal ctl3d auto subclass flag from false to true > > > > My test shows that after a successful Ctl3dRegister() > Ctl3dIsAutoSubclass() > > returns FALSE. Therefore your patch is wrong and you have to investigate > > what sequence of ctl3d calls in your application makes it return TRUE. > > > > -- > > Dmitry. > > > > like i said, it calls only Ctl3dIsAutoSubclass() and expects true, otherwise > it starts debugger. what if it should be set true for default and > Ctl3dRegister sets it to false? No, my test shows that by default it's set to FALSE. If you can't investigate it yourself for any reason please send a +relay compressed bz2 log (not more than 500 Kb) to me (*not* to the list) showing the real behaviour of your application. Thanks. -- Dmitry.

1 0

Treeview Icons now broken builtin too
by Uwe Bonnes 15 Feb '03

15 Feb '03

Hallo, some time ago, I reported, that in Xilinx Webpack some Icons associated with a treeview where distorted, when using the native commctrl dlls, but all right when using builtin dlls. With the recent updates, now builtin behaves like native and shows distorted Icons. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

Re: small ctl3d fix
by Dmitry Timoshkov 14 Feb '03

14 Feb '03

"Rok Mandeljc" <rokmandeljc(a)hotmail.com> wrote: > Dmitry's patch doesn't fix my problem, because app call only > Ctl3dIsAutoSubclass and it expects it to be true. > > ChangeLog: > Changed default internal ctl3d auto subclass flag from false to true My test shows that after a successful Ctl3dRegister() Ctl3dIsAutoSubclass() returns FALSE. Therefore your patch is wrong and you have to investigate what sequence of ctl3d calls in your application makes it return TRUE. -- Dmitry.

1 0

Patch Manager
by Fabian Cenedese 14 Feb '03

14 Feb '03

Hi I have never supplied patches myself. But I read all the mails about how to submit patches. I saw on the wxWindows page that they have a Patch- Manager. Mainly just a form to enter all necessary data. Maybe something like that could be useful here too. http://sourceforge.net/tracker/?group_id=9863&atid=309863&func=add bye Fabi

4 3

VC++ nmake not working with Wine 20030115 when it worked with 200208xx
by J. Grant 14 Feb '03

14 Feb '03

Hi, Calling nmake from /wcmd/ used to work, now it does not. I can't see why not, here is the debugger ouput if anyone knows whats wrong I'd be happy to hear! Breakpoint 1 at 0x40009bd0 (_end+0x37fae414) *** Invalid address 0x40011f80 (_end+0x37fb67c4) <snip> Unhandled exception: unimplemented function msvcrt.dll.__p__pgmptr called in 32- bit code (0x40733056). In 32-bit mode. 0x40733056 (__wine_unimplemented+0x56 [msvcrt.spec.c:47] in msvcrt.dll.so): jmp 0x40733050 (__wine_unimplemented+0x50 [msvcrt.spec.c:47] in msvcrt.dll.so) 47 for (;;) RtlRaiseException( &rec ); Wine-dbg> There are a few unknown functions with "__p__pgmptr" void __wine_stub_msvcrt_dll_122(void) { __wine_unimplemented("__p__pgmptr"); } I'm not sure why this problem occures now, when it worked before. Comments welcome Regards JG

5 16

Non-applied patches
by Shachar Shemesh 14 Feb '03

14 Feb '03

Hi Alexandre, I'm just trying to understand whether you are still trying to fight the backlog, my patches fell through the cracks, or that you decided not to apply them. I am referring to: http://www.winehq.com/hypermail/wine-patches/2003/01/0399.html and http://www.winehq.com/hypermail/wine-patches/2003/01/0401.html If the last option, please explain what is wrong with them. Sh. P.S. A simple mail saying "I'm still fighting the backlog, I'll let you know when I've covered all the submitted patches" will suffice, as far as I'm concerned. -- Shachar Shemesh Open Source integration consultant http://www.consumer.org.il/sun/

2 2

Re: Listview delete column zero
by Duane Clark 14 Feb '03

14 Feb '03

Duane Clark wrote: > While the MSDN specifically says that column zero should not be deleted, > it does in fact work on WinNT, and at least one app depends on it. On > WinNT, deleting column zero deletes the last column of items but the > first header. Since no app will ever depend on that bizarre behavior, > we just delete the last column including the header. > I probably should have mentioned why the app deletes column zero. It repeatedly deletes column zero, testing the returned Boolean until it gets false, and then it starts inserting new columns. So it ends up completely replacing the listview contents.

2 2