February 2003 - Wine-devel - list.winehq.org

Listview problems
by Dan Kegel 07 Feb '03

07 Feb '03

I've already sent this to Dimi, but... the demo http://msdn.microsoft.com/downloads/samples/internet/commctrl/vlistvw/defau… doesn't work very well with Wine at the moment. It demonstrates the LVS_OWNERDATA variant of a listview. I built it with msvc6. The default view looks ok, but if you pick a different view, the fun starts... "large icons" seem to all be drawn on top of each other. - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

2 3

edit control bug
by Felipe W Damasio 07 Feb '03

07 Feb '03

Hi, I'm porting a software using winelib and found a (at least I think so) serious bug with the edit control: When you put a lot of text in an edit control and then begins to backspace them, the app simply seg faults. I'm using wine-20030115 but also tried wine-20021031, and both have this bug. Both the source and the executable for test are available here: ftp://elipse.com.br/pub/EditControl/about1-src.tar.gz ftp://elipse.com.br/pub/EditControl/about1-exe.tar.gz Yeah, I stole the example from Petzold's book....so please enter help->about to see the dialog :) Can anyone help with this? Is this a known wine bug? I did the usual google search but couldn't fine any reference of this. But if is: Is somebody working on it? Or will anyone work on this? And can I help? Thanks for any help you can give me (please CC me). Felipe

3 5

Re: RtlUpperChar (was: some ntdll functions) [Virus checked]
by thomas.mertes＠t-mobile.at 07 Feb '03

07 Feb '03

Dan Kegel <dank(a)kegel.com> wrote: > That looks like a horrible kludge. Before we settle on > something like this, we should probably consult the > people on the unicode mailing list to see what they > suggest. This is not what I suggest. Please read my complete mail. I wrote: I did a test on w2k trying to convert all chars between 0 and 255. The result was: Just 'a' .. 'z' are converted to 'A' .. 'Z', all other characters remain unchanged. I switched the machine between 'EN' (English) and 'DE' (German) and no difference. My test Function is: static void test_RtlUpperChar(void) { int i; CHAR ch; CHAR upper_ch; CHAR expected_upper_ch; for (i = 0; i <= 255; i++) { ch = (CHAR) i; upper_ch = pRtlUpperChar(ch); if (ch >= 'a' && ch <= 'z') { expected_upper_ch = ch - 'a' + 'A'; } else { expected_upper_ch = ch; } /* if */ ok(upper_ch == expected_upper_ch, "RtlUpperChar('%c') has result '%c', expected '%c'", ch, upper_ch, expected_upper_ch); } /* for */ } ... and this test passed really under native w2k. Greetings Thomas

2 1

WineConf 2003
by Dan Kegel 06 Feb '03

06 Feb '03

How about we hold it as a satellite conference to LinuxTag, Karlsruhe, Germany, 10-13 July 2003? LinuxTag is a very big, very cool event. See http://www.linuxtag.org/2003/en/conferences/cfp.html - Dan -- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045

4 5

Re: Fix module entry deallocation in MODULE_DecRefCount
by Eric Pouech 06 Feb '03

06 Feb '03

Warren_Baird(a)cimmetry.com wrote: > > > ChangeLog: > > Fix module entry deallocation in MODULE_DecRefCount. > > Description: > > Also decrement the reference count on any other libraries with > exactly the same short name since two module entries are being > allocated when we load the library. Maybe the real fix here would > be to ensure that a module entry is allocated no more than once > but we couldn't figure out how to do that. the fix doesn't seem the right one... could you post a -debugmsg +file,+module of what really happens here A+ -- Eric Pouech

1 0

Re: RtlUpperChar (was: some ntdll functions) [Virus checked]
by thomas.mertes＠t-mobile.at 06 Feb '03

06 Feb '03

"Dmitry Timoshkov" <dmitry(a)baikal.ru> wrote: > <thomas.mertes(a)t-mobile.at> wrote: > > > RtlUpperChar does not take the locale into account. It always convertes > > just > > 'a' .. 'z' and nothing else. > > > > Is this the right direction or did I miss something? > > No, that's not right. We really need to convert to unicode first, then > upper case unicode character and convert the result back to ansi. See > the ReactOS source for reference (at the first glance it closely enough > matches NTDLL asm code). I have not seen the asm code. I just do tests on w2k (see my other mail). ReactOS is ok but not my measurement. These tests suggest that the right implementation would be: CHAR WINAPI RtlUpperChar( CHAR ch ) { if (ch >= 'a' && ch <= 'z') { return ch - 'a' + 'A'; } else { return ch; } } I was not able to find any other behaviour under w2k. RtlUpperString also just converts 'a' .. 'z' to 'A' .. 'Z'. In my opinion RtlUpperChar and RtlUpperString are low level functions which do not know anything about locales / codepages. But the ntdll (and msvcrt) functions toupper and _toupper should know about locales / codepages (may be they should use the solution below). BTW: My other implementation did it the ReactOS way and is not a 'horrible kludge': CHAR WINAPI RtlUpperChar( CHAR ch ) { WCHAR wch; wch = toupperW(((WCHAR) ch) & 0xff); if (wch >> 8) { return ch; } else { return (CHAR) wch; } } According to my information: When you do not have multibyte chars (as it is here), you just set the upper byte to 0. Just look close: ((WCHAR) ch) & 0xff is necessary because CHAR is signed and ((WCHAR) ch) would sign extend (which is wrong). I did a test with the 'horrible kludge' on wine and it worked fine (The ISO Latin 1 charaters got converted in the right way). Greetings Thomas

2 1

Re: Fixes for makepath
by Dimitrie O. Paun 06 Feb '03

06 Feb '03

On Thu, 6 Feb 2003 Warren_Baird(a)cimmetry.com wrote: > - TRACE("got %s %s %s %s\n", drive, directory, > - filename, extension); > + char tmpPath[MAX_PATH]; > + TRACE("got %s %s %s %s\n", > + drive ? drive : "", > + directory ? directory : "", > + filename ? filename : "", > + extension ? extension : ""); Please use debugstr_a instead, like so: TRACE("got %s %s %s %s\n", debugstr_a(drive), debugstr_a(directory)... -- Dimi.

1 0

Re: Winspool errors with notepad
by Sylvain Petreolle 06 Feb '03

06 Feb '03

trace:winspool:AddPrinterA ((null),2,0x407c2c1c): stub trace:winspool:DEVMODEdupAtoW trace:winspool:AddPrinterW (L"",2,0x4026ac58) Following these debug messages, we see that the name of the server on which the server is installed changes fromNULL to "". Currently we dont support remote printers and the the name must be NULL otherwise the function fails. It lies into wine/dlls/winspool/info.c : if(pName != NULL) { ERR("pName = %s - unsupported\n", debugstr_w(pName)); SetLastError(ERROR_INVALID_PARAMETER); return 0; The file was updated to avoid HEAP_strdupAtoW calls. Matthew, could you look at this ? ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight against Spam ! http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

4 7

Re: Implement SelectPalette and RealizePalette in mfdrv
by Dmitry Timoshkov 06 Feb '03

06 Feb '03

<Warren_Baird(a)cimmetry.com> wrote: > diff -ur clean/wine/objects/palette.c wine/objects/palette.c > --- clean/wine/objects/palette.c Wed Jan 29 15:31:13 2003 > +++ wine/objects/palette.c Fri Jan 31 12:47:21 2003 > @@ -674,6 +674,7 @@ > } > if (!(dc = DC_GetDCPtr( hdc ))) return 0; > prev = dc->hPalette; > + if (dc->funcs->pSelectPalette) hpal = dc->funcs->pSelectPalette( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ here hpal is zeroed out. > dc->physDev, hpal, FALSE ); > dc->hPalette = hpal; ^^^^^^^^^^^^^^^^^^^ 1. The above code chunk always sets dc->hPalette to zero in the case of metafile dc. 2. It seems that most of your all patches are wrapped by your mailer. 3. Some of your patches use C++ comments. 4. Some of your patches use a C++ style of declaring variables in the arbitrary place of the function. Please fix all of the above and resend the affected patches. Thanks. -- Dmitry.

1 0

RE: WineConf 2003
by Patrik Stridvall 06 Feb '03

06 Feb '03

> LinuxTag is my favorite so far, fwiw, as > 1) it looks fairly well organized and interesting in its own right Yes, this is of course both good and bad. Good because it is as you said intresting, bad because we might lose the Wine focus. This is that IMHO happend at LinuxKongress in Erlangen (2000?). Sure it was a very nice social gathering and I enjoyed it very much but compared to WineConf 2002 in San Diego it didn't really amount to very much. Productively speaking that is. While I personnally are very likely to show up anyway, we really should carefully plan what we should do, not just take it as is comes as happend at LinuxKongress 2000. > 2) it's not freezing cold like Espoo in February would be True. It is quite cold here in Sweden right now and Finland is usually colder. :-) > 3) it's in a German-speaking country (I didn't learn my Grandma's > Finnish too well, but I did learn my Grandpa's German!) True. However the biggest use of I had of the little German I know was reading the menu at the resturant. :-) You will do fine with just English. > 4) it's the least likely of the bunch to conflict with the > arrival of my first kid on 31 July, the first day of the > Edinburgh event :-) 5) "The 9th Annual International LinuxTag will take place at the Convention Center in the Messe at Karlsruhe, Germany. Karlsruhe is located in the southern part of Germany near Heidelberg and can be easily reached via Frankfurt International Airport and by rail." Since AFAIK most European major airports (and quite a few minor airports) have flights to Frankfurt it will presumably be easier and cheaper traveling to than most of the alternatives. Please note if somebody wishes to speak at the conferance: "Abstract submission deadline: February 21, 2003"

1 0