March 2003 - Wine-devel - list.winehq.org

RE: Janitorial W->A cleanup objects/metafile.c dlls/gdi/mfdrv/init.c
by Rolf Kalbermatter 24 Mar '03

24 Mar '03

This is a multi-part message in MIME format. --------------030003030306020205040907 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit >This one was required more that a mop and pail. In the end what I had to do is >convert MF_CreateMetaHeaderDisk to unicode. > >One burning question I have at this point is the relative merits of using >RtlCreateUnicodeStringFromAsciiz vs MultiByteToWideChar Well, when using MultiByteToWideChar you usually format into a buffer allocated on the stack whereas RtlCreateUnicodeStringFromAsciiz seems to allocate a buffer on the heap which you later free. The first is somewhat faster as no memory management calls are caused, but as Alexandre has pointed out, the current Wine code is at places quite stack intense which over time could lead to serious problems if Wine is extended with even more functions allocating much more Unicode buffers on the stack. So the question is really one about a little performance gain vs. code which has moderate stack requirements. Personally I think it is ok to allocate once a Unicode buffer on the stack in the high level API to convert ANSI to Unicode, provided the code path further down doesn't go back and forth between ANSI and Unicode conversions. But in general we should probably try in the future to get those buffers more often allocated dynamically for two reasons: 1) Just as a single buffer on the stack in a high level API once doesn't cause extreme stack usage, does the same single allocation of a buffer on the heap not cause a very noticable performance hit. 2) With proper dynamic buffer allocations we can get rid of many buffer length limitations. A stack buffer is always fixed length and can fail fataly if a parameter is entered which causes buffer overflow. So the code needs to do extra checks. Dynamic allocated buffers can be as long as necessary and do not necessarily have buffer overflow issues. Rolf Kalbermatter CIT Engineering Nederland BV tel: +31 (070) 415 9190 Treubstraat 7H fax: +31 (070) 415 9191 2288 EG Rijswijk http://www.citengineering.com Netherlands mailto:rolf.kalbermatter(a)citeng.com

1 0

Clipboard between applications
by Ferenc Wagner 24 Mar '03

24 Mar '03

Hello! I'm unable to move the contents of the clipboard between applications. At the end you find an annotated --debugmsg +clipboard log (with a call for IsSelectionOwner inserted into CloseClipboard). In short, the copying application can read the clipboard, but the other one can't. Seems like the x11drv/clipboard.c data isn't shared between the threads. Copying between two notepad.exe.so-s works, but through the X selection only (guess from the logs; the IsSelectionOwner status is 1 (ie. S_PRIMARY) during that process). Is it a mis(configuration|understanding) on my side, or isn't this functionality implemented? Thanks: Feri. ### Application startup: trace:clipboard:OpenClipboard ((nil))... trace:clipboard:OpenClipboard returning 1 trace:clipboard:EmptyClipboard () trace:clipboard:GetOpenClipboardWindow () trace:clipboard:X11DRV_AcquireClipboard Grabbed X selection, owner=(00000000) trace:clipboard:CloseClipboard () trace:clipboard:X11DRV_IsSelectionOwner status: 3 fixme:font:WineEngCreateFontInstance Untranslated charset 138 ### Copy to selection: trace:clipboard:OpenClipboard (0x2007a)... trace:clipboard:OpenClipboard returning 1 trace:clipboard:EmptyClipboard () trace:clipboard:GetOpenClipboardWindow () trace:clipboard:SetClipboardData (0000000D, 0x403a2f4a) ! trace:clipboard:GetOpenClipboardWindow () trace:clipboard:SetClipboardData (00000001, 0x403a099a) ! trace:clipboard:GetOpenClipboardWindow () trace:clipboard:CloseClipboard () trace:clipboard:X11DRV_IsSelectionOwner status: 3 ### Paste selection (other application) trace:clipboard:OpenClipboard (0x20065)... trace:clipboard:OpenClipboard returning 1 trace:clipboard:X11DRV_IsSelectionOwner status: 0 [...it fails...] ### Paste selection (application that made to copy) trace:clipboard:OpenClipboard (0x2007a)... trace:clipboard:OpenClipboard returning 1 trace:clipboard:CLIPBOARD_EnumClipboardFormats Next available format 13 trace:clipboard:IsClipboardFormatAvailable (000D)- ret(1) trace:clipboard:GetClipboardData (0000000D) trace:clipboard:CLIPBOARD_RenderText UNICODETEXT -> UNICODETEXT trace:clipboard:CLIPBOARD_RenderFormat enter format=13 trace:clipboard:X11DRV_IsSelectionOwner status: 3 trace:clipboard:GetClipboardData returning 0x4039ec92 (type 13) trace:clipboard:CloseClipboard () trace:clipboard:X11DRV_IsSelectionOwner status: 3 [...success...]

2 3

Re: ListView - add CACHEHINT notification in OwnerData mode
by Dimitrie O. Paun 23 Mar '03

23 Mar '03

On March 22, 2003 04:21 pm, Vitaliy Margolen wrote: > List view should sent LVN_ODCACHEHINT notification before paint when it's > virtual list (LVS_OWNERDATA style). We were sending it only in OwnerDraw. Indeed. Thanks for the patch. I suggest a slightly different patch, that cleansup the duplication. Does this work for you? ChangeLog Send LVN_ODCACHEHINT notification for LVS_OWNERDATA style in all modes (based on a patch by Vitaliy Margolen). Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.345 diff -u -r1.345 listview.c --- dlls/comctl32/listview.c 15 Mar 2003 00:05:46 -0000 1.345 +++ dlls/comctl32/listview.c 23 Mar 2003 16:54:05 -0000 @@ -3618,14 +3618,13 @@ * RETURN: * None */ -static void LISTVIEW_RefreshOwnerDraw(LISTVIEW_INFO *infoPtr, HDC hdc) +static void LISTVIEW_RefreshOwnerDraw(LISTVIEW_INFO *infoPtr, ITERATOR *i, HDC hdc) { UINT uID = GetWindowLongW(infoPtr->hwndSelf, GWL_ID); HWND hwndParent = GetParent(infoPtr->hwndSelf); POINT Origin, Position; DRAWITEMSTRUCT dis; LVITEMW item; - ITERATOR i; TRACE("()\n"); @@ -3633,26 +3632,11 @@ /* Get scroll info once before loop */ LISTVIEW_GetOrigin(infoPtr, &Origin); - - /* figure out what we need to draw */ - iterator_visibleitems(&i, infoPtr, hdc); - /* send cache hint notification */ - if (infoPtr->dwStyle & LVS_OWNERDATA) - { - RANGE range = iterator_range(&i); - NMLVCACHEHINT nmlv; - - ZeroMemory(&nmlv, sizeof(NMLVCACHEHINT)); - nmlv.iFrom = range.lower; - nmlv.iTo = range.upper - 1; - notify_hdr(infoPtr, LVN_ODCACHEHINT, &nmlv.hdr); - } - /* iterate through the invalidated rows */ - while(iterator_next(&i)) + while(iterator_next(i)) { - item.iItem = i.nItem; + item.iItem = i->nItem; item.iSubItem = 0; item.mask = LVIF_PARAM | LVIF_STATE; item.stateMask = LVIS_SELECTED | LVIS_FOCUSED; @@ -3677,7 +3661,6 @@ TRACE("item=%s, rcItem=%s\n", debuglvitem_t(&item, TRUE), debugrect(&dis.rcItem)); SendMessageW(hwndParent, WM_DRAWITEM, dis.CtlID, (LPARAM)&dis); } - iterator_destroy(&i); } /*** @@ -3692,13 +3675,13 @@ * RETURN: * None */ -static void LISTVIEW_RefreshReport(LISTVIEW_INFO *infoPtr, HDC hdc, DWORD cdmode) +static void LISTVIEW_RefreshReport(LISTVIEW_INFO *infoPtr, ITERATOR *i, HDC hdc, DWORD cdmode) { INT rgntype; RECT rcClip, rcItem; POINT Origin, Position; RANGE colRange; - ITERATOR i, j; + ITERATOR j; TRACE("()\n"); @@ -3726,16 +3709,13 @@ if (infoPtr->dwLvExStyle & LVS_EX_FULLROWSELECT) j.nSpecial = 0; - /* figure out what we need to draw */ - iterator_visibleitems(&i, infoPtr, hdc); - /* iterate through the invalidated rows */ - while(iterator_next(&i)) + while(iterator_next(i)) { /* iterate through the invalidated columns */ while(iterator_next(&j)) { - LISTVIEW_GetItemOrigin(infoPtr, i.nItem, &Position); + LISTVIEW_GetItemOrigin(infoPtr, i->nItem, &Position); Position.x += Origin.x; Position.y += Origin.y; @@ -3748,10 +3728,10 @@ if (!RectVisible(hdc, &rcItem)) continue; } - LISTVIEW_DrawItem(infoPtr, hdc, i.nItem, j.nItem, Position, cdmode); + LISTVIEW_DrawItem(infoPtr, hdc, i->nItem, j.nItem, Position, cdmode); } } - iterator_destroy(&i); + iterator_destroy(&j); } /*** @@ -3766,26 +3746,21 @@ * RETURN: * None */ -static void LISTVIEW_RefreshList(LISTVIEW_INFO *infoPtr, HDC hdc, DWORD cdmode) +static void LISTVIEW_RefreshList(LISTVIEW_INFO *infoPtr, ITERATOR *i, HDC hdc, DWORD cdmode) { POINT Origin, Position; - ITERATOR i; /* Get scroll info once before loop */ LISTVIEW_GetOrigin(infoPtr, &Origin); - /* figure out what we need to draw */ - iterator_visibleitems(&i, infoPtr, hdc); - - while(iterator_prev(&i)) + while(iterator_prev(i)) { - LISTVIEW_GetItemOrigin(infoPtr, i.nItem, &Position); + LISTVIEW_GetItemOrigin(infoPtr, i->nItem, &Position); Position.x += Origin.x; Position.y += Origin.y; - LISTVIEW_DrawItem(infoPtr, hdc, i.nItem, 0, Position, cdmode); + LISTVIEW_DrawItem(infoPtr, hdc, i->nItem, 0, Position, cdmode); } - iterator_destroy(&i); } @@ -3809,6 +3784,7 @@ DWORD cdmode; INT oldBkMode; RECT rcClient; + ITERATOR i; LISTVIEW_DUMP(infoPtr); @@ -3835,19 +3811,35 @@ /* nothing to draw */ if(infoPtr->nItemCount == 0) goto enddraw; + /* figure out what we need to draw */ + iterator_visibleitems(&i, infoPtr, hdc); + + /* send cache hint notification */ + if (infoPtr->dwStyle & LVS_OWNERDATA) + { + RANGE range = iterator_range(&i); + NMLVCACHEHINT nmlv; + + ZeroMemory(&nmlv, sizeof(NMLVCACHEHINT)); + nmlv.iFrom = range.lower; + nmlv.iTo = range.upper - 1; + notify_hdr(infoPtr, LVN_ODCACHEHINT, &nmlv.hdr); + } + if ((infoPtr->dwStyle & LVS_OWNERDRAWFIXED) && (uView == LVS_REPORT)) - LISTVIEW_RefreshOwnerDraw(infoPtr, hdc); + LISTVIEW_RefreshOwnerDraw(infoPtr, &i, hdc); else { if (uView == LVS_REPORT) - LISTVIEW_RefreshReport(infoPtr, hdc, cdmode); + LISTVIEW_RefreshReport(infoPtr, &i, hdc, cdmode); else /* LVS_LIST, LVS_ICON or LVS_SMALLICON */ - LISTVIEW_RefreshList(infoPtr, hdc, cdmode); + LISTVIEW_RefreshList(infoPtr, &i, hdc, cdmode); /* if we have a focus rect, draw it */ if (infoPtr->bFocus) DrawFocusRect(hdc, &infoPtr->rcFocus); } + iterator_destroy(&i); enddraw: if (cdmode & CDRF_NOTIFYPOSTPAINT) -- Dimi.

2 1

Re: SPI_GETGRADIENTCAPTIONS
by Tony Lambregts 23 Mar '03

23 Mar '03

BiGgUn wrote: > Sorry if some lines are wrapped :( > > Changelog: > Implementing a default behavior for SPI_GETGRADIENTCAPTIONS flag in SystemParametersInfoA > > Stephan BEUZE > > You should not include the patch twice. The inline one is fine but the attached one is redundant and in the wrong format > ------=_NextPart_000_005A_01C2F178.B5916750 > Content-Type: text/plain; > name="sysparams.txt" > Content-Transfer-Encoding: quoted-printable > Content-Disposition: attachment; > filename="sysparams.txt" > > Index: windows/sysparams.c=0A= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= > RCS file: /home/wine/wine/windows/sysparams.c,v=0A= Since inlineing seems to work for you I would suggest you use that. (it is the prefered method). -- Tony Lambregts

1 0

#1336: Delete a read-only file says not found
by Sylvain Petreolle 23 Mar '03

23 Mar '03

Trying to delete a read only file with wcmd actually should fail, option is not yet implemented. But it fails abnormally : it says that the file isnt found. A first test is done to see if no handle can be obtained, it passes. If I enable the --debugmsg +file it returns a GLE 2 fault. (file not found). Comments ? ===== Sylvain Petreolle spetreolle(a)users.sourceforge.net Fight Spam ! EuroCauce: http://www.euro.cauce.org/en/index.html ICQ #170597259 "Don't think you are. Know you are." Morpheus, in "Matrix". ___________________________________________________________ Do You Yahoo!? -- Une adresse @yahoo.fr gratuite et en français ! Yahoo! Mail : http://fr.mail.yahoo.com

2 2

Re: PATCH: Implement some missing stuffs (reformated)
by Tony Lambregts 23 Mar '03

23 Mar '03

BigBun wrote: > Hi all. > [snip] > > Changelog: > Implementing a default behavior for SPI_GETGRADIENTCAPTIONS flag in > SystemParametersInfoA. > Adding call to TabCtrl_SetPadding in TAB_WindowProc. > > Index: dlls/comctl32/tab.c > =================================================================== > RCS file: /home/wine/wine/dlls/comctl32/tab.c,v > retrieving revision 1.78 > diff -u -r1.78 tab.c > --- dlls/comctl32/tab.c 17 Mar 2003 04:43:26 -0000 1.78 > +++ dlls/comctl32/tab.c 23 Mar 2003 08:52:10 -0000 > @@ -3075,7 +3075,7 @@ > return 0; > > case TCM_SETPADDING: > - FIXME("Unimplemented msg TCM_SETPADDING\n"); > + TabCtrl_SetPadding (hwnd, wParam, lParam); > return 0; > > case TCM_GETROWCOUNT: > Index: windows/sysparams.c > =================================================================== > RCS file: /home/wine/wine/windows/sysparams.c,v > retrieving revision 1.49 > diff -u -r1.49 sysparams.c > --- windows/sysparams.c 19 Feb 2003 22:04:46 -0000 1.49 > +++ windows/sysparams.c 23 Mar 2003 08:52:12 -0000 > @@ -1734,7 +1734,14 @@ > WINE_SPI_FIXME(SPI_SETCOMBOBOXANIMATION); /* 0x1005 _WIN32_WINNT >= > 0x500 || _WIN32_WINDOW > 0x400 */ > WINE_SPI_FIXME(SPI_GETLISTBOXSMOOTHSCROLLING);/* 0x1006 _WIN32_WINNT > >>= 0x500 || _WIN32_WINDOW > 0x400 */ > > WINE_SPI_FIXME(SPI_SETLISTBOXSMOOTHSCROLLING);/* 0x1007 _WIN32_WINNT > >>= 0x500 || _WIN32_WINDOW > 0x400 */ > > - WINE_SPI_FIXME(SPI_GETGRADIENTCAPTIONS); /* 0x1008 _WIN32_WINNT >= > 0x500 || _WIN32_WINDOW > 0x400 */ [snip] First off. Thank you for your attempt to contribute to the wine project. There are however some problems with your patch that need to be fixed. You have included two copies of the patch (one inline and one attached). Please only include one. Unfortunatly your inline version got line wrapped so it is turned to garbage. Outlook is not very frendly with with inlined patches and almost always wants to mangle them somehow. The attached one is not any better > Content-Type: application/octet-stream; > name="patch.diff" > Content-Transfer-Encoding: quoted-printable > Content-Disposition: attachment; > filename="patch.diff" Please see section 5.2.1 of the following link obout how to correct this. http://www.winehq.com/Docs/wine-devel/style-notes.shtml Giving the patch the extention .txt is the simplest way of fixing this problem and is acceptable to to all. > > ? out.txt=0A= > ? patch.diff=0A= > ? library/Makefile=0A= > ? library/libwine.so.1.0=0A= > ? ole/Makefile=0A= > ? unicode/Makefile=0A= > ? unicode/libwine_unicode.so.1.0=0A= Please clean up your patch or better yet specify the files you want diff'ed cvs diff -u dlls/comctrl32/tab.c windows/sysparams.c > patch.txt > Index: dlls/comctl32/tab.c=0A= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= > RCS file: /home/wine/wine/dlls/comctl32/tab.c,v=0A= > retrieving revision 1.78=0A= > diff -u -r1.78 tab.c=0A= > --- dlls/comctl32/tab.c 17 Mar 2003 04:43:26 -0000 1.78=0A= > +++ dlls/comctl32/tab.c 23 Mar 2003 08:52:10 -0000=0A= > @@ -3075,7 +3075,7 @@=0A= > return 0;=0A= > =0A= > case TCM_SETPADDING:=0A= > - FIXME("Unimplemented msg TCM_SETPADDING\n");=0A= > + TabCtrl_SetPadding (hwnd, wParam, lParam);=0A= > return 0;=0A= > =0A= [snip] > --- windows/win.c 14 Mar 2003 04:11:17 -0000 1.216=0A= > +++ windows/win.c 23 Mar 2003 08:52:13 -0000=0A= > @@ -2311,7 +2311,7 @@=0A= > =0A= > /* when window belongs to other process, don't send a message */=0A= > if (nMaxCount <=3D 0) return 0;=0A= > - get_server_window_text( hwnd, lpString, nMaxCount );=0A= > + get_server_window_text( hwnd, lpString, nMaxCount ); =0A= > return strlenW(lpString);=0A= > }=0A= > =0A= > Make sure your patch sure your patch is cleaned up (this is a NOOP and just makes the patch larger than nessarry) Please resubmit your patch in the proper format. -- Tony Lambregts

1 0

FW: Re: WineHQ Idea
by Brian Vincent (C) 23 Mar '03

23 Mar '03

> I think that, today, we do not have any of the news items > you describe. Your are imagining that Brian or Jeremy has more time to > repost pieces of the WWN to a different box. afaik, they don't. > > You say "we'll just snag pieces of Alexandres release notices". > Who's we? Well, it certainly wouldn't be a stretch for me to post news items. Generally I write the news section as items occur during the week. It's not like I sit down on Thursday night and bang out the whole WWN - all I do is run some scripts and mail it off. So yeah, I guess I'm volunteering for this. You'll just have to trust my judgement on what gets added and what doesn't. (Yeah, I'll be more liberal than I mentioned earlier.) It won't be complete duplication of WWN articles, though knowing the current state of development I'd guess there would be about 2 - 3 news items a week. My one request is Jeremy would have to write some kind of simple interface in order to get the items in there. I don't have reliable access to CVS or a shell acct at work, just web and email. I guess there's only three things that would need to be input: headline link to the real article / web page / press release short tagline (such as "WHAT'S NEW" for the releases) > Now, if we had a volunteer PR person that was coordinating and > driving PR for Wine, and *that person* wanted and was willing > to maintain and keep fresh such a section, then I would > be persuaded. right.. that wouldn't be me. Writing summaries, posting news is one thing, I'm not volunteering for anything more than that (right now...) --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

wine server and services ...
by Lars Segerlund 23 Mar '03

23 Mar '03

Would it not be possible to launch wineserver to handle NT services ? Thus if the user was logged in services would be running ( if he fx. had started wineserver in his .xsession file ). I do realise that there are issues such as privileges and multiuser, but this would circumvent them would it not ? I have looked at some of the other things people have written about services, but this looks doable. / regards, Lars Segerlund.

5 5

RE: WineHQ redesign - TODO
by Brian Vincent (C) 23 Mar '03

23 Mar '03

> That's a different issue. Of course, most of the items that you cover > (mainly threads of discussion in wine-devel) have no business > as News items. Right. I agree that WWN serves a completely different purpose than a News feed would. And I agree that a separate News feed would be useful. > it. And that > is as it should be, it's one thing to post a Headline news on > Monday saying > Mon Apr, 1: Wine 20030401 is out [link] > - kernel/ntdll separation complete That's a terrible example to use since Jeremy has done a great job of always having the latest CVS drop on the front page. If you're talking of consolidating the "Latest Release" and "News" headings, then I really don't care. I think one of the primary goals of WineHQ should be to put the software into the hands of users, and anything that makes that easier furthers the goal. Separating out the "Latest Release" and having two different download pages for "Binaries" and "Source" seems to do that. It definitely draws attention to getting the software. I think what you're getting at for news is we could (and should) announce things like: http://www.franksworld.net/wgm/ Hopefully in the future there will be more things like that. However, I'm definitely against announcing things like this: http://www.codeweavers.com/about/press_releases/?id=20030113 http://www.lindows.com/lindows_michaelsminutes_archives.php?id=4 http://www.xandros.com/release6.html None specifically mentions "Wine", however that's clearly behind their product. So at what point do you draw the line? Trust me, it's a pain in the ass to figure out. For WWN I'd rather err on the side of covering anything vaguely related to Wine, for the front page of WineHQ I don't think you want things like that, nor do you want to pick and choose what press releases get added. However, to confuse things, I think things like this definitely qualify as news: http://www.musicmatch.com/info/company/press/releases/?year=2001&release=2 So maybe here's the rule: if the primary business of your company is Wine development (TG, CW), or Wine is a core technology (Lindows.com) the most press you're going to get on WineHQ is from WWN. However, if you've utilized Wine to some how add value to a new or existing product then we'll announce it on the front page, at least the initial release. Just putting the word "Wine" in your press release doesn't count either way. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

3 3

Re: PATCH: Implement some missing stuffs (reformated)
by Eric Pouech 23 Mar '03

23 Mar '03

BigBun wrote: your reformating is wrong (the long lines are wrapped) > case TCM_SETPADDING: > - FIXME("Unimplemented msg TCM_SETPADDING\n"); > + TabCtrl_SetPadding (hwnd, wParam, lParam); > return 0; this is wrong... TabCtrl_SetPadding is defined as: #define TabCtrl_SetPadding(hwnd, cx, cy) \ (void)SNDMSGA((hwnd), TCM_SETPADDING, 0, MAKELPARAM(cx, cy)) so, this code will resend the TCM_SETPADDING while processing the TCM_SETPADDING > - get_server_window_text( hwnd, lpString, nMaxCount ); > + get_server_window_text( hwnd, lpString, nMaxCount ); you could also clean up your patch and remove the no op diffs A+ -- Eric Pouech

1 0