September 2003 - Wine-devel

Re: listview expert required (again)
by Dimitrie O. Paun 03 Sep '03

03 Sep '03

OK, Please give this a try -- it should fix it. Index: dlls/comctl32/listview.c =================================================================== RCS file: /var/cvs/wine/dlls/comctl32/listview.c,v retrieving revision 1.360 diff -u -r1.360 listview.c --- dlls/comctl32/listview.c 1 Sep 2003 23:55:33 -0000 1.360 +++ dlls/comctl32/listview.c 3 Sep 2003 15:32:36 -0000 @@ -5939,6 +5939,9 @@ if (nItem == -1) goto fail; infoPtr->nItemCount++; + /* shift indices first so they don't get tangled */ + LISTVIEW_ShiftIndices(infoPtr, nItem, 1); + /* set the item attributes */ if (lpLVItem->mask & (LVIF_GROUPID|LVIF_COLUMNS)) { @@ -5979,11 +5982,6 @@ } } - /* Add the subitem list to the items array. Do this last in case we go to - * fail during the above. - */ - LISTVIEW_ShiftIndices(infoPtr, nItem, 1); - /* send LVN_INSERTITEM notification */ ZeroMemory(&nmlv, sizeof(NMLISTVIEW)); nmlv.iItem = nItem; @@ -6008,6 +6006,7 @@ return nItem; undo: + LISTVIEW_ShiftIndices(infoPtr, nItem, -1); DPA_DeletePtr(infoPtr->hdpaItems, nItem); infoPtr->nItemCount--; fail: -- Dimi.

2 1

BUG in IPersistFile::Load() since Wine-20030618 !
by Subhobroto Sinha 03 Sep '03

03 Sep '03

This is a followup of my earlied post. Recap: I was porting my program which resolved Windows shortcut files (.lnk) using WineLib (Please note that this program runs flawlessly on Windows). It used to work fine till I updated my Wine source from 20030408 to 20030813. I posted this report here and Dimitrie suggested that I do a CVS Regression test to locate the error... Now, I really could NOT do a CVS regression test as I lack the bandwidth (you know, a 28KBps modem ..), but I started afresh with the Wine-20030408 source tree and "patch-compile-tested" to version 20030618. Then I found out that from this release onwards IPersistFile::Load() had become BROKEN ! Hence I have reason to believe that ANY code which modified/touched directly/indirectly IPersistFile::Load() and made it's way into Wine-20030618.diff.gz is AT FAULT ;) And that code needs to be FIXED. So ALL Wine releases prior to 20030618 can sucessfully run my program(or for that matter, ANY program that calls IPersistFile::Load()) , and ANY Wine release after 20030618 will fail ANY application that calls IPersistFile::Load() ! Just to show that not just my program is at fault, you can also try running Mike McCormack's WineMenuBuilder which also resolves Windows shortcuts... Until IPersistFile::Load() got broken, on running my program this is the ONLY message I used to get : "fixme:shell:IShellLinkA_fnResolve (0x4039da98)->(hwnd=(nil) flags=3)" The attached file "WineTraceLog.zip"<MD5 Sum: 278b4c4a44cc445b6c0e0d8863a790cf> contains the pertinent extract of the trace log when I run my program, please go through it to see what really is happenning. (While going through this extract you can see that the shortcut has been resolves sucessfully, but yet IPersistFile::Load() returns a failure ??) I hope this gets fixed allright ;) Please let me know if I can help in any way (EXCEPT learning COM!)... Regards Subhobroto Sinha __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com

1 0

Wanted to learn Wine Completely
by Sukumar .S 03 Sep '03

03 Sep '03

Dear Developers, I'm sukumar from Chennai, India. I've one requirement for my company for which there is a need to understand wine source fully (there is a time constraint). i was a windows developer moved to Linux two years back and have good/bit of knowledge on win32 system programming (win32 api calls)..! Me myself belive that i'm good in win32 common controls (each control (i.e listview,treeview,static,edit) message hanlding) and in windows message hooking. so far i've downloaded the wine source (Wine version 20020710) and compiled it and able to run the required target applications. I've gone through the documentations (wine-{devel,user,faq}), DEVELOPER-HINTS and navigated through src tree (controls,windows) to get the feel of the file names (api calls) and to look at the coding conventions. I'm looking forward from all of you to guide/help me to start learning/understanding wine starting from running the target application to exiting the application. To start with which part of the code that i've to read in wine and how do i proceed further...? Please help me. With Regards, S. Sukumar --

3 2

listview expert required (again)
by Eric Pouech 02 Sep '03

02 Sep '03

another bug description for listview (native listview works as expected here) configuration : - a listview in autoarrange mode - adding item one after the other - say the first item is created with the selection (LVIS_SELECTED) - some more items are inserted without the selection - in some cases, the selection will move to the newly inserted item instead of remaining on the first item (likely some internal index is not recalculated in autoarrange mode) A+ -- Eric Pouech

3 5

shlobj.h [final version]
by Martin Fuchs 02 Sep '03

02 Sep '03

On 02.09.2003 22:33:07 Martin Fuchs wrote: On 02.09.2003 22:07:16 Alexandre Julliard wrote: > Martin Fuchs <martin-fuchs(a)gmx.net> writes: > > > Changelog: > > * define interface IDragSourceHelper > > * define interface IDropTargetHelper > > They are already defined in wine/obj_dragdrophelper.h (fortunately > your definitions are in a #if _WIN32_IE so they are not used, > otherwise you would get a compile error ;-) Well, then there may be missing a '#include "wine/obj_dragdrophelper.h"' in shlobj.h ? Unfortunatelly I can't make any further Wine patches for the next time, because my internet access in Linux has died. ;-( Martin

1 0

Re: misc fixes in ole code
by Alexandre Julliard 02 Sep '03

02 Sep '03

Dave_Belanger(a)cimmetry.com writes: > 3. Call GetFullPathNameW on the input path before calling CreateFileW > in StgCreateDocfile and StgOpenStorage to ensure that CreateFileW > gets a DOS-style path. This shouldn't be necessary, CreateFileW is supposed to work on Unix path names too. I suspect this is a work around for an old bug that has been fixed since, could you please confirm that? -- Alexandre Julliard julliard(a)winehq.com

1 0

Re: shlobj.h [final version]
by Alexandre Julliard 02 Sep '03

02 Sep '03

Martin Fuchs <martin-fuchs(a)gmx.net> writes: > Changelog: > * define interface IDragSourceHelper > * define interface IDropTargetHelper They are already defined in wine/obj_dragdrophelper.h (fortunately your definitions are in a #if _WIN32_IE so they are not used, otherwise you would get a compile error ;-) -- Alexandre Julliard julliard(a)winehq.com

1 0

Resource .ani support
by flyker 02 Sep '03

02 Sep '03

resource.rc : ... /* for Modern Wait Cursor support */ IDC_CLOCK1 CURSOR "waitphar.ani" ... wrc error: Oops, segment violation When WineLib will support this ?

2 1

could someone please stabilise the list server?
by Geoff Thorpe 02 Sep '03

02 Sep '03

Hi there, I have filters for all the wine mail lists keyed against the List-Id header and this has been serving me well up until the last couple of days. However ... It seems that some of the lists now generate their headers with the winehq.org domain instead of winehq.com, but it seems (at least) wine-cvs is still using winehq.com. Could someone please standardise on what this is going to be? I don't particularly mind what it is, but it would help if it was consistent across all the lists and didn't change without warning. Cheers, Geoff -- Geoff Thorpe geoff(a)geoffthorpe.net http://www.geoffthorpe.net/

1 0

Ooops... wine-tests-results@winehq.org
by Jakob Eriksson 02 Sep '03

02 Sep '03

I forwarded the tests I have received so far to wine-tests-results(a)winehq.org, but at the time I was not yet subscribed... so it says they are awaiting moderation. Is anyone moderating that particular list? regards, Jakob

2 1