January 2004 - Wine-devel - list.winehq.org

exception outside of stack limits
by Robert Lunnon 11 Jan '04

11 Jan '04

There is a warning in signal_i368.c WARN( "exception outside of stack limits in thread %04lx eip %08lx esp %08lx stack %p-%p\n", GetCurrentThreadId(), EIP_sig(sigcontext), Can anyone tell me what this "means" in terms of what would have to go wrong to generate this warning ??

2 2

Correction to wineps spec file
by Vincent Béron 11 Jan '04

11 Jan '04

Changelog: CreateDC in wineps is Unicode now, change the spec file accordingly. Vincent

1 0

Re: [WINEALSA] Add Midi IN support
by Alexandre Julliard 11 Jan '04

11 Jan '04

Christian Costa <titan.costa(a)wanadoo.fr> writes: > + int npfd; > + struct pollfd *pfd; > + > + npfd = snd_seq_poll_descriptors_count(midiSeq, POLLIN); > + pfd = (struct pollfd *)alloca(npfd * sizeof(struct pollfd)); You should not use alloca in Wine, it's not portable enough. -- Alexandre Julliard julliard(a)winehq.com

4 3

Direct3D8 - OpenGL header problem
by Thomas Brix Larsen 11 Jan '04

11 Jan '04

Hi list, just upgraded to 2.6.0 and the NVIDIA driver from minion.de and now I get this error when compiling wine: directx.c: In function `IDirect3D8Impl_GetDeviceCaps': directx.c:639: `GL_MAX_VERTEX_UNITS_ARB' undeclared (first use in this function) My X11/include/GL/ headers date, 2001-2002. Greetings, --Thomas _________________ My worst enemy gave me a copy of Windows...

3 2

Re: shell32 patches to be usable by ReactOS Explorer
by Martin Fuchs 11 Jan '04

11 Jan '04

Sorry, I forgot to include the new file "shlcpanel.c" into the shell32 patch mail. Changelog: - Implementation of control panel folder in shgell namespace -- Martin Fuchs martin-fuchs(a)gmx.net

1 0

Build fails for current CVS update
by Sami Aario 11 Jan '04

11 Jan '04

Hi, Building with tools/wineinstall fails with the latest CVS update on my system with the following: gcc -c -I. -I. -I../../include -I../../include -I/usr/X11R6/include -D__WINE SRC__ -D_REENTRANT -fPIC -Wall -pipe -mpreferred-stack-boundary=2 -fno-stri ct-aliasing -gstabs+ -Wpointer-arith -g -O2 -o ddraw.spec.o ddraw.spec.c {standard input}: Assembler messages: {standard input}:654: Error: no such instruction: `yes "ddraw.dll"' {standard input}:655: Error: no such instruction: `yes "DDHAL32_VidMemAlloc"' {standard input}:656: Error: no such instruction: `yes "DDHAL32_VidMemFree"' {standard input}:657: Error: no such instruction: `yes "DDInternalLock"' and so on, lots more of the same. Anyone else getting these?

3 4

Re: bogus patch to bind() dlls/winsock/socket.c (request removal)
by Mike Hearn 11 Jan '04

11 Jan '04

That looks familiar. In fact, the TRACE was originally a FIXME but it caused so much spew with so many apps I changed it. I couldn't see exactly what needed to be fixed given the contents of the message - it seems to be simply informing us of progress, but it's a possibility somebody knew this wasn't correct. On Sat, 10 Jan 2004 17:09:52 -0600, Jeremy White wrote: > Index: dlls/winsock/socket.c > =================================================================== > RCS file: /home/wine/wine/dlls/winsock/socket.c,v > retrieving revision 1.144 > diff -u -r1.144 socket.c > --- dlls/winsock/socket.c 2 Jan 2004 20:12:00 -0000 1.144 > +++ dlls/winsock/socket.c 10 Jan 2004 22:56:57 -0000 > @@ -1302,10 +1302,6 @@ > else > { > int on = 1; > - /* The game GrandPrixLegends binds more than one time, > but does > - * not do a SO_REUSEADDR - Stevens says this is ok */ > - TRACE( "Setting WS_SO_REUSEADDR on socket before we > bind it\n"); > - WS_setsockopt( s, WS_SOL_SOCKET, WS_SO_REUSEADDR, > (char*)&on, sizeof(on) ); > > if (bind(fd, uaddr, uaddrlen) < 0) > {

2 1

bogus patch to bind() dlls/winsock/socket.c (request removal)
by Jeremy Shaw 10 Jan '04

10 Jan '04

As a result of this patch (which is currently applied in cvs head): http://www.winehq.com/hypermail/wine-patches/2002/12/0009.html WS_bind() currently does this before every call to bind(): WS_setsockopt( s, WS_SOL_SOCKET, WS_SO_REUSEADDR, (char*)&on, sizeof(on) ); Basically, it sets SO_REUSEADDR for every call to WS_bind(). I can't imagine this is the correct thing to do. According to MSDN, bind() should fail unless the program has explicitly set SO_REUSEADDR. See Error code WSAEADDRINUSE at: http://msdn.microsoft.com/library/default.asp?url=/library/en-us/winsock/wi… I found that this patch causes major problems with the xten sipphone client. The xten client does not explicitly set SO_REUSEADDR and depends on bind() failing if it tries to bind to the same local address/port twice. When the sipphone client needs a socket, it starts at port 8000, and calls bind() on successive ports until bind() returns success. So normally, if the program is already using port 8000, then bind() will fail and will try port 8001. However, with the above patch in place, bind() always works. So then the sipphone client will be using port 8000 twice, which the program is not designed to handle. If I remove the call to WS_setsockopt(), the xten sipphone client works correctly. I am proposing that the portion of the patch applied to WS_bind() be removed unless someone has a convincing arguement that the patch is actually valid. Jeremy Shaw.

2 1

WWN broken
by Brian Vincent (C) 10 Jan '04

10 Jan '04

> We scan the XMl with tidy before posting. What is odd is that tidy > reports the XML is valid, but yet PHP's XML parser barfs on it. Whatever > the case, I just patched it, so it should be fixed online soon. Whoops. Sorry about that. I was running out the door when I put it up. I did run it through tidy, but tidy kind of sucks. The only way to really catch things is to run it through xmllint. But xmllint has a terrible interface for finding malformed problems.. hence tidy. Thanks for fixing that. Also, if anyone is bored and wants to do something easy, it might be nice to change all references in the WWN issues from winehq.com to winehq.org. I've just recently switched over to trying to be consistent on the .org thing. There's about 200 issues that could be run through sed. --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

2 1

Re: dsound global variable use reduction
by Eric Pouech 10 Jan '04

10 Jan '04

Robert Reif a écrit : > Reduce the use of the dsound global variable by > passing address to functions. This is in preparation > of supporting multiple DirectSound devices. We can't > remove all uses because an mmtimer callback can be > called even after the timer is killed. Windows has an > mmtimer flag that prevents this but wine doesn't > implement it. Could you be more specific on this one ? timeKillEvent is not 100% thread safe (I'll send a patch later on), but timeKillEvent in Wine is always synchronous (ie the killer is killed when timeKillEvent returns).

2 3