January 2004 - Wine-devel - list.winehq.org

An MDI regression
by Duane Clark 26 Jan '04

26 Jan '04

A minor regression in the MDI code. I am not sure which patch it was, but it is something in the last couple of weeks. Open most any MDI application (I've tried 3) including Pegasus mail. Maximize one of the windows, and take a look at the menus. Even better, after doing that, drag the entire application to a different size. The effect is rather impressive.

2 1

Re: New Open Source License: Single Supplier Open Source License
by Ivan Leo Murray-Smith 25 Jan '04

25 Jan '04

> The problem with [L]GPL and BSD is that if someone does not turn in their changes then the developer has no recourse to > enforce the requirment. Under this license they can. > Under GPL and BSD the developer has absoutely no control or means to keep their work an open source because they > cannot remove distribution from people who don't comply. Sorry for the language but this is pure bullshit. The Free Software Foundation has enforced the GPL many times, forcing proprietary vendors to GPL the code of works deviated from GPL'ed code, and has always reached a settlement before getting to court, that shows how good the GPL is. > I am trying to make it possible for people to earn a living as Open Source developers. I am also making it possible for > companies that do Open Source development as their primary activiey to provide jobs to those (like those on this list) > who invest their time into Open Source products. IMHO you're quite confused, and don't have a good idea about what open source is all about. You license closely remembers the shared source license. Ivan.

2 1

Fwd: [Bug 1952] half-life, unreal tournament: video runs too 1.5x too fast
by hatky 25 Jan '04

25 Jan '04

Sound like a valid claim that wine does not update the cpu speed on speed step speed change.... ---------- Forwarded Message ---------- Subject: [Bug 1952] half-life, unreal tournament: video runs too 1.5x too fast Date: Saturday 24 January 2004 20:30 From: Wine Bugs <wine-bugs(a)winehq.org> To: wine-bugs(a)winehq.org http://bugs.winehq.org/show_bug.cgi?id=1952 lesha(a)netman.ru changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |UNCONFIRMED Resolution|FIXED | ------- Additional Comments From lesha(a)netman.ru 2004-24-01 14:30 ------- I finally know exactly what was going on. Someone knowledgeable needs to decide if this is a problem Wine should fix. My laptop has SpeedStep, and if you power it up without AC power, it will boot in 1200 Mhz, and /proc/cpuinfo will list 1200 mhz. Turning on AC power switches back to 1700Mhz (or manual acpi adjustments). However, /proc/cpuinfo reflects only 1200. Wine apparently uses CPU cycles for timing (IMO, a lousy idea). Thus, when I had gone through power up without AC, later switched to AC, Wine thinks that my Mhz rating is lower than it is, and I get a speed increase of 42%. If I now use ACPI to reconfigure as 1200 Mhz, I end up with normal speeds again. So, really, ACPI could be considered at fault for not updating cpuinfo. But maybe /proc/cpuinfo isn't even the right place to read this information. Or at least, maybe one shouldn't rely on reported MHz for timing. For instance, the native shooters (Prboom, Quake3) don't mind at all if I switch the CPU frequency mid-game. Opinions? -- Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. ------------------------------------------------------- -- Hatky. Hebrew tranlator of http://www.mandrakelinux.com/he/ Helper of http://www.phpnuke-israel.org Worshiper of http://www.winehq.org

1 0

Re: Winedbg: Parse symbols in libc, libpthread, etc
by Eric Pouech 25 Jan '04

25 Jan '04

Robert Shearman a écrit : > Hi, > > This patch allows winedbg to parse symbols in libraries directly linked > to the wine binaries, like libc and libpthread. This will usually mean > just using the symbol table, but this is better than nothing. Hi Robert I don't understand why you need to walk the shared object (from lm.l_ld)? Normally, all loaded shared object will appear in the main module loaded linked list, so we should only need to walk that list. The rest of the patch is correct (I'm currently working on fixing some of the issues of the debugger: get around WINELOADER issue, report unsupported debug format (like Dwarf2...)). A+

2 2

Re: shell32 patch 20
by Rolf Kalbermatter 25 Jan '04

25 Jan '04

"Dmitry Timoshkov" <dmitry(a)baikal.ru> >"Martin Fuchs" <martin-fuchs(a)gmx.net> wrote: > >> > > Changelog: >> > > - don't link directly to NTDLL; use MultiByteToWideChar() instead of >> > RtlCreateUnicodeStringFromAsciiz() >> > >> > Why do you need that? >> >> RtlCreateUnicodeStringFromAsciiz() is neither present in MinGW nor in PSDK. > >That doesn't justify the change IMO. There are lots of places in Wine >using that construct, and it's much more convenient and avoids code >duplication (with a possibility of adding bugs in even such a simple >case). I was under the impression that it was desirable to cross compile as many dlls as possible in different environments. shell32 has currently only a few reasons why it can't be compiled and linked in Visual C and I think it is a good idea to improve on that. This of course isn't any reason but maybe an indication: native shell32 does not import RtlCreateUnicodeStringFromAsciiz() either. Rolf Kalbermatter CIT Engineering Nederland BV tel: +31 (070) 415 9190 Treubstraat 7H fax: +31 (070) 415 9191 2288 EG Rijswijk http://www.citengineering.com Netherlands mailto:rolf.kalbermatter(a)citeng.com

3 4

New Open Source License: Single Supplier Open Source License
by Richard Schilling 25 Jan '04

25 Jan '04

I would like to present to you all a new Open Source software license I've written up. It's called the Single Supplier Open Source License. I will be distributing software under this license as well as the traditional Open Source licenses found at opensource.org. You can see a copy of the license and its associated FAQ at http://www.rsmba.biz/licenses . A link on the homepage at rsmba.biz will also direct you there. I will also be working directly with opensource.org to address any issues they have with the license wording. The license has the following features: # Users have freely available access to source code, documentation just like the GPL. # Users may use, modify, and install the software on as many computers as they want within their organization. # Any changes made by the user and others get contributed back into the base product # The developer's right to control who provides services using the product is protected. # The developer's right to control who can distribute the software is protected. # The developer has complete control over the product forking. # The developer and all contributors retain copyright of their individual works. # The software is always downloaded from the same place by the end user even if it's used as part of a larger product, protecting the quality of the software. Please feel free to contact me on or off list about this announcement. Richard Schilling

5 8

Re: New Open Source License: Single Supplier Open Source License
by Brian Vincent (C) 25 Jan '04

25 Jan '04

Please take the discussion over to wine-license @ winehq.com --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

1 0

Re: INI File Processing Improvements
by Dmitry Timoshkov 25 Jan '04

25 Jan '04

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> wrote: > Changelog: > - Use Win32 instead of Unix file functions > - Process files fully in Unicode > - Add Unicode file detection Further concerns: 1. You are duplicating too much unicode helpers already existing in wine_unicode and include/wine/unicode.h 2. Are you sure that Windows supports unicode .ini files at all? -- Dmitry.

2 4

Re: INI File Processing Improvements
by Dmitry Timoshkov 25 Jan '04

25 Jan '04

"Robert Shearman" <R.J.Shearman(a)warwick.ac.uk> wrote: > - Add Unicode file detection > +static inline ENCODING PROFILE_DetectTextEncoding(const void * buffer) > +{ > + if (!memcmp(buffer, bom_utf8, sizeof(bom_utf8)/sizeof(bom_utf8[0]))) > + return ENCODING_UTF8; > + if (*(WCHAR*)buffer == BOM_UTF16LE) > + return ENCODING_UTF16LE; > + if (*(WCHAR*)buffer == BOM_UTF16BE) > + return ENCODING_UTF16BE; > + if (*(DWORD*)buffer == BOM_UTF32LE) > + return ENCODING_UTF32LE; > + if (*(DWORD*)buffer == BOM_UTF32BE) > + return ENCODING_UTF32BE; > + return ENCODING_ANSI; > +} Why not simply use IsTextUnicode/RtlIsTextUnicode and fix it if necessary? -- Dmitry.

2 4

Re: uxtheme Prevent segfault if no theme is set
by Robert Shearman 25 Jan '04

25 Jan '04

> > This follows the same lines, in some cases > MSSTYLES_SetActiveTheme would return success when in fact it failed > Apply on top of Vitaliy's patch > > Changelog: > Ensure MSSTYLES_SetActiveTheme fails when theme fails to load ... > invalid_theme: > if(hTheme) FreeLibrary(hTheme); > - if(!hr) hr = HRESULT_FROM_WIN32(GetLastError()); > + if(SUCCEEDED(hr)) hr = HRESULT_FROM_WIN32(GetLastError()); > + if(SUCCEEDED(hr)) hr = E_FAIL; > return hr; You shouldn't be doing this in the first place. As you have seen, at best you will set hr to a random error and at worst it won't be set at all and you need your hack to make it still work. What you should be doing is setting hr to the correct error as soon as you detect a failure. So after a Win32 call: if (callfailed) { hr = HRESULT_FROM_WIN32(GetLastError()); goto invalid_theme; } or after another type of failure: if (somethingnotquiteright) { hr = E_FAIL; goto invalid_theme; } Also, please try to use a more descriptive code than E_FAIL if one exists. Rob

1 0