October 2004 - Wine-devel - list.winehq.org

'make check' hangs after crash in msvcrt/tests?
by Dan Kegel 12 Oct '04

12 Oct '04

With this morning's cvs, 'make check' hangs after this point ... make[3]: Entering directory `/home/dank/winebuild/dlls/msvcrt/tests' ../../../../wine/tools/runtest -q -P wine -M msvcrt.dll -T ../../.. -p msvcrt_test.exe.so ../../../../wine/dlls/msvcrt/tests/cpp.c && touch cpp.ok fixme:msvcrt:__unDNameEx ((nil),.?AVtest1@@,0,0x40809010,0x40808fcc,(nil),2800) stub! wine: Unhandled exception (thread 005e), starting debugger... Usage: winedbg [--auto] [--gdb] cmdline Sounds like it's invoking winedbg wrong? Also, is there a way to say "I'm running these tests unattended, please don't wait for input"? - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

2 1

cvs update mystery
by Dan Kegel 12 Oct '04

12 Oct '04

Last night I did a cvs update and built, and got a build failure dlls/amstream/amstream.c:40: parse error before "AM_Vtbl" Evidently cvs update failed to update the files in dlls/amstream, as it failed to pick up that part of this change: 2004-08-12 Alexandre Julliard <julliard(a)winehq.com> * dlls/amstream/amstream.c, dlls/amstream/main.c, dlls/avifil32/acmstream.c, dlls/avifil32/avifile.c, ... dlls/winmm/wineaudioio/audio.c, dlls/winmm/wineoss/audio.c, include/objbase.h, include/rpcproxy.h: Get rid of the non-standard ICOM_VTABLE macro. Repeated 'cvs update's didn't fix it. cd'ing into dlls/amstream and doing a cvs update directly in that directory worked, though, and got me new versions of the files in that directory. How strange. Maybe I'll stop using this newfangled cvs system and fall back on the old reliable ... uh, wait, cvs *is* the old reliable one... grr... - Dan -- My technical stuff: http://kegel.com My politics: see http://www.misleader.org for examples of why I'm for regime change

3 2

Re: Added DWebBrowserEvents and WebBrowser declaration
by Robert Shearman 12 Oct '04

12 Oct '04

Jacek Caban wrote: > Changelog: > - Added dispinterfaces: DWebBrowserEvents and DWebBrowserEvents2 > - Added coclass: WebBrowser > - Added exdispid.h > You forgot the patch. Rob

1 0

COM inheritence
by Ann and Jason Edmeades 12 Oct '04

12 Oct '04

Hiya, If you havent noticed, I'm trying to port the d3d8 code into wined3d and make it common for use from d3d9, and this is all COM objects. I have come across something which in theory would enable me to tidy my code simply, but I cant see how to make it work in C. Now I have a class, for example FRED who implements some common functions, and all the code for it would be in fred.c. I also have a subclass, defined called JIM, which needs to have entrypoints as per fred, plus some more, and its code resides in jim.c. Still with me...? Now previously, inside jim, I have duplicated all the common functions, but I want to avoid this and just call the one definition. My plan was to change the Vtbl to look like: IJimVtbl Jim_Vtbl = { IJimImpl_QueryInterface, IJimImpl_AddRef, IJimImpl_Release, IFredImpl_CommonFunc1, IFredImpl_CommonFunc2, : IJimImpl_UniqueFunc1 etc } I was also ensuring the variable definitions in the IJimImpl structure map precisely over the IFredImpl structure, before any unique variables are defined (I think this is a necessity for emulating subclassing in C?). Now, obviously if the common funcs need changing I can copy in the code, and change the vtbl to have a local override but at the moment I dont need to (they are mostly stubs even in the d3d8 code today). However, doing this fails to compile - It wont allow me to have a vtbl in jim.c which includes pointers to functions which are in fred.c, even if I have extern prototypes defined. Basically this is because array initialization requires constant values. However, this would seem something which is so common - ie inheritence is used all over the place. How do people handle this? I've looked through a few places in the code and cant see how this can be done. I could 'pretend' by initializing the Vtbl as I create the com object and do some LoadLibrary type dynamic addressing but I really want link time resolution not load time resolution. One solution would be to put the common routines in a header file, and #include it, but code in headers or #including modules is uaually frowned upon! I cant see any sensible way of doing this and I'd rather not do lots of code duplication if avoidable as this common class is used in about 7 other classes! Jason

2 3

Re: Fix for bug 824 - proper handling of REG_MULTI_SZ
by Dimitrie O. Paun 12 Oct '04

12 Oct '04

> * - the modification time optionally follows the key name > - * - REG_EXPAND_SZ and REG_MULTI_SZ are saved as strings instead of hex > + * - REG_EXPAND_SZ are saved as strings instead of hex > + * - REG_MULTI_SZ are saved hex (as of 10/10/04 -- see Bug 824) > */ Well, I don't know if the fix is correct, but if it is, just remove the comment instead of saying it's fixed, otherwise we risk cluttering the real issues to the point where they are useless. -- Dimi.

1 0

Re: Fix for bug 824 - proper handling of REG_MULTI_SZ
by Chris Morgan 12 Oct '04

12 Oct '04

It would be useful to roll this test into the integrated winetests so we can check this behavior on all windows platforms and prevent it from breaking in the future. Chris > > From: Randy Galbraith <randy.galbraith(a)cox.net> > Date: 2004/10/11 Mon PM 09:19:42 EDT > To: wine-patches(a)winehq.org > Subject: Fix for bug 824 - proper handling of REG_MULTI_SZ > > This proposed patch addresses the concern raised by bug 824. This patch > changes the handling of REG_MULTI_SZ from REG_SZ to REG_BINARY. For > more details follow this URL: > > http://bugs.winehq.org/show_bug.cgi?id=824 > > To see a test program follow this URL: > > http://members.cox.net/~rgalbraith10/wine/bug824/demo824.c > http://members.cox.net/~rgalbraith10/wine/bug824/Makefile > > ===begin diff -u output of wine/server/registry.c 1.60=== > --- registry.c- 2004-10-10 10:46:15.000000000 -0700 > +++ registry.c 2004-10-10 12:26:35.000000000 -0700 > @@ -157,7 +157,8 @@ > * - strings and key names can contain \x escapes for Unicode > * - key names use escapes too in order to support Unicode > * - the modification time optionally follows the key name > - * - REG_EXPAND_SZ and REG_MULTI_SZ are saved as strings instead of hex > + * - REG_EXPAND_SZ are saved as strings instead of hex > + * - REG_MULTI_SZ are saved hex (as of 10/10/04 -- see Bug 824) > */ > > > static inline char to_hex( char ch ) > @@ -195,7 +196,6 @@ > { > case REG_SZ: > case REG_EXPAND_SZ: > - case REG_MULTI_SZ: > if (value->type != REG_SZ) fprintf( f, "str(%d):", value->type ); > fputc( '\"', f ); > if (value->data) dump_strW( (WCHAR *)value->data, value->len / > sizeof(WCHAR), f, "\"\"" ); > @@ -1123,7 +1123,7 @@ > { "\"", 1, REG_SZ, REG_SZ }, > { "str:\"", 5, REG_SZ, REG_SZ }, > { "str(2):\"", 8, REG_EXPAND_SZ, REG_SZ }, > - { "str(7):\"", 8, REG_MULTI_SZ, REG_SZ }, > + { "hex(7):", 8, REG_MULTI_SZ, REG_BINARY }, > { "hex:", 4, REG_BINARY, REG_BINARY }, > { "dword:", 6, REG_DWORD, REG_DWORD }, > { "hex(", 4, -1, REG_BINARY }, > ===end diff -u output=== > This is my first attempt at creating a patch for wine. Any feedback is > greatly appreciated. > > Kind regards, > -Randy Galbraith > > >

1 0

winetest fails enumerating test files
by Saulius Krasuckas 12 Oct '04

12 Oct '04

It shows some message-box telling: "Can't enumerate test files: 1813" Greping programs/winetest/main.c gives: | report (R_STATUS, "Counting tests"); | if (!EnumResourceNames (NULL, MAKEINTRESOURCE(TESTRES), | EnumTestFileProc, (LPARAM)&nr_of_files)) | report (R_FATAL, "Can't enumerate test files: %d", | GetLastError ()); | wine_tests = xmalloc (nr_of_files * sizeof wine_tests[0]); I guess this may be some regression (have been running winetest a whole month ago last time). Am I alone with this?

2 3

Re: wineserver contexts for Alpha
by Steven Edwards 12 Oct '04

12 Oct '04

Hi, --- Vincent B�ron <vberon(a)mecano.gme.usherb.ca> wrote: > There are two definitions of _CONTEXT for Alpha in winnt.h: one > protected by __ALPHA__ (added by Steven 2 years ago), and one > protected > by _ALPHA_, which is the same kind of protection as MSVC. Should we > dump > the __ALPHA__ one and change configure to define _ALPHA_ instead? Yes sorry dump the one I added. I totally missed it and did not have MSVC+PSDK installed then. Thanks Steven _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

1 0

tchar.h
by Martin Fuchs 11 Oct '04

11 Oct '04

Hello, can anyone explain to me, what's the exact reason for the following error message in wine/include/tchar.h: #if defined(_UNICODE) || defined(_MBCS) #error You must use msvcrt when building in Unicode/MBCS mode #endif It disallows inclusion of this <tchar.h> header file when using the _UNICODE define. Just a few lines later in this file there are the following definitions: /***************************************************************************** * tchar mappings */ #ifndef _UNICODE # ifndef _MBCS # include <string.h> # define WINE_tchar_routine(std,mbcs,unicode) std # else # include <mbstring.h> # define WINE_tchar_routine(std,mbcs,unicode) mbcs # endif #else /* _UNICODE */ # include <wchar.h> # define WINE_tchar_routine(std,mbcs,unicode) unicode #endif Again asking for "_UNICODE" ! So something can't be right with this. The <tchar.h> header should really define constants like _tcschr dependend on the _UNICODE define. But currently this doesn't work because of the error message described above. Either there should be a overriding "wine/include/msvcrt/tchar.h" file with different defintions. Or the error message "You must use msvcrt when building in Unicode/MBCS mode" is simply superfluous. Regards, Martin

2 1

Re: [Bug 2388] WM_NEXTDLGCTL changes the default button ID and does not restore default control identifier
by Alexandre Julliard 11 Oct '04

11 Oct '04

Katia Maculan <katia.maculan(a)isis-papyrus.com> writes: > part of the patch is not committed, is there a reason for that? Is > something wrong? It doesn't look right at all to do dialog management in the button code itself. Also, please submit a regression test showing that the proposed change is correct and that the current code is wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0