October 2004 - Wine-devel - list.winehq.org

Re: Re: Problems downloading the RedHat Packages.
by gslink 26 Oct '04

26 Oct '04

I downloaded the Oct. Package from Heanet and got garbage. This isn't surprising if it is not there.

1 0

Wine for Solaris 2.8 assembler problems
by Doug 26 Oct '04

26 Oct '04

I am trying to compile Wine for Solaris to get MCS working for mono. However there are problems getting Wine to work on Solaris 2.8. When first compiling wine, I was thought the errors were caused by using the assembler for Solaris so I changed the as (assembler) to the GNU version. Now I get the following errors. Any ideas of how to fix this? I have heard people getting mono to work on Solaris 2.8 so from what I know it is possible to get Wine working. gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DBINDIR="\"/usr/l ocal/bin\"" -DDLLDIR="\"/usr/local/lib/wine\"" -D_REENTRANT -fPIC -Wall -pipe -f no-strict-aliasing -gstabs+ -Wpointer-arith -g -O2 -o port.o port.c {standard input}: Assembler messages: {standard input}:1162: Error: ignoring unrecognized symbol type "" {standard input}:1162: Error: Rest of line ignored. First ignored character is ` 2'.

1 0

Re: rsaenh [beware: 27kB attachment]
by Juan Lang 26 Oct '04

26 Oct '04

Hi Michael, some very brief feedback: 1. MD4, MD5, and SHA1 are now implemented in wine's advapi32. Please use these instead of OpenSSL's. 2. The regression tests should be written so they don't fail if OpenSSL isn't available. 3. Get rid of magic numbers: What do the values 0x36 and 0x5c mean in copy_hmac_info? What is the length 64? Finally, some stylistic nits: 4. Please break long lines. 5. In some of the files you have the incorrect filename in the comments, e.g. dlls/rsabase/handle.c, dlls/rsabse/handle.h 6. Your indentation in some places is inconsistent; you mix spaces and tabs, and that makes it hard for me to guess the appropriate tab size. __________________________________ Do you Yahoo!? Yahoo! Mail Address AutoComplete - You start. We finish. http://promotions.yahoo.com/new_mail

3 2

Functions For Helping FillRect
by William Poetra Yoga H 26 Oct '04

26 Oct '04

FillRect is used in many places for drawing the GUI. But one thing I think many developers miss is that it doesn't fill the right and bottom borders of the rectangle, very much like LineTo doesn't draw the destination point (as per the MSDN docs). But when handling RECT structures we usually think about the objects, not how the objects are going to be painted on-screen. For example, if we wanted to draw a red rectangle at (10,10) with width of 50 pixels and height of 75 pixels, we do (assuming hdc and hbr is already set correctly): RECT r; r.left = 10; r.top = 10; r.right = r.left + 50; r.bottom = r.top + 75; FillRect(hdc, &r, hbr); This _will_ draw it all right, but there are conceptual errors: 1. The rectangle that we have here is not 50x75, but actually 51x76. But FillRect doesn't fill the right and bottom borders, so it appears correctly. 2. If we thought that FillRect fills the whole rectangle, then actually the above code doesn't do what we want; it should actually draw a 51x76 rectangle. So I think we have to make helper functions: RECT ToFill(RECT r) { ++r.right; ++r.bottom; return r; } RECT ToFillLP(LPRECT lpr) { RECT r = *lpr; return ToFill(r); } LPRECT LPToFill(RECT r) { ++r.right; ++r.bottom; return &r; } LPRECT LPToFillLP(LPRECT lpr) { RECT r = *lpr; return LPToFill(r); } So that: 1. Drawing with FillRect will be correct. 2. We can forget about FillRect's peculiar way of doing things. 3. We can concentrate on the actual rectangles. So instead of the above code, we do: RECT r; r.left = 10; r.top = 10; r.right = r.left + 50 - 1; r.bottom = r.top + 75 - 1; FillRect(hdc, LPToFill(r), hbr); What do you all think? Anyway, for LineTo we can just add "+ 1" at the arguments, no need for a helper function. __________________________________ Do you Yahoo!? Take Yahoo! Mail with you! Get it on your mobile phone. http://mobile.yahoo.com/maildemo

4 9

Re: wine/dlls/user button.c
by Dimitrie O. Paun 26 Oct '04

26 Oct '04

> The thing is that the old code wasn't entirely correct too. > Here is a test case + fix. Thanks a lot Dmitry, I got carried away with some other stuff. -- Dimi.

1 0

Problems downloading the RedHat packages
by Bill Medland 26 Oct '04

26 Oct '04

I am unable to download the RedHat 20041019 packages; any idea why? (Did they get built?) I can download a SuSE one (well, it at least asks me if I want to save it) but for all the Red Hat ones I've tried the mirror page keeps repeatedly coming up and it never actually tries to download. -- Bill Medland mailto:billmedland(a)mercuryspeed.com http://webhome.idirect.com/~kbmed

3 2

Re: unaligned access bug in winspool on sparc
by Juan Lang 26 Oct '04

26 Oct '04

> I just ran across an evil little bug in the > WINSPOOL_GetPrinter_2 function. It looks like this > type of bug could be hiding in other API functions > too. It causes a segmentation fault because of an > unaligned access on Solaris (sparc). Yikes. That's a bad one. The trouble is MS loves this sort of return value. Even if the dll itself doesn't dereference an unaligned pointer, the caller might depending on how things are layed out. The trouble is i386 allows unaligned memory access, so we don't see this sort of thing. If you happen to know how MS handles alignment on platforms that require it, we might be able to fix it. Otherwise it'll have to be case-by-case I'm afraid. --Juan _______________________________ Do you Yahoo!? Declare Yourself - Register online to vote today! http://vote.yahoo.com

4 4

Re: wine/dlls/user button.c
by Mike McCormack 25 Oct '04

25 Oct '04

Hi Dimi, The following hunk of the patch below breaks the IE install. You should be able to press Alt-A to accept the license in the first dialog, but with this hunk applied it no longer works. Mike Index: wine/dlls/user/button.c diff -u wine/dlls/user/button.c:1.2 wine/dlls/user/button.c:1.3 --- wine/dlls/user/button.c:1.2 Thu Oct 21 11:18:35 2004 +++ wine/dlls/user/button.c Thu Oct 21 11:18:35 2004 @@ -179,10 +224,13 @@ case WM_GETDLGCODE: switch(btn_type) { - case BS_PUSHBUTTON: return DLGC_BUTTON | DLGC_UNDEFPUSHBUTTON; - case BS_DEFPUSHBUTTON: return DLGC_BUTTON | DLGC_DEFPUSHBUTTON; - case BS_RADIOBUTTON: - case BS_AUTORADIOBUTTON: return DLGC_BUTTON | DLGC_RADIOBUTTON; + case BS_AUTOCHECKBOX: return DLGC_BUTTON | DLGC_WANTCHARS; + case BS_AUTORADIOBUTTON: return DLGC_RADIOBUTTON; + case BS_CHECKBOX: return DLGC_BUTTON | DLGC_WANTCHARS; + case BS_DEFPUSHBUTTON: return DLGC_DEFPUSHBUTTON; + case BS_GROUPBOX: return DLGC_STATIC; + case BS_PUSHBUTTON: return DLGC_UNDEFPUSHBUTTON; + case BS_RADIOBUTTON: return DLGC_RADIOBUTTON; default: return DLGC_BUTTON; } Alexandre Julliard wrote: > ChangeSet ID: 14031 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/10/04 23:11:13 > > Modified files: > dlls/user : button.c > > Log message: > Dimitrie O. Paun <dpaun(a)rogers.com> > Audit and document button code. > Change [GS]etWindowLong{,Ptr}A to [GS]etWindowLong{,Ptr}W. > Change WM_GETDLGCODE as per the MSDN documentation. > > Patch: http://cvs.winehq.org/patch.py?id=14031 > > Old revision New revision Changes Path > 1.2 1.3 +74 -26 wine/dlls/user/button.c > >

2 1

rsaenh [beware: 27kB attachment]
by Michael Jung 25 Oct '04

25 Oct '04

Hello, I've worked on an OpenSSL based implementation of rsaenh.dll in my spare time over the last three months. Although it is by no means complete, I feel that the coarse structure should be stable by now. The patch is appended to this mail as a gzipped tape archive. I'm aware that small patches are preferable, but I hope someone helps me to get this beast in: Please give me feedback on what remains to be done. If you want to try the patch note the following: - After you have applied the patch you have to run autoheader and autoconf. Then cd dlls ; make_dlls ; cd .. ; configure. - After you have compiled and installed wine, you have to unregister rsabase and register rsaenh (regsvr32 /U rsabase ; regsvr32 rsaenh). rsaenh.dll is meant to replace rsabase.dll sometime (Windows XP also has rsaenh.dll only). - This patch was tested with the attached regression tests and with some MSDN example code. No real application was tested until now. - This code is not secure! The user's persistent private RSA signature and key exchange key pairs are stored in the registry in _plaintext_. Do not use this with your homebanking application ;) - The code depends on CUR_BLOB_VERSION being defined in wincrypt.h. This is implemented in a distinct trivial patch, which I've submitted this morning and which will probably go into CVS tonight (that is if you live in germany ;) - You ain't see a whole lot, if you don't have the openssl headers installed (libssl-dev on debian). The code will compile without, but you'll get a lot of FIXME's and some of the regression tests will fail. Please excuse me for posting a 30kB message. Greetings, Michael

1 0

Problems With MSI
by Joaquín Fernández 25 Oct '04

25 Oct '04

Hello... i am having problems installing program with MSI Installer. When i launch setup.exe, the installer begin the process and when finish of copy files (progress bar is 100%), stay in endless loop. I ran serveral programs using MSI installer but nothing, all hangs at end of copy files. I tested it with WINEDLLOVERRIDES="msi,msiexec.exe=n" too but is equal. Some dll override or other thing? Regards Joaquín P.D.: Wine 20040914 & Mandrake Linux 10.1 Community -- -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.2.4 (GNU/Linux) mQFCBEFI/gARAwDd2+ojasT3rCyRktSw+Ix3m+yoxSD0NkpMLlunmJxwvn6wKZVl mDw76/Zu9mqDWWeSGdSl+60T7fDLrJZSEB45O9T5jdujj01GFeer7xuiuHBTFw8o CXqD/hzhqYc46ecAoIQQjZ2qZtOWLPRBbegK/nyOIguNAv9QGiKPLBS8o0ksxEUp EfLAExVmu6Zp693uKGf6XrBWNcLriuwRPr1mjy3N/bhMlqc3vcTeUBwxiUuX5h2P NQgB3d2AbJS6oEvhmZL0Bn/8Ij/MSvVrartmCXuw9eSx0aMC/R7Kw9TtUfxFVUGx fQKwoA9BXNElPLcNohbBS/fH87IMMxCJyn+rmTeNCEcUEQ7UgvVCdlzZ8+L4PdlH qGR81nhZVEwPRnSSesLpSHRC1QQVoceBeb7PICr/b2eZiKMX+bQ+Sm9hcXXDrW4g TWFudWVsIEZlcm7DoW5kZXogUXVpbGVzIDxqb2FxdWluQGNhc2FkZWFsYWJhbnph Lm9yZz6IXgQTEQIAHgUCQUj+AAIbAwYLCQgHAwIDFQIDAxYCAQIeAQIXgAAKCRBH 677/q7xL4e15AJwNfSpeaXXMH2EjuKblfeBe51MrUgCcCP5jEnpXrDXLWULIW5yD t6VdHlU= =a8BM -----END PGP PUBLIC KEY BLOCK-----

1 0