November 2004 - Wine-devel - list.winehq.org

Re: systray rewrite part 2
by Grant Williamson 02 Dec '04

02 Dec '04

Mike, ok the rewrite, applies & compiles cleanly on 20041019, however, running SIP Phone-lite, it does not show on the systray, the older patch did. I am running gnome-2.8 on rhel4, what program do you want us to test with it. Mike Hearn wrote: >Clearly, I need to figure out a system for generating patches. This time >with (hopefully) all the files in the patch. > >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > >------------------------------------------------------------------------ > > > >

2 3

SHBrowseForFolder
by Robert van Herk 02 Dec '04

02 Dec '04

Hi all, I am trying to implement the Browse button in the winecfg application, that would allow people to browse for a directory to use as their virtual c drive. In order to do so, I though I'd use the SHBrowseForFolder function from shlobj.h (see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…) However, when I tried this in Wine, I get a compiler warning: In driveui.c I did: case IDC_BUTTON_BROWSE_PATH: SHBrowseForFolder(0); //MessageBox(dialog, "", "Write me!", MB_OK); break; Then, at compile time I get: driveui.c:589: warning: undefined reference to `SHBrowseForFolderA' I made sure that there is a line that says: #include <shlobj.h> When I try to launch the app, I get ./winecfg wine: could not load L"Z:\\home\\robert\\Documents\\devel\\wine\\programs\\winecfg\\winecfg.exe.so": /home/robert/.wine/dosdevices/z:/home/robert/Documents/devel/wine/programs/winecfg/winecfg.exe.so: undefined symbol: SHBrowseForFolderA Does this mean that the SHBrowseForFolder thing is not implemented? Probably it is, because I checked Wine's shlobj.h. What am I doing wrong? Thanks, Robert

9 33

Re: Implement GetLayout
by Shachar Shemesh 02 Dec '04

02 Dec '04

Rémi Assailly wrote: > Shachar Shemesh wrote : > >> Thanks for spotting another one for my growing heap of BiDi TODOs.... >> >> http://bugs.winehq.org/show_bug.cgi?id=2584 >> >> Shachar >> > I know that there is no effect... I'm sorry if I came off cynical. There was no cynicism in that comment. I opened 2584 as a result of seeing your patch. I was not aware of this particular missing functionality. I'm aiming for http://bugs.winehq.org/show_bug.cgi?id=609 to be the ultimate documentation of all BiDi APIs in Windows. Opening 2584 is a good thing, as it documents things that are still to be done. > What is wrong ? It seems that this flag reverses the meaning of several common conventions (left/right etc.). The idea is probably so that applications that are natively right to left not have to change their design too much. I can't tell you exactly what it means, however, as I don't know myself. It will probably be a matter of comparing behaviors to the real Windows. I have some doubts about whether anyone is even using this flag at all. Maybe on localized Hebrew Windows, where the whole window decorations are reversed (Ughh. My GF has localized XP Home installed. This thing is horrible, but I didn't spot any non-Windows native applications that were affected by it). > Tell me and I will help you, if you want... I'll gladly accept all the help I can get. Basically, this particular unimplemented bit requires writing small test programs on Windows, and then running them on Wine until they produce the same results. The idea is that you read the MSDN page for the function (linked from the bug). That page also links to http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/wi…, which gives more details on what this flag is supposed to mean. If you check out 2584 again, you will see I added this new information there. The steps one takes is to read all the relevant manuals, and try to understand what this means. Next, you write a small test program that does stuff with and without this flag, showing where this flag takes effect on Windows. Next, you move this test program to Wine and start tweaking Wine until it behaves the same there. There is also a last step, which is to make this program into a test suite, returning success or failure. I'm not sure, however, how that is supposed to be done for programs where success and failure are measured with graphical output. Hope this helps you help me help everyone..... :-) Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: gdi/mfdrv BS_PATTERN brushes
by Huw D M Davies 01 Dec '04

01 Dec '04

On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > problem. With this patch BS_PATTERN brushes get created correctly and > don't cause a locking problem. > > Changelog: > Fix creation of BS_PATTERN brushes in mfdrv > > > Index: dlls/gdi/mfdrv/objects.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v > retrieving revision 1.14 > diff -u -r1.14 objects.c > --- dlls/gdi/mfdrv/objects.c 22 Nov 2004 18:19:59 -0000 1.14 > +++ dlls/gdi/mfdrv/objects.c 30 Nov 2004 06:10:03 -0000 > - mr->rdFunction = META_DIBCREATEPATTERNBRUSH; > + mr->rdFunction = META_CREATEPATTERNBRUSH; Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record under Windows? Huw. -- Huw Davies huw(a)codeweavers.com

2 1

which classes support aggregation?
by James Hawkins 01 Dec '04

01 Dec '04

IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation? -- James Hawkins

3 2

implementing DllCanUnloadNow questions
by James Hawkins 01 Dec '04

01 Dec '04

I sent this message a couple months ago, but I got no response so I'll try again. I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the same as this example? static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { IClassFactoryImpl *This = (IClassFactoryImpl *)iface; FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } If they are the same, what is needed to complete this stub? I would think that there would be a refCount variable that is incremented if dolock is true and decremented if dolock is false. Also, should the LockServer functions be listed in the spec files of the dlls? After implementing LockServer, it should be an easy matter to do a check for refCount == 0 to see if the dll can be unloaded or not. Am I heading in the right direction? -- James Hawkins

3 4

Debugging of Windows App
by Bernard Gallet 30 Nov '04

30 Nov '04

I am trying to debug a Windows app on Wine. I have the source code, it is compiled with Visual Studio 2002. I have not yet been able to get Line/File info. It is my understanding that winedbg does not recognize pdb, however, I am unable to link without one! Can somebody help? T IA, - Bernard GALLET -

2 1

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage
by Mike McCormack 30 Nov '04

30 Nov '04

The following seemingly simple and harmless change caused a regression in IE6. The toolbar icons are no longer displayed and the error message below appears in the log. err:imagelist:ImageList_LoadImageW Error loading image! Mike Alexandre Julliard wrote: > ChangeSet ID: 14326 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 2004/10/26 16:17:50 > > Modified files: > dlls/shell32/tests: shellpath.c > dlls/shell32 : version.h > > Log message: > Juan Lang <juan_lang(a)yahoo.com> > Update shell32's version to WinXP level. > > Patch: http://cvs.winehq.org/patch.py?id=14326 > > Old revision New revision Changes Path > 1.3 1.4 +0 -2 wine/dlls/shell32/tests/shellpath.c > 1.1 1.2 +4 -4 wine/dlls/shell32/version.h

6 6

Re: acmstream mem leak fix
by MichaelGuennewig＠gmx.de 30 Nov '04

30 Nov '04

James Hawkins <truiken(a)gmail.com> writes: > Unless I'm mistaken, we don't want to free allocated memory only when > the call fails. Sorry, but you are wrong. When you always free the memory you will run into a segmentation fault when the application uses the returned stream. The problem is the same as with the icmstream patch you made. The current implementation will work correctly in all cases although it doesn't look very COM-like as Mike already pointed out for the icmstream patch. The methods you analyzed are only called internally from IClassFactory_fnCreateInstance in the factory.c file. The memory block which is allocated by LocalAlloc in the AVIFILE_CreateICMStream and AVIFILE_CreateACMStream is only returned to the application if the IAVIStream_QueryInterface call doesn't return an error. So when you always free the memory block you will most probably run into a segmentation fault. The proposed patch from Mike for the icmstream.c file should be adapted to this file when you don't like the LocalFree call there, but I'm sure that then people will ask why we don't call LocalFree in this method. So it would be perhaps fine when also some comments would be added to prevent another discussion about what's wrong or correct. When you don't understand the code feel free to write me as I'm the one who has produced it. Regards Michael Günnewig

1 0

<<PATCH>> Added shell32.dll functions to browse for unix directory; altered winecfg to use it to select the root directory of a virtual drive
by Robert van Herk 30 Nov '04

30 Nov '04

Changes: Added functionality to browse for a UNIX folder. This is done by making two new funtions in dlls/shell32/brsfolder.c, namely wine_shell_browse_for_UNIX_directoryA wine_shell_browse_for_UNIX_directoryW These functions are exported in shlobj.h. The original code that allowed just for picking a Windows folder, was split up. It was to be found in brsfolder.c, but I split this in: brsfolder.c brsfolder.h brsfolder_windows.c brsfolder_windows.h brsfolder_unix.c brsfolder_unix.h unixTools.c unixTools.h, Otherwise I found the code to be incomprehendible. Furthermore, winecfg now uses the wine_shell_browse_for_UNIX_directoryA to let the user pick a UNIX directory as root for his virtual drive mappings. Regards, Robert van Herk

1 0