December 2004 - Wine-devel - list.winehq.org

SHBrowseForFolder
by Robert van Herk 02 Dec '04

02 Dec '04

Hi all, I am trying to implement the Browse button in the winecfg application, that would allow people to browse for a directory to use as their virtual c drive. In order to do so, I though I'd use the SHBrowseForFolder function from shlobj.h (see http://msdn.microsoft.com/library/default.asp?url=/library/en-us/shellcc/pl…) However, when I tried this in Wine, I get a compiler warning: In driveui.c I did: case IDC_BUTTON_BROWSE_PATH: SHBrowseForFolder(0); //MessageBox(dialog, "", "Write me!", MB_OK); break; Then, at compile time I get: driveui.c:589: warning: undefined reference to `SHBrowseForFolderA' I made sure that there is a line that says: #include <shlobj.h> When I try to launch the app, I get ./winecfg wine: could not load L"Z:\\home\\robert\\Documents\\devel\\wine\\programs\\winecfg\\winecfg.exe.so": /home/robert/.wine/dosdevices/z:/home/robert/Documents/devel/wine/programs/winecfg/winecfg.exe.so: undefined symbol: SHBrowseForFolderA Does this mean that the SHBrowseForFolder thing is not implemented? Probably it is, because I checked Wine's shlobj.h. What am I doing wrong? Thanks, Robert

9 33

Re: Implement GetLayout
by Shachar Shemesh 02 Dec '04

02 Dec '04

Rémi Assailly wrote: > Shachar Shemesh wrote : > >> Thanks for spotting another one for my growing heap of BiDi TODOs.... >> >> http://bugs.winehq.org/show_bug.cgi?id=2584 >> >> Shachar >> > I know that there is no effect... I'm sorry if I came off cynical. There was no cynicism in that comment. I opened 2584 as a result of seeing your patch. I was not aware of this particular missing functionality. I'm aiming for http://bugs.winehq.org/show_bug.cgi?id=609 to be the ultimate documentation of all BiDi APIs in Windows. Opening 2584 is a good thing, as it documents things that are still to be done. > What is wrong ? It seems that this flag reverses the meaning of several common conventions (left/right etc.). The idea is probably so that applications that are natively right to left not have to change their design too much. I can't tell you exactly what it means, however, as I don't know myself. It will probably be a matter of comparing behaviors to the real Windows. I have some doubts about whether anyone is even using this flag at all. Maybe on localized Hebrew Windows, where the whole window decorations are reversed (Ughh. My GF has localized XP Home installed. This thing is horrible, but I didn't spot any non-Windows native applications that were affected by it). > Tell me and I will help you, if you want... I'll gladly accept all the help I can get. Basically, this particular unimplemented bit requires writing small test programs on Windows, and then running them on Wine until they produce the same results. The idea is that you read the MSDN page for the function (linked from the bug). That page also links to http://msdn.microsoft.com/library/en-us/winui/winui/windowsuserinterface/wi…, which gives more details on what this flag is supposed to mean. If you check out 2584 again, you will see I added this new information there. The steps one takes is to read all the relevant manuals, and try to understand what this means. Next, you write a small test program that does stuff with and without this flag, showing where this flag takes effect on Windows. Next, you move this test program to Wine and start tweaking Wine until it behaves the same there. There is also a last step, which is to make this program into a test suite, returning success or failure. I'm not sure, however, how that is supposed to be done for programs where success and failure are measured with graphical output. Hope this helps you help me help everyone..... :-) Shachar -- Shachar Shemesh Lingnu Open Source Consulting ltd. http://www.lingnu.com/

2 1

Re: [OLE #3] Tests For COM Functions
by Dmitry Timoshkov 02 Dec '04

02 Dec '04

"Robert Shearman" <rob(a)codeweavers.com> wrote: > I have only tried these tests on WinXP SP2. Please report > if they fail on Win9x. In order compile the tests with Platform SDK I applied the attached patch. Under win2k SP4 I got: marshal.c:898: Test failed: CoGetClassObject should have returned CO_E_SERVER_STOPPING instead of 0x80040154 Under Win95 the tests don't run due to missing APIs CoResumeClassObjects and CoInitializeEx. -- Dmitry.

1 1

Re: <<PATCH>> Added shell32.dll functions to browse for unix directory;
by Rolf Kalbermatter 01 Dec '04

01 Dec '04

Robert van Herk wrote: >-LPITEMIDLIST WINAPI SHBrowseForFolderA (LPBROWSEINFOA lpbi) >+static INT_PTR BrowseW (LPBROWSEINFOW lpbi, DLGPROC dlgproc, enum browsemode aBrowseMode) >+{ >+ INT_PTR ret; >+ >+ browseMode = aBrowseMode; ^^^^^^^^^^ I may miss something here but this looks like a global variable and that would make these function theoretically thread unsafe. As long as only winecfg is going to use this functionality for the unix case it seems not a problem as there is probably not any chance that the native Windows version is called at that moment but this may of course change in the future. Rolf Kalbermatter

3 5

MAP_ANON support on HPUX
by Warren_Baird/CSI＠cimmetry.com 01 Dec '04

01 Dec '04

Hi All, I've just discovered that HP-UX's mmap implementation doesn't define MAP_ANON, it only defines MAP_ANONYMOUS. linux defined both, as does solaris (and solaris's manpage actually states that MAP_ANON is deprecated), but MacOS X seems to only define MAP_ANON MAP_ANON is only used in two source files: libs/wine/mmap.c and loader/preloader.c. My proposed patch involves slightly different changes in both places : in mmap.c, I just add a new #elif to handle the case, and in preloader.c I add a #ifdef block at the top to define MAP_ANON to be MAP_ANONYMOUS if MAP_ANON is undefined, but MAP_ANONYMOUS is defined. The other possible solution would be to put the #ifdef block from preloader.c into a common header... It's not obvious to me where to put it, though, which is why I'm proposing this patch. Should I rework it to use a common header? If so - any suggestions as to which header would be appropriate? Thanks, Warren

1 0

Bugzilla in CVS
by Jeremy Newman 01 Dec '04

01 Dec '04

http://cvs.winehq.org/cvsweb/bugzilla/ I have imported our buzilla into CVS for anyone to start submitting patches on. If I remember correctly, it is a fairly straight branch of version 2.17.4. All I modified was the templates in: /template/en/default/global Enjoy!

2 1

Fwd: Re: Bug Busters
by Peter Hartshorn 01 Dec '04

01 Dec '04

May I suggest that the times given are GMT and at least one days notice so everyone who wants to join in can, no matter where they are on the planet. On Wed, 1 Dec 2004 04:10 pm, James Hawkins wrote: > On Tue, 30 Nov 2004 23:58:59 -0500, Adam Babcock <adam(a)nemesys.ca> wrote: > > James Hawkins wrote: > > > I have a totally non-original idea for sessions called Bug Busters > > > where, at a designated time, a group of wine developers would get > > > together on #winehackers (or some other channel). We would pick a bug > > > (or maybe more) from wine's bug tracker and work together to fix the > > > bug(s). This would serve several good purposed. First, we would be > > > giving more attention to wine's bugzilla and getting rid of a lot of > > > those bugs. Second, many newcomers can witness and take part in the > > > wine development process. I'm sure everyone can remember how daunting > > > it is to jump into wine development. Anyway, if anyone has any ideas > > > or would like to take part in this, let me know and we'll get this > > > started. > > > > This is a good idea, same idea as Gentoo Bug Days, and those have been > > extremely successful. > > Awesome, I think it could be really successful with wine too. -------------------------------------------------------

1 0

Re: Resend [AppDB] show total number of maintainers and applications in the appMaintainers table
by Jeremy Newman 01 Dec '04

01 Dec '04

This patch fails to apply to the tip. Update and resend. On Sun, 2004-11-21 at 09:50 -0700, Tony Lambregts wrote: > There was a bug in last one, use this instead. > > Change Log: Show the total number of maintainers and applications in the > appMaintainers table in the admin menu > > Files Changed: include/sidebar_admin.php include/util.php > > > Index: include/sidebar_admin.php > =================================================================== > RCS file: /home/wine/appdb/include/sidebar_admin.php,v > retrieving revision 1.4 > diff -u -r1.4 sidebar_admin.php > --- include/sidebar_admin.php 10 Nov 2004 16:36:25 -0000 1.4 > +++ include/sidebar_admin.php 21 Nov 2004 07:50:43 -0000 > @@ -19,7 +19,7 @@ > $g->add("List Users", $apidb_root."admin/"); > $g->add("View App Queue (".getQueuedAppCount().")", $apidb_root."admin/adminAppQueue.php"); > $g->add("View Maintainer Queue (".getQueuedMaintainerCount().")", $apidb_root."admin/adminMaintainerQueue.php"); > - $g->add("View Maintainers", $apidb_root."admin/adminMaintainers.php"); > + $g->add("View Maintainers (".getMaintainerCount().")", $apidb_root."admin/adminMaintainers.php"); > $g->done(); > > } > Index: include/util.php > =================================================================== > RCS file: /home/wine/appdb/include/util.php,v > retrieving revision 1.4 > diff -u -r1.4 util.php > --- include/util.php 9 Nov 2004 22:51:38 -0000 1.4 > +++ include/util.php 21 Nov 2004 07:50:43 -0000 > @@ -189,4 +189,13 @@ > return $ob->queued_maintainers; > } > > +/* get the total number of maintainers and applications in the appMaintainers table */ > +function getMaintainerCount() > +{ > + $qstring = "SELECT count(*) as maintainers FROM appMaintainers"; > + $result = mysql_query($qstring); > + $ob = mysql_fetch_object($result); > + return $ob->maintainers; > +} > + > ?> > > > >

1 0

Re: Always create a suspended thread in CreateThread and resume it if CREATE_SUSPENDED flag is not set as Windows does
by pvriens＠xs4all.nl 01 Dec '04

01 Dec '04

Hi, just wanted to mention the fact that after this fix, my ZooTycoon demo installs like a charm. It doesn't run yet, but I will look into this and hopefully come up with some answers/patches. I guess several Microsoft Game Installers will work as well now. Good stuff. Cheers, Paul Vriens.

1 0

Re: gdi/mfdrv BS_PATTERN brushes
by Huw D M Davies 01 Dec '04

01 Dec '04

On Mon, Nov 29, 2004 at 09:16:49PM -0800, Walt Ogburn wrote: > > This fixes the problem that Emanuele Gisi reported last month in the Aloha > problem. With this patch BS_PATTERN brushes get created correctly and > don't cause a locking problem. > > Changelog: > Fix creation of BS_PATTERN brushes in mfdrv > > > Index: dlls/gdi/mfdrv/objects.c > =================================================================== > RCS file: /home/wine/wine/dlls/gdi/mfdrv/objects.c,v > retrieving revision 1.14 > diff -u -r1.14 objects.c > --- dlls/gdi/mfdrv/objects.c 22 Nov 2004 18:19:59 -0000 1.14 > +++ dlls/gdi/mfdrv/objects.c 30 Nov 2004 06:10:03 -0000 > - mr->rdFunction = META_DIBCREATEPATTERNBRUSH; > + mr->rdFunction = META_CREATEPATTERNBRUSH; Does a BS_PATTERN brush really create a META_CREATEPATTERNBRUSH record under Windows? Huw. -- Huw Davies huw(a)codeweavers.com

2 1