March 2004 - Wine-devel - list.winehq.org

Re: To Do A.11 - Integrate API status into WineHQ
by hatky 24 Mar '04

24 Mar '04

On Wednesday 24 March 2004 22:19, you wrote: > On Wed, 24 Mar 2004, hatky wrote: > > It looks complicated but it's all 3 mysql commands to > > get a complete table > > with whatever data you want from the winapi stats data > > in a nice table... > > [...] > > > comments? > > Yeah, there's no need for a database. Right now Francois' > soluions works perfectly fine without a DB, please don't > use one. I say this is not acceptable, but is up to > laxdragon, he's the website maintainer. It uses DB only for creating the file as a parser becouse it's 3 lines of code instade of 30 line parsing and very very flexable, I talked to laxdragon, he has not problem with it, he is still reviewing it... -- Hatky, Worshiper of wine (http://www.winehq.org/ or http://hatky.myz.info/wine/) Impossible is only an opinion. __________________________________ Do you Yahoo!? Yahoo! Finance Tax Center - File online. File on time. http://taxes.yahoo.com/filing.html

1 0

Missing WWN issues
by Francois Gouget 24 Mar '04

24 Mar '04

Looking through the WINeHQ CVS I noticed that we are missing 4 WWN issues. Fortunately they seem to be available at the Wine Kernel Cousin web site... sort of. Would some kind soul volunteer for retrieving what can be retrieved? * WWN 88 and WWN 89 http://www.kerneltraffic.org/wine/wn20010314_88.html http://www.kerneltraffic.org/wine/wn20010315_89.html Unfortunately these two appear to be empty so there's not much to save. * WWN 90 http://www.kerneltraffic.org/wine/wn20010409_90.html Eric Pouech's call for a replacement. * WWN 91 http://www.kerneltraffic.org/wine/wn20010415_91.html Brian Vincent's first WWN. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Hiroshima '45 - Czernobyl '86 - Windows '95

2 1

Re: winetest: add support for revision info
by Ferenc Wagner 24 Mar '04

24 Mar '04

This patch goes somewhat against Dimi's. Instead of invoking cvs, it extracts the working revision info from the CVS/Entries files resulting in speedy operation. Thus I incorporated all the stuff into maketest, executing unconditionally. Hope it is still portable. ChangeLog: - Extract revision info from CVS/Entries. - #include "winetest.rc" into gui.rc. MinGW can't link in more than one resource files. - Enlarge chunk size of network transfer. Index: Makefile.in =================================================================== RCS file: /home/wine/wine/programs/winetest/Makefile.in,v retrieving revision 1.23 diff -u -r1.23 Makefile.in --- Makefile.in 20 Mar 2004 19:21:39 -0000 1.23 +++ Makefile.in 22 Mar 2004 23:03:43 -0000 @@ -1,4 +1,5 @@ TOPSRCDIR = @top_srcdir@ +export TOPSRCDIR TOPOBJDIR = ../.. SRCDIR = @srcdir@ VPATH = @srcdir@ @@ -13,8 +14,7 @@ util.c RC_SRCS = \ - gui.rc \ - winetest.rc + gui.rc RC_BINSRC = gui.rc RC_BINARIES = wine.ico @@ -46,9 +46,6 @@ winetest.rc: maketest Makefile.in $(SRCDIR)/maketest $(TESTBINS) > $@ || ( $(RM) $@ && exit 1 ) - -revision.info: - (cd $(TOPSRCDIR); for file in dlls/*/tests/*.c; do rev=`cvs stat "$$file" | grep "Working" | awk '{print $$3}'`; echo "$$file:$$rev"; done) > $@ || ( $(RM) $@ && exit 1 ) winetest.res: $(TESTBINS) Index: gui.rc =================================================================== RCS file: /home/wine/wine/programs/winetest/gui.rc,v retrieving revision 1.2 diff -u -r1.2 gui.rc --- gui.rc 2 Mar 2004 20:56:35 -0000 1.2 +++ gui.rc 22 Mar 2004 23:03:43 -0000 @@ -21,6 +21,7 @@ #include <windows.h> #include <winres.h> #include "guires.h" +#include "winetest.rc" /* for the MinGW cross-compiler */ IDD_STATUS DIALOG 0, 0, 160, 140 STYLE WS_OVERLAPPEDWINDOW Index: main.c =================================================================== RCS file: /home/wine/wine/programs/winetest/main.c,v retrieving revision 1.7 diff -u -r1.7 main.c --- main.c 20 Mar 2004 19:21:39 -0000 1.7 +++ main.c 22 Mar 2004 23:03:43 -0000 @@ -140,7 +140,6 @@ } snprintf(buffer, sizeof(buffer), "dlls/%s/tests/%s.c", test, subtest); - fprintf(stderr, "file=%s\n", buffer); return buffer; } @@ -149,36 +148,35 @@ const struct rev_info* rev; for(rev = rev_infos; rev->file; rev++) { - fprintf(stderr, " ?{%s:%s)\n", rev->file, rev->rev); if (strcmp(rev->file, file) == 0) return rev->rev; } - return ""; + return "-"; } void extract_rev_infos () { char revinfo[256], *p; - int size = 0, i = 0, len; + int size = 0, i, len; HMODULE module = GetModuleHandle (NULL); for (i = 0; TRUE; i++) { if (i >= size) { size += 100; - rev_infos = xrealloc(rev_infos, size); + rev_infos = xrealloc (rev_infos, size * sizeof (*rev_infos)); } memset(rev_infos + i, 0, sizeof(rev_infos[i])); len = LoadStringA (module, i + 30000, revinfo, sizeof(revinfo)); if (len == 0) break; /* end of revision info */ - if (len >= sizeof(revinfo)) + if (len >= sizeof(revinfo) - 1) report (R_FATAL, "Revision info too long."); if(!(p = strrchr(revinfo, ':'))) report (R_FATAL, "Revision info malformed (i=%d)", i); *p = 0; rev_infos[i].file = strdup(revinfo); rev_infos[i].rev = strdup(p + 1); - } while(1); + } } void* extract_rcdata (int id, DWORD* size) @@ -196,7 +194,7 @@ return addr; } -/* Fills out the name, is_elf and exename fields */ +/* Fills in the name, is_elf and exename fields */ void extract_test (struct wine_test *test, const char *dir, int id) { @@ -459,48 +457,45 @@ cmdLine = mystrtok (cmdLine); while (cmdLine) { - if (*cmdLine == '-') - if (cmdLine[2]) { - report (R_ERROR, "Not a single letter option: %s", - cmdLine); - usage (); - exit (2); - } - cmdLine++; - switch (*cmdLine) { - case 'c': - report (R_TEXTMODE); - break; - case 'h': - usage (); - exit (0); - case 'q': - report (R_QUIET); - break; - case 's': - submit = mystrtok (NULL); - if (tag) - report (R_WARNING, "ignoring tag for submit"); - send_file (submit); - break; - case 'o': - logname = mystrtok (NULL); - run_tests (logname, tag); - break; - case 't': - tag = mystrtok (NULL); - cp = badtagchar (tag); - if (cp) { - report (R_ERROR, "invalid char in tag: %c", *cp); - usage (); - exit (2); - } - break; - default: - report (R_ERROR, "invalid option: -%c", *cmdLine); + if (cmdLine[0] != '-' || cmdLine[2]) { + report (R_ERROR, "Not a single letter option: %s", cmdLine); + usage (); + exit (2); + } + switch (cmdLine[1]) { + case 'c': + report (R_TEXTMODE); + break; + case 'h': + usage (); + exit (0); + case 'q': + report (R_QUIET); + break; + case 's': + submit = mystrtok (NULL); + if (tag) + report (R_WARNING, "ignoring tag for submit"); + send_file (submit); + break; + case 'o': + logname = mystrtok (NULL); + run_tests (logname, tag); + break; + case 't': + tag = mystrtok (NULL); + cp = badtagchar (tag); + if (cp) { + report (R_ERROR, "invalid char in tag: %c", *cp); usage (); exit (2); } + break; + default: + report (R_ERROR, "invalid option: -%c", cmdLine[1]); + usage (); + exit (2); + } cmdLine = mystrtok (NULL); } if (!logname && !submit) { Index: maketest =================================================================== RCS file: /home/wine/wine/programs/winetest/maketest,v retrieving revision 1.4 diff -u -r1.4 maketest --- maketest 20 Mar 2004 19:21:39 -0000 1.4 +++ maketest 22 Mar 2004 23:03:43 -0000 @@ -16,13 +16,15 @@ echo "$i \"$test\"" done -if [ -f revision.info ]; then - i=0 - for line in `cat revision.info`; do - i=`expr $i + 1` - echo "$i+30000 \"$line\"" - done -fi +i=30000 +cd $TOPSRCDIR +for dir in dlls/*/tests; do + sed -ne "s|^/$[^.]*.c$/$[^/]*$.*|$dir/\1:\2|p" $dir/CVS/Entries 2>/dev/null +done |\ +while read; do + echo "$i \"$REPLY\"" + i=`expr $i + 1` +done echo "}" Index: send.c =================================================================== RCS file: /home/wine/wine/programs/winetest/send.c,v retrieving revision 1.7 diff -u -r1.7 send.c --- send.c 19 Mar 2004 19:15:23 -0000 1.7 +++ send.c 22 Mar 2004 23:03:43 -0000 @@ -158,7 +158,7 @@ report (R_STATUS, "Sending %u bytes of data", filesize); report (R_PROGRESS, 2, filesize); - while ((bytes_read = fread (buffer, 1, BUFLEN / 8, f))) { + while ((bytes_read = fread (buffer, 1, BUFLEN / 2, f))) { if (send_buf (s, buffer, bytes_read)) { report (R_WARNING, "Error sending body: %d, %d", errno, WSAGetLastError ());

2 4

appdb bug
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

On this page http://appdb.winehq.org/appview.php?appId=935&versionId=1229 there should be 6 comments, but only 2 are displayed, can someone hacking one the appdb code, or J.N. look into this? Ivan.

3 2

Appdb bug
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

The search from the admin pages returns a 404 error: The requested URL /admin/search.php was not found on this server. Can someone please fix this? Ivan.

2 1

Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.
by Uwe Bonnes 24 Mar '04

24 Mar '04

>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: C> Add minimal parameter validation to function C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon Providing a test case for such special behaviour is a good idea... -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 4

Re: CURSORICON_SimulateLoadingFromResourceW param check. VFP6 EXEs now work.
by Stefan Leichter 24 Mar '04

24 Mar '04

Hello Uwe, i fear your test will only test what you like to test if it is executed in the source directory. For "out of tree builds" your test case tests how LoadImageA behaves when the specified file does not exist. Bye Stefan Am Dienstag, 23. März 2004 21:29 schrieb Uwe Bonnes: > >>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: > > C> Uwe Bonnes wrote: > >>>>>>> "C" == C Daniel Mojoli B <cdmojoli(a)idea.com.py> writes: > > C> Add minimal parameter validation to function > C> CURSORICON_SimulateLoadingFromResourceW(...). We check that the icon > > >> Providing a test case for such special behaviour is a good idea... > > C> I created this patch as a result of consulting I performed at a > C> customer's site. I no longer have access to the winedbg info I had > > It this what you meant? > > The test succeeds on NT and crashes on wine

2 2

Re: Problem with code in WWN 214
by Brian Vincent (C) 24 Mar '04

24 Mar '04

> WWN 214 contains some sample code and in my browser I see: > There are two things that are wrong: > * The #include statements are incomplete. That's because the HTML looks > like this: Yeah, that's just a problem with the server side stuff. Newman - do you happen to know why? Seems like an XML parser thing. > ' ' results in two line feeds eventhough that may be a bug in There should not be a ... the real tag is which is both XML and HTML compliant. <pre> is an evil tag if you use CSS, it should never be used on WineHQ. This does bring up a good point, <code> displays weird on WineHQ, compare it to how Zack does it: http://www.kerneltraffic.org/wine/wn20040312_214.html I think the problem is for two reasons: 1) There's no CSS definition for BR. There should be and maybe it should look something like: { margin-bottom: 3px; margin-top: 3px } Likewise, I tend to use <ul> for doing indenting and it needs to have less whitespace above and below. Or, maybe <dl> could be changed and I can abuse that instead. 2) That particular instance has some markup problems, I put in a couple of extra tags in a few places. Corollary to Linus' feelings on backups: Proofreading is for wimps. Real men publish their writing to a news site and have everyone else spellcheck it. (Although, you'll notice since Newman set me up with CVS acces I do tend to do a quick once over after committing it and then fix obvious mistakes. If you have any scripts that automate this I should be able to easily automate it into the existing publishing system I have. XML doesn't lend itself to spellchecking too easily, so I've never pursued it.) --------------- Brian Vincent Copper Mountain Telecom vincentb(a)coppercolorado.com

2 1

Re: Cards.dll improvements
by Filip Navara 24 Mar '04

24 Mar '04

Sam wrote: >This patch implements card drawing mode flag >for rounding card corners. > >Sami Nopanen, xasmx(a)optonline.net > > I know it was propably suggested earlier, but why don't you use (or adapt) my cards.dll implementation for ReactOS? http://cvs.reactos.com/cgi-bin/cvsweb.cgi/reactos/lib/cards/ Regards, Filip

1 0

Re: Win32 packages released on sourceforge
by Ivan Leo Murray-Smith 24 Mar '04

24 Mar '04

> I am kind of holding my breath for a regular build of winetest.exe - any > chance for that soon? :-) It depends on how you define regular. If you mean daily/weekly builds, I have no idea. But I can build winetest.exe when I build the win32 packages, when A.J. releases wine. Ivan.

9 30